samiandClaude Opus 5
53421d6cb8
Schemas for the whole v1 surface: 38 methods, 9 events, 25 named types and the
JSON-RPC envelope, with x-privileged / x-transports / x-deadlineMs / x-errors
annotations that both generators emit as data rather than prose.
Four generators over one IR (contracts/codegen/schema_ir.py), so the C++ structs,
the TypeScript types and the OpenRPC document cannot disagree about what the
contract says:
gen_cpp.py -> core/generated/velox_proto.{hpp,cpp}
gen_ts.py -> extension/src/shared/protocol/
gen_openrpc.py -> contracts/openrpc.json
gen_cpp_conformance.py -> tests/conformance/cpp/fixture_dispatcher.hpp
Inbound parsing never throws: parse<T>() returns std::expected<T, ParseError> and
nlohmann's throwing ADL from_json is deliberately not emitted. Schema constraints
(minimum, maxLength, pattern, ...) become real runtime checks in both languages —
the daemon does not trust the extension and the extension does not trust the
daemon.
59 golden fixtures: a success case per method, 12 error cases, 9 events. Replayed
by tests/conformance/ against both the generated C++ and a live server over both
transports. tools/mockd serves the same fixtures with unhappy-path flags so the
GUI and EXT lanes never wait for veloxd.
run.sh also proves capture.offer fails open: with a daemon answering slower than
750 ms the client gives up and lets Firefox take the download.
core/generated/ is libveloxproto, a separate target from libveloxcore, which
still never sees JSON — see docs/adr/0009.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_012fgjnqFCS5h5L7gZTZo3rV
21 lines
837 B
CMake
21 lines
837 B
CMake
# Conformance runner, C++ side. Owned by lane PROTO.
|
|
#
|
|
# Links libveloxproto (the generated protocol code in core/generated/), not libveloxcore:
|
|
# this exercises the wire types, which is a separate concern from the engine. See
|
|
# docs/adr/0009-generated-protocol-library.md.
|
|
|
|
add_executable(velox_conformance_cpp
|
|
conformance_main.cpp
|
|
${CMAKE_SOURCE_DIR}/core/generated/velox_proto.cpp)
|
|
|
|
target_include_directories(velox_conformance_cpp PRIVATE
|
|
${CMAKE_SOURCE_DIR}/core/generated
|
|
${CMAKE_CURRENT_SOURCE_DIR})
|
|
|
|
target_compile_features(velox_conformance_cpp PRIVATE cxx_std_23)
|
|
target_link_libraries(velox_conformance_cpp PRIVATE nlohmann_json::nlohmann_json)
|
|
|
|
# The runner needs the repository root so it can find contracts/fixtures.
|
|
add_test(NAME conformance_cpp
|
|
COMMAND velox_conformance_cpp ${CMAKE_SOURCE_DIR})
|