samiandClaude Sonnet 5
60363a7142
Minor bump on 1.0.0, per core/docs/buffer-sizing.md. B4 — bufferBytes bounds corrected in all four locations (DownloadSpec, TaskDetail, download.update's patch, Settings.connection.bufferBytes): was 4 KiB-8 MiB with no stated default, now 64 KiB-16 MiB with a 1 MiB default. 64 KiB because 4 KiB is smaller than one libcurl HTTP/2 write-callback delivery; 16 MiB because throughput from write size is flat past ~1-4 MiB and past 16 MiB there is stall-cover left to buy but no memory left to spend it on; 1 MiB default because it is the only candidate for which docs/04's 60 MB RSS target actually holds once buffers are counted per segment, not per download. Two new settings keys: connection.maxTotalBufferBytes (128 MiB default) and connection.maxActiveSegments (32 default). Without them CORE's clamp — reduce every live segment's buffer to fit the global cap — has no wire configuration surface, and "20 active downloads" has no meaning distinct from 160 live TLS connections. B2a — TaskDetail.effectiveBufferBytes: what a segment is actually using right now, after the clamp. Placed on TaskDetail next to bufferBytes, following the requested/effective pattern ADR 0010 already established for segments. The download.get fixture now demonstrates a real clamp (16 MiB requested, 4 MiB effective) rather than a case where the cap happens not to bind. docs/04-engine-design.md §4 and §8 updated in the same change per CORE's request and CLAUDE.md rule 5: the RSS target is now stated as conditional on maxActiveSegments = 32, and the old 4 MiB/64 MiB/256 MiB numbers are corrected to match the schema. ADR 0012 records the reasoning and explicitly keeps the 60 MB target over CORE's offered 120 MB alternative, with the arithmetic that makes 60 MB achievable with margin. Numbered 0012 rather than 0011: DAEMON is independently drafting ADR 0011 (admission control / segment budget split) in a peer session at time of writing, so 0011 was reserved to avoid a collision. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_012fgjnqFCS5h5L7gZTZo3rV
41 lines
1.4 KiB
JSON
41 lines
1.4 KiB
JSON
{
|
|
"name": "settings.get \u2014 the Connection tab's keys",
|
|
"description": "Privileged: the settings bag names local paths and the allowed write roots, which the extension has no business enumerating.",
|
|
"request": {
|
|
"jsonrpc": "2.0",
|
|
"id": 50,
|
|
"method": "settings.get",
|
|
"params": {
|
|
"keys": [
|
|
"connection.maxSegmentsPerDownload",
|
|
"connection.bufferBytes",
|
|
"connection.maxTotalBufferBytes",
|
|
"connection.maxActiveSegments",
|
|
"connection.maxConcurrentDownloads",
|
|
"connection.timeoutSec"
|
|
]
|
|
}
|
|
},
|
|
"response": {
|
|
"jsonrpc": "2.0",
|
|
"id": 50,
|
|
"result": {
|
|
"values": {
|
|
"connection.maxSegmentsPerDownload": 8,
|
|
"connection.bufferBytes": 1048576,
|
|
"connection.maxTotalBufferBytes": 134217728,
|
|
"connection.maxActiveSegments": 32,
|
|
"connection.maxConcurrentDownloads": 5,
|
|
"connection.timeoutSec": 30
|
|
}
|
|
}
|
|
},
|
|
"assertions": [
|
|
"only the requested keys come back",
|
|
"keys null returns everything",
|
|
"no password is ever present: credentials live in the Secret Service",
|
|
"connection.bufferBytes defaults to 1 MiB (1048576), not the old 4 MiB",
|
|
"connection.maxTotalBufferBytes and connection.maxActiveSegments are the two knobs behind TaskDetail.effectiveBufferBytes; Options cannot show or set the clamp without them"
|
|
]
|
|
}
|