samiandClaude Sonnet 5
203d4a662f
Verified PKG's landed CI (.github/workflows/ci.yml, db7650b/8f45815) against this lane's actual tree, per the standing instruction that conformance as a required check is this lane's DoD to verify, not PKG's. It wasn't running: the `conformance` job's presence-check looks for tests/conformance/CMakeLists.txt or tests/conformance/package.json, and neither existed -- the job was silently short-circuiting to a green "skipped" on every PR, forever. The M0 exit gate was not gating anything. tests/conformance/CMakeLists.txt registers one ctest entry, labeled "conformance", that shells out to run.sh -- the exact command tests/conformance/README.md tells a human to run locally, so there is one definition of "the suite passed", not a CMake-flavoured near-duplicate of it. cpp/CMakeLists.txt's existing conformance_cpp test gets the same label, for a lane iterating on core/generated/ who wants the fast native-only path. Fixed a second landmine found while wiring this: the root CMakeLists.txt only find_package(nlohmann_json)'s when daemon/CMakeLists.txt exists, since daemon is its real consumer -- but daemon hasn't landed yet, so add_subdirectory(tests/conformance) would have failed to configure the moment this file existed, on every machine, until daemon merges. Fixed inside tests/conformance/cpp/CMakeLists.txt with an if(NOT TARGET) guard rather than widening the root file's condition, which is PKG's to change. run.sh now installs its own Python deps (jsonschema, referencing) on demand: they aren't in tools/bootstrap.sh's apt list -- that's PKG's script, these are this suite's own dependency -- so a bare CI image would otherwise fail check_contract.py with an ImportError before this suite even started. Verified end to end: `cmake --preset dev && ctest --test-dir build/dev -R '^conformance$'` passes in 23.8s, exercising the exact command and label the CI job uses. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_012fgjnqFCS5h5L7gZTZo3rV
30 lines
1.3 KiB
CMake
30 lines
1.3 KiB
CMake
# Conformance runner, C++ side. Owned by lane PROTO.
|
|
#
|
|
# Links libveloxproto (the generated protocol code in core/generated/), not libveloxcore:
|
|
# this exercises the wire types, which is a separate concern from the engine. See
|
|
# docs/adr/0009-generated-protocol-library.md.
|
|
|
|
# The root CMakeLists.txt only find_package(nlohmann_json)'s when daemon/CMakeLists.txt
|
|
# exists (daemon is its real consumer), so this target may not exist yet when this
|
|
# directory configures on its own — this suite must not depend on daemon having landed.
|
|
# Self-sufficient rather than reaching into the root file to widen that guard.
|
|
if(NOT TARGET nlohmann_json::nlohmann_json)
|
|
find_package(nlohmann_json 3.11 REQUIRED)
|
|
endif()
|
|
|
|
add_executable(velox_conformance_cpp
|
|
conformance_main.cpp
|
|
${CMAKE_SOURCE_DIR}/core/generated/velox_proto.cpp)
|
|
|
|
target_include_directories(velox_conformance_cpp PRIVATE
|
|
${CMAKE_SOURCE_DIR}/core/generated
|
|
${CMAKE_CURRENT_SOURCE_DIR})
|
|
|
|
target_compile_features(velox_conformance_cpp PRIVATE cxx_std_23)
|
|
target_link_libraries(velox_conformance_cpp PRIVATE nlohmann_json::nlohmann_json)
|
|
|
|
# The runner needs the repository root so it can find contracts/fixtures.
|
|
add_test(NAME conformance_cpp
|
|
COMMAND velox_conformance_cpp ${CMAKE_SOURCE_DIR})
|
|
set_tests_properties(conformance_cpp PROPERTIES LABELS "conformance")
|