samiandClaude Opus 5
53421d6cb8
Schemas for the whole v1 surface: 38 methods, 9 events, 25 named types and the
JSON-RPC envelope, with x-privileged / x-transports / x-deadlineMs / x-errors
annotations that both generators emit as data rather than prose.
Four generators over one IR (contracts/codegen/schema_ir.py), so the C++ structs,
the TypeScript types and the OpenRPC document cannot disagree about what the
contract says:
gen_cpp.py -> core/generated/velox_proto.{hpp,cpp}
gen_ts.py -> extension/src/shared/protocol/
gen_openrpc.py -> contracts/openrpc.json
gen_cpp_conformance.py -> tests/conformance/cpp/fixture_dispatcher.hpp
Inbound parsing never throws: parse<T>() returns std::expected<T, ParseError> and
nlohmann's throwing ADL from_json is deliberately not emitted. Schema constraints
(minimum, maxLength, pattern, ...) become real runtime checks in both languages —
the daemon does not trust the extension and the extension does not trust the
daemon.
59 golden fixtures: a success case per method, 12 error cases, 9 events. Replayed
by tests/conformance/ against both the generated C++ and a live server over both
transports. tools/mockd serves the same fixtures with unhappy-path flags so the
GUI and EXT lanes never wait for veloxd.
run.sh also proves capture.offer fails open: with a daemon answering slower than
750 ms the client gives up and lets Firefox take the download.
core/generated/ is libveloxproto, a separate target from libveloxcore, which
still never sees JSON — see docs/adr/0009.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_012fgjnqFCS5h5L7gZTZo3rV
34 lines
1.0 KiB
JSON
34 lines
1.0 KiB
JSON
{
|
|
"name": "session.hello \u2014 a client built against protocol 2.x is refused",
|
|
"description": "Major mismatch fails loudly at connect rather than subtly at the tenth field. The GUI renders this as 'Velox needs updating'.",
|
|
"request": {
|
|
"jsonrpc": "2.0",
|
|
"id": 100,
|
|
"method": "session.hello",
|
|
"params": {
|
|
"clientType": "gui",
|
|
"clientName": "velox-gui 9.9.9",
|
|
"protocolVersion": "2.0.0"
|
|
}
|
|
},
|
|
"response": {
|
|
"jsonrpc": "2.0",
|
|
"id": 100,
|
|
"error": {
|
|
"code": -32001,
|
|
"message": "protocol major version mismatch: daemon speaks 1.x, client speaks 2.x",
|
|
"data": {
|
|
"expected": "1.0.0",
|
|
"actual": "2.0.0"
|
|
}
|
|
}
|
|
},
|
|
"assertions": [
|
|
"the connection is closed after this reply; no method is served on a mismatched major",
|
|
"a differing minor or patch is accepted, never refused",
|
|
"the message is safe to show a user verbatim",
|
|
"the version check is transport-independent; this is replayed on the Unix socket so it is not masked by -32002"
|
|
],
|
|
"transport": "uds"
|
|
}
|