samiandClaude Opus 5
53421d6cb8
Schemas for the whole v1 surface: 38 methods, 9 events, 25 named types and the
JSON-RPC envelope, with x-privileged / x-transports / x-deadlineMs / x-errors
annotations that both generators emit as data rather than prose.
Four generators over one IR (contracts/codegen/schema_ir.py), so the C++ structs,
the TypeScript types and the OpenRPC document cannot disagree about what the
contract says:
gen_cpp.py -> core/generated/velox_proto.{hpp,cpp}
gen_ts.py -> extension/src/shared/protocol/
gen_openrpc.py -> contracts/openrpc.json
gen_cpp_conformance.py -> tests/conformance/cpp/fixture_dispatcher.hpp
Inbound parsing never throws: parse<T>() returns std::expected<T, ParseError> and
nlohmann's throwing ADL from_json is deliberately not emitted. Schema constraints
(minimum, maxLength, pattern, ...) become real runtime checks in both languages —
the daemon does not trust the extension and the extension does not trust the
daemon.
59 golden fixtures: a success case per method, 12 error cases, 9 events. Replayed
by tests/conformance/ against both the generated C++ and a live server over both
transports. tools/mockd serves the same fixtures with unhappy-path flags so the
GUI and EXT lanes never wait for veloxd.
run.sh also proves capture.offer fails open: with a daemon answering slower than
750 ms the client gives up and lets Firefox take the download.
core/generated/ is libveloxproto, a separate target from libveloxcore, which
still never sees JSON — see docs/adr/0009.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_012fgjnqFCS5h5L7gZTZo3rV
30 lines
1.4 KiB
JSON
30 lines
1.4 KiB
JSON
{
|
|
"name": "capture.offer \u2014 the daemon does not answer within 750 ms",
|
|
"description": "The most important test in this directory. The daemon is slow, wedged or gone; the extension must abandon the offer and let Firefox download the file normally. A download manager that eats downloads when its daemon is down is worse than no download manager, and this behaviour is non-negotiable.",
|
|
"kind": "timeout",
|
|
"deadlineMs": 750,
|
|
"request": {
|
|
"jsonrpc": "2.0",
|
|
"id": 110,
|
|
"method": "capture.offer",
|
|
"params": {
|
|
"url": "https://releases.ubuntu.com/26.04/ubuntu-26.04-desktop-amd64.iso",
|
|
"method": "GET",
|
|
"tabUrl": "https://releases.ubuntu.com/26.04/",
|
|
"contentType": "application/octet-stream",
|
|
"contentLength": 6228541440,
|
|
"origin": "moz-extension://11111111-2222-3333-4444-555555555555"
|
|
}
|
|
},
|
|
"response": null,
|
|
"assertions": [
|
|
"the extension gives up at 750 ms measured from send, not from connect",
|
|
"webRequest returns {} so Firefox downloads the file itself",
|
|
"no task is created, and the user sees the download in Firefox's own list",
|
|
"the extension does not retry: a retry would race the browser's own download",
|
|
"the same behaviour applies when the transport is disconnected entirely",
|
|
"reproduced against mockd with --slow 2000, and by killing the daemon outright"
|
|
],
|
|
"requires": "a daemon that is slow, wedged or absent"
|
|
}
|