samiandClaude Opus 5
2c8f5e5d7d
Three corrections into 1.0.0, all of which would be major bumps once the contract has landed. It has not: main still carries 1.0.0-draft, so these are corrections to an unpublished version rather than changes to a released one. ADR 0010 records that and the reasoning behind each. B1 — TaskError.code was a bare integer, and the integer space in the contract is JSON-RPC's, which is a different thing; TaskError's own description said so while typing its code as one. Freeze TaskErrorCode: a string enum mirroring vdm::Error by name and in order, all 27 failure values, verified against core/include/vdm/util/error.hpp mechanically. ErrorCode says why a call failed; TaskErrorCode says why a download failed, and a download fails while every RPC succeeds. Adds TaskError.cause so max_retries_exhausted names what kept failing. B2 — TaskSummary.segments is now explicitly the effective count in use right now, after the per-host cap and the non-resumable demotion to 1. DownloadSpec.segments and download.update's patch say they are the requested value. B3 — Segment.endByte's "minimum: 0" contradicted the description's own empty-range encoding of startByte - 1, which is -1 for the first segment of every download. Empty ranges are no longer representable and are not needed. The range stays CLOSED and INCLUSIVE, matching the HTTP Range header the two fields are copied into verbatim, and that is now stated in the schema, the README, an ADR, a fixture assertion and a conformance check. CORE asked for half-open and gets a written notice rather than a silent schema edit. Segment state spells 'downloading' as CORE asked, not 'receiving'. check_contract.py now enforces segment contiguity, coverage of exactly [0, sizeBytes-1], downloadedBytes within the range size, and the entry count matching TaskSummary.segments. The download.get fixture claimed 8 segments while carrying 2; it now carries 8 contiguous ones covering the whole file. contracts/proto-answers-m1.md answers every item in core/docs/proto-requests-m1.md, including the ones not being landed now: B2a and F2 accepted as follow-ups, F1 answered with the notify path for M1, F3 already frozen as a Checksum object rather than a string, and D1 left for DAEMON to draft as the three-way ADR it is. Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_012fgjnqFCS5h5L7gZTZo3rV
58 lines
2.1 KiB
JSON
58 lines
2.1 KiB
JSON
{
|
|
"name": "event.task.state \u2014 a task fails because the file vanished from the server",
|
|
"description": "Carries the summary so the row repaints in full, and the error whenever the new state is failed or retry_wait. Note that error.code is a TaskErrorCode string, not a JSON-RPC code: the RPC that reported this failure succeeded.",
|
|
"notification": {
|
|
"jsonrpc": "2.0",
|
|
"method": "event.task.state",
|
|
"params": {
|
|
"taskId": "3f7a2b1c-5d6e-4f80-9a1b-2c3d4e5f6071",
|
|
"state": "failed",
|
|
"previousState": "downloading",
|
|
"summary": {
|
|
"taskId": "3f7a2b1c-5d6e-4f80-9a1b-2c3d4e5f6071",
|
|
"filename": "ubuntu-26.04-desktop-amd64.iso",
|
|
"saveDir": "/home/sami/Downloads/Programs",
|
|
"url": "https://releases.ubuntu.com/26.04/ubuntu-26.04-desktop-amd64.iso",
|
|
"effectiveUrl": "https://releases.ubuntu.com/26.04/ubuntu-26.04-desktop-amd64.iso",
|
|
"sizeBytes": 6228541440,
|
|
"downloadedBytes": 0,
|
|
"state": "failed",
|
|
"speedBps": 0,
|
|
"etaSeconds": null,
|
|
"resumable": true,
|
|
"segments": 8,
|
|
"categoryId": "programs",
|
|
"queueId": null,
|
|
"queuePosition": null,
|
|
"description": null,
|
|
"createdAt": "$isoDate",
|
|
"lastTryAt": "$isoDate",
|
|
"completedAt": null,
|
|
"error": {
|
|
"code": "not_found",
|
|
"message": "the server returned 404 when resuming; the file is gone",
|
|
"httpStatus": 404,
|
|
"retryable": false,
|
|
"cause": null,
|
|
"attempt": 3,
|
|
"nextRetryAt": null
|
|
}
|
|
},
|
|
"error": {
|
|
"code": "not_found",
|
|
"message": "the server returned 404 when resuming; the file is gone",
|
|
"httpStatus": 404,
|
|
"retryable": false,
|
|
"cause": null,
|
|
"attempt": 3,
|
|
"nextRetryAt": null
|
|
}
|
|
}
|
|
},
|
|
"assertions": [
|
|
"error is present exactly when state is failed or retry_wait",
|
|
"error.code is a TaskErrorCode, never a JSON-RPC ErrorCode \u2014 the two are different spaces",
|
|
"retryable false means the scheduler will not pick this up again on its own"
|
|
]
|
|
}
|