samiandClaude Sonnet 5
de83ee3cce
Continues the build order past the Add-URL/File-Info/Progress dialog flow.
- OptionsDialog: General/Save To/Connection/Downloads/Proxy/Sounds tabs, every
control bound to a real settings.* key (contracts/schema/types/Settings.
schema.json). The spec's File Types and Site Logins tabs have no settings.*
backing (categories go through category.upsert, credentials through the
Secret Service) so they don't exist here — a tab either binds to a real key
or isn't shipped. diffChanged() sends only what actually changed, matching
settings.set's "changed[] names exactly what took effect" contract.
- SchedulerDialog: per-queue schedule (schedule.get/set) plus maxConcurrent/
onComplete (queue.upsert), Start Now/Stop. Queue.schema.json already carries
the schedule so queue.list alone seeds the window.
- SpeedLimiterDialog: the live global limiter (limiter.get/set) — a different
thing from Options' downloads.speedLimit* default. buildParams() enforces
the schema's "0 with enabled true must not be offered".
- BatchDialog: clipboard-blob and {start..end}-wildcard tabs sharing one
category/queue/start-mode footer into download.addBatch.
- GrabberWizard: 4-step QWizard (project label -> start URL/depth/filters ->
file-type filter -> review), grabber.start feeding a poll+event.grabber.
progress-driven review page, Finish = grabber.harvest for the checked files.
- TrayIcon: active-count tooltip, Show/Add URL/Pause All/Resume All/Speed
Limiter submenu/Quit. Quit only closes the GUI — there is no RPC to stop
veloxd itself, filed as a new gap in daemon-requests-m1.md. MainWindow now
also hides to tray instead of closing when general.minimizeToTray is set.
Every dialog's non-widget logic (diffChanged, buildSchedule, buildParams,
parseUrlBlob/expandWildcard/buildAddBatchParams, buildFileTypes/
buildStartParams/buildHarvestParams) is a static pure function with its own
test, same shape as FileInfoDialog::buildSpec from the previous round.
Verified end-to-end against a running mockd under ASan+UBSan: all five
surfaces render real data (settings.get values, queue.list's two seeded
queues, limiter.get, a live grabber.start/status crawl returning 3 files) with
no sanitizer reports. gui-check (non-ASan) and dev (ASan+UBSan) presets both
build the whole repo clean; all gui-labeled ctest targets pass.
Co-Authored-By: Claude Sonnet 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01NSCdCWFXBTSBBK3MzWtJiC
67 lines
2.6 KiB
CMake
67 lines
2.6 KiB
CMake
# velox-gui — the Qt 6 Widgets client. Lane GUI.
|
|
#
|
|
# CLAUDE.md §3: zero download logic here. This target links libveloxproto (the wire
|
|
# types, ADR 0009) and NEVER libveloxcore — enforced by tests/ (see the
|
|
# gui_no_download_logic test).
|
|
#
|
|
# The root CMakeLists.txt add_subdirectory()s this unconditionally once the file exists,
|
|
# so it must stay configurable even if veloxproto is ever absent again. Until that target
|
|
# exists we announce and bail.
|
|
|
|
if(NOT TARGET veloxproto)
|
|
message(STATUS "velox-gui: libveloxproto target missing — GUI target skipped. "
|
|
"It builds automatically once core/ provides the veloxproto target (ADR 0009).")
|
|
return()
|
|
endif()
|
|
|
|
set(CMAKE_AUTOMOC ON)
|
|
|
|
# Everything except main() lives in a static lib so the tests can link the real widgets
|
|
# and models rather than a reimplementation.
|
|
add_library(velox-gui-lib STATIC
|
|
src/rpc/RpcConnection.cpp
|
|
src/rpc/RpcClient.cpp
|
|
src/models/DownloadTableModel.cpp
|
|
src/models/DownloadFilterProxy.cpp
|
|
src/widgets/ProgressDelegate.cpp
|
|
src/widgets/SegmentBarsWidget.cpp
|
|
src/widgets/SpeedGraphWidget.cpp
|
|
src/dialogs/AddUrlDialog.cpp
|
|
src/dialogs/FileInfoDialog.cpp
|
|
src/dialogs/ProgressDialog.cpp
|
|
src/dialogs/OptionsDialog.cpp
|
|
src/dialogs/SchedulerDialog.cpp
|
|
src/dialogs/SpeedLimiterDialog.cpp
|
|
src/dialogs/BatchDialog.cpp
|
|
src/dialogs/GrabberWizard.cpp
|
|
src/tray/TrayIcon.cpp
|
|
src/mainwindow/CategoryPanel.cpp
|
|
src/mainwindow/MainWindow.cpp
|
|
)
|
|
|
|
target_include_directories(velox-gui-lib PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/src)
|
|
target_compile_features(velox-gui-lib PUBLIC cxx_std_23)
|
|
target_compile_options(velox-gui-lib PRIVATE -Wall -Wextra -Wpedantic -Werror)
|
|
target_link_libraries(velox-gui-lib PUBLIC
|
|
velox::proto
|
|
Qt6::Widgets
|
|
Qt6::Svg
|
|
Qt6::Network
|
|
)
|
|
|
|
add_executable(velox-gui src/main.cpp)
|
|
target_compile_options(velox-gui PRIVATE -Wall -Wextra -Wpedantic -Werror)
|
|
target_link_libraries(velox-gui PRIVATE velox-gui-lib)
|
|
set_target_properties(velox-gui PROPERTIES WIN32_EXECUTABLE OFF MACOSX_BUNDLE OFF)
|
|
|
|
# --- i18n -------------------------------------------------------------------------------
|
|
# Every string in the GUI goes through tr(); the Arabic stub exists to prove the RTL
|
|
# layout survives (GUI DoD), exercised by tests/tst_rtl. lrelease also drops the .qm at
|
|
# ${CMAKE_CURRENT_BINARY_DIR}/velox_ar.qm, which the RTL test loads by path.
|
|
qt_add_translations(velox-gui TS_FILES i18n/velox_ar.ts)
|
|
|
|
# --- tests ---------------------------------------------------------------------------
|
|
if(VELOX_BUILD_TESTS)
|
|
add_subdirectory(tests)
|
|
endif()
|