samiandClaude Sonnet 5
de83ee3cce
Continues the build order past the Add-URL/File-Info/Progress dialog flow.
- OptionsDialog: General/Save To/Connection/Downloads/Proxy/Sounds tabs, every
control bound to a real settings.* key (contracts/schema/types/Settings.
schema.json). The spec's File Types and Site Logins tabs have no settings.*
backing (categories go through category.upsert, credentials through the
Secret Service) so they don't exist here — a tab either binds to a real key
or isn't shipped. diffChanged() sends only what actually changed, matching
settings.set's "changed[] names exactly what took effect" contract.
- SchedulerDialog: per-queue schedule (schedule.get/set) plus maxConcurrent/
onComplete (queue.upsert), Start Now/Stop. Queue.schema.json already carries
the schedule so queue.list alone seeds the window.
- SpeedLimiterDialog: the live global limiter (limiter.get/set) — a different
thing from Options' downloads.speedLimit* default. buildParams() enforces
the schema's "0 with enabled true must not be offered".
- BatchDialog: clipboard-blob and {start..end}-wildcard tabs sharing one
category/queue/start-mode footer into download.addBatch.
- GrabberWizard: 4-step QWizard (project label -> start URL/depth/filters ->
file-type filter -> review), grabber.start feeding a poll+event.grabber.
progress-driven review page, Finish = grabber.harvest for the checked files.
- TrayIcon: active-count tooltip, Show/Add URL/Pause All/Resume All/Speed
Limiter submenu/Quit. Quit only closes the GUI — there is no RPC to stop
veloxd itself, filed as a new gap in daemon-requests-m1.md. MainWindow now
also hides to tray instead of closing when general.minimizeToTray is set.
Every dialog's non-widget logic (diffChanged, buildSchedule, buildParams,
parseUrlBlob/expandWildcard/buildAddBatchParams, buildFileTypes/
buildStartParams/buildHarvestParams) is a static pure function with its own
test, same shape as FileInfoDialog::buildSpec from the previous round.
Verified end-to-end against a running mockd under ASan+UBSan: all five
surfaces render real data (settings.get values, queue.list's two seeded
queues, limiter.get, a live grabber.start/status crawl returning 3 files) with
no sanitizer reports. gui-check (non-ASan) and dev (ASan+UBSan) presets both
build the whole repo clean; all gui-labeled ctest targets pass.
Co-Authored-By: Claude Sonnet 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01NSCdCWFXBTSBBK3MzWtJiC
155 lines
8.5 KiB
CMake
155 lines
8.5 KiB
CMake
# GUI unit tests. Lane GUI.
|
|
#
|
|
# CLAUDE.md §5: a feature with no test does not exist. Each test below has a concrete
|
|
# failure it catches — that is the bar, not "it runs green".
|
|
|
|
set(CMAKE_AUTOMOC ON)
|
|
|
|
find_package(Qt6 REQUIRED COMPONENTS Test)
|
|
|
|
# tst_downloadtablemodel — the model's logic, headless.
|
|
# Red when: a progress patch widens past the value columns, a reset slips into
|
|
# applyProgress, applyProgress starts synthesizing rows for unknown ids, or add/remove
|
|
# stops emitting rowsInserted/rowsRemoved.
|
|
add_executable(tst_downloadtablemodel
|
|
tst_downloadtablemodel.cpp
|
|
${CMAKE_CURRENT_SOURCE_DIR}/../src/models/DownloadTableModel.cpp
|
|
)
|
|
target_include_directories(tst_downloadtablemodel PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/../src)
|
|
target_compile_features(tst_downloadtablemodel PRIVATE cxx_std_23)
|
|
target_compile_options(tst_downloadtablemodel PRIVATE -Wall -Wextra -Wpedantic -Werror)
|
|
target_link_libraries(tst_downloadtablemodel PRIVATE Qt6::Core Qt6::Test)
|
|
add_test(NAME gui_downloadtablemodel COMMAND tst_downloadtablemodel)
|
|
set_tests_properties(gui_downloadtablemodel PROPERTIES LABELS "gui")
|
|
|
|
# tst_downloadfilterproxy — the category-tree filter.
|
|
# Red when: a node stops filtering to its own rows, the Finished/Unfinished split
|
|
# misclassifies a state, or the filter stops being dynamic.
|
|
add_executable(tst_downloadfilterproxy tst_downloadfilterproxy.cpp)
|
|
target_compile_features(tst_downloadfilterproxy PRIVATE cxx_std_23)
|
|
target_compile_options(tst_downloadfilterproxy PRIVATE -Wall -Wextra -Wpedantic -Werror)
|
|
target_link_libraries(tst_downloadfilterproxy PRIVATE velox-gui-lib Qt6::Test)
|
|
add_test(NAME gui_downloadfilterproxy COMMAND tst_downloadfilterproxy)
|
|
set_tests_properties(gui_downloadfilterproxy PROPERTIES LABELS "gui")
|
|
|
|
# tst_rtl — the real RTL check the GUI DoD asks for (the .ts stub alone verifies nothing).
|
|
# Red when: the main window stops propagating Qt::RightToLeft to its children, or the
|
|
# offline-banner layout is pinned so it does not mirror under RTL.
|
|
add_executable(tst_rtl tst_rtl.cpp)
|
|
target_compile_features(tst_rtl PRIVATE cxx_std_23)
|
|
target_compile_options(tst_rtl PRIVATE -Wall -Wextra -Wpedantic -Werror)
|
|
target_link_libraries(tst_rtl PRIVATE velox-gui-lib Qt6::Widgets Qt6::Test)
|
|
add_test(NAME gui_rtl COMMAND tst_rtl)
|
|
set_tests_properties(gui_rtl PROPERTIES
|
|
LABELS "gui"
|
|
ENVIRONMENT "QT_QPA_PLATFORM=offscreen")
|
|
|
|
# tst_segmentbarswidget — the per-connection bar grid.
|
|
# Red when: a determinate segment stops rendering its percentage, an unknown-length
|
|
# segment stops falling back to the indeterminate range, a shrinking segment set
|
|
# destroys rows instead of hiding them, or rows start getting rebuilt per tick.
|
|
add_executable(tst_segmentbarswidget tst_segmentbarswidget.cpp)
|
|
target_compile_features(tst_segmentbarswidget PRIVATE cxx_std_23)
|
|
target_compile_options(tst_segmentbarswidget PRIVATE -Wall -Wextra -Wpedantic -Werror)
|
|
target_link_libraries(tst_segmentbarswidget PRIVATE velox-gui-lib Qt6::Widgets Qt6::Test)
|
|
add_test(NAME gui_segmentbarswidget COMMAND tst_segmentbarswidget)
|
|
set_tests_properties(gui_segmentbarswidget PROPERTIES
|
|
LABELS "gui"
|
|
ENVIRONMENT "QT_QPA_PLATFORM=offscreen")
|
|
|
|
# tst_speedgraphwidget — the 60 s rolling speed graph.
|
|
# Red when: addSample stops throttling bursts to 1 Hz, the bucket count stops
|
|
# incrementing on genuinely separated samples, clear() leaves stale state, or painting
|
|
# crashes before two samples exist.
|
|
add_executable(tst_speedgraphwidget tst_speedgraphwidget.cpp)
|
|
target_compile_features(tst_speedgraphwidget PRIVATE cxx_std_23)
|
|
target_compile_options(tst_speedgraphwidget PRIVATE -Wall -Wextra -Wpedantic -Werror)
|
|
target_link_libraries(tst_speedgraphwidget PRIVATE velox-gui-lib Qt6::Widgets Qt6::Test)
|
|
add_test(NAME gui_speedgraphwidget COMMAND tst_speedgraphwidget)
|
|
set_tests_properties(gui_speedgraphwidget PROPERTIES
|
|
LABELS "gui"
|
|
ENVIRONMENT "QT_QPA_PLATFORM=offscreen")
|
|
|
|
# tst_fileinfodialog — FileInfoDialog::buildSpec, the pure DownloadSpec builder.
|
|
# Red when: an empty optional field starts getting sent instead of omitted, or the
|
|
# queueId stops being dropped for a startMode other than "queue".
|
|
add_executable(tst_fileinfodialog tst_fileinfodialog.cpp)
|
|
target_compile_features(tst_fileinfodialog PRIVATE cxx_std_23)
|
|
target_compile_options(tst_fileinfodialog PRIVATE -Wall -Wextra -Wpedantic -Werror)
|
|
target_link_libraries(tst_fileinfodialog PRIVATE velox-gui-lib Qt6::Widgets Qt6::Test)
|
|
add_test(NAME gui_fileinfodialog COMMAND tst_fileinfodialog)
|
|
set_tests_properties(gui_fileinfodialog PROPERTIES
|
|
LABELS "gui"
|
|
ENVIRONMENT "QT_QPA_PLATFORM=offscreen")
|
|
|
|
# tst_optionsdialog — OptionsDialog::diffChanged, the "only send what changed" logic.
|
|
# Red when an unchanged key gets resent, or a key missing from `original` stops
|
|
# counting as changed.
|
|
add_executable(tst_optionsdialog tst_optionsdialog.cpp)
|
|
target_compile_features(tst_optionsdialog PRIVATE cxx_std_23)
|
|
target_compile_options(tst_optionsdialog PRIVATE -Wall -Wextra -Wpedantic -Werror)
|
|
target_link_libraries(tst_optionsdialog PRIVATE velox-gui-lib Qt6::Widgets Qt6::Test)
|
|
add_test(NAME gui_optionsdialog COMMAND tst_optionsdialog)
|
|
set_tests_properties(gui_optionsdialog PROPERTIES
|
|
LABELS "gui"
|
|
ENVIRONMENT "QT_QPA_PLATFORM=offscreen")
|
|
|
|
# tst_speedlimiterdialog — SpeedLimiterDialog::buildParams.
|
|
# Red when disabling stops zeroing globalBps, or enabling at 0 KiB/s stops being
|
|
# clamped to 1 (Limiter.schema.json: enabled+0 "must not be offered").
|
|
add_executable(tst_speedlimiterdialog tst_speedlimiterdialog.cpp)
|
|
target_compile_features(tst_speedlimiterdialog PRIVATE cxx_std_23)
|
|
target_compile_options(tst_speedlimiterdialog PRIVATE -Wall -Wextra -Wpedantic -Werror)
|
|
target_link_libraries(tst_speedlimiterdialog PRIVATE velox-gui-lib Qt6::Widgets Qt6::Test)
|
|
add_test(NAME gui_speedlimiterdialog COMMAND tst_speedlimiterdialog)
|
|
set_tests_properties(gui_speedlimiterdialog PROPERTIES
|
|
LABELS "gui"
|
|
ENVIRONMENT "QT_QPA_PLATFORM=offscreen")
|
|
|
|
# tst_schedulerdialog — SchedulerDialog::buildSchedule.
|
|
# Red when "use a schedule" unchecked stops sending JSON null, "run until it drains"
|
|
# stops nulling stopTime, or daysOfWeek/onceDate leak into the wrong mode.
|
|
add_executable(tst_schedulerdialog tst_schedulerdialog.cpp)
|
|
target_compile_features(tst_schedulerdialog PRIVATE cxx_std_23)
|
|
target_compile_options(tst_schedulerdialog PRIVATE -Wall -Wextra -Wpedantic -Werror)
|
|
target_link_libraries(tst_schedulerdialog PRIVATE velox-gui-lib Qt6::Widgets Qt6::Test)
|
|
add_test(NAME gui_schedulerdialog COMMAND tst_schedulerdialog)
|
|
set_tests_properties(gui_schedulerdialog PROPERTIES
|
|
LABELS "gui"
|
|
ENVIRONMENT "QT_QPA_PLATFORM=offscreen")
|
|
|
|
# tst_batchdialog — parseUrlBlob, expandWildcard, buildAddBatchParams.
|
|
# Red when the clipboard parser stops deduping or lets a non-URL line through, the
|
|
# wildcard expander mishandles zero-padding or an ambiguous/malformed range, or
|
|
# addBatch params include an empty optional field or a stray queueId.
|
|
add_executable(tst_batchdialog tst_batchdialog.cpp)
|
|
target_compile_features(tst_batchdialog PRIVATE cxx_std_23)
|
|
target_compile_options(tst_batchdialog PRIVATE -Wall -Wextra -Wpedantic -Werror)
|
|
target_link_libraries(tst_batchdialog PRIVATE velox-gui-lib Qt6::Widgets Qt6::Test)
|
|
add_test(NAME gui_batchdialog COMMAND tst_batchdialog)
|
|
set_tests_properties(gui_batchdialog PROPERTIES
|
|
LABELS "gui"
|
|
ENVIRONMENT "QT_QPA_PLATFORM=offscreen")
|
|
|
|
# tst_grabberwizard — buildFileTypes, buildStartParams, buildHarvestParams.
|
|
# Red when every file-type box unchecked stops meaning "every type" (null, not []),
|
|
# a blank filter stops becoming schema null, or a selected fileId goes missing from
|
|
# the harvest params.
|
|
add_executable(tst_grabberwizard tst_grabberwizard.cpp)
|
|
target_compile_features(tst_grabberwizard PRIVATE cxx_std_23)
|
|
target_compile_options(tst_grabberwizard PRIVATE -Wall -Wextra -Wpedantic -Werror)
|
|
target_link_libraries(tst_grabberwizard PRIVATE velox-gui-lib Qt6::Widgets Qt6::Test)
|
|
add_test(NAME gui_grabberwizard COMMAND tst_grabberwizard)
|
|
set_tests_properties(gui_grabberwizard PROPERTIES
|
|
LABELS "gui"
|
|
ENVIRONMENT "QT_QPA_PLATFORM=offscreen")
|
|
|
|
# gui_no_download_logic — CLAUDE.md §3 as an executable check, not a hope.
|
|
# Red when: a download-logic token (curl, raw pwrite, sqlite, QSqlDatabase) appears
|
|
# under gui/src. grep exits 0 only when it finds a match, so a hit fails the test.
|
|
add_test(NAME gui_no_download_logic
|
|
COMMAND ${CMAKE_COMMAND}
|
|
-DGUI_SRC=${CMAKE_CURRENT_SOURCE_DIR}/../src
|
|
-P ${CMAKE_CURRENT_SOURCE_DIR}/no_download_logic.cmake)
|
|
set_tests_properties(gui_no_download_logic PROPERTIES LABELS "gui")
|