samiandClaude Sonnet 5
c89158ea09
Closes a bounded, high-value slice of the remaining D3 stubs. settings.*/rules.*/ limiter.*/schedule.*/grabber.*/media.*/capture.*/queue.reorder/download.refreshUrl/ download.update stay deferred — reasons noted individually in deferrals.md (settings.* specifically: a real, large field<->key<->JSON-type mapping table across ~43 fields / ~50 SettingKeys, not started rather than rushed). category.upsert/remove: store/categories.hpp gains get/upsert/remove. upsert generates an id when absent and always ignores the payload's `builtin` (preserved from the existing row on replace, false on create); saveDir goes through the same fs::resolve_target canonicalize-and-root-check as download.add. remove refuses a builtin at both layers (dispatcher's -32602 pre-check; the store's own "DELETE ... AND builtin = 0" as defense in depth) and reassigns member tasks to reassignTo (default "general") inside one transaction before deleting the row. queue.upsert: store/queues.hpp gains get/upsert (set_state already existed from D4b). Same create-generates-id pattern; a create always starts 'stopped', a replace keeps the queue's current run state (upsert edits config, not run state — that's queue.start/stop). Also fixed in passing: on_complete has been a real column since migration 0001 but Queues::list/get never projected it onto Queue.onComplete. download.remove: cancels with discard_partial=true (always drops the .veloxpart pair — unlike download.cancel, which keeps them, the row is gone either way), deletes the finished file only when deleteFile is true and the task was complete (best-effort), deletes the row (segments cascade via the FK), and publishes event.task.removed (closing the last open note under D5). download.addBatch: on_download_add's body is now a shared add_one(), called once per item after merging each item's unset fields against params.defaults. download.provideAuth: forwards to EnginePort::provide_auth via a new TaskActionPort::provide_auth. `remember`/persisting to the Secret Service is accepted but not acted on — nothing in this build talks to libsecret yet. Verified against real veloxd + tools/testserver: category create/replace/ remove-with-reassignment, queue create/replace-keeps-run-state, a batch add sharing defaults.saveDir, and download.remove with deleteFile actually deleting the file and the task then 404ing download.get with -32010. Full ctest: 39/39. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01GRDjHGgpYmMoPE2UFbe7pP
41 lines
1.4 KiB
C++
41 lines
1.4 KiB
C++
#pragma once
|
|
|
|
// Read access to the `queues` table, projected onto proto::Queue. taskIds is derived from
|
|
// `tasks` (queue_id = this queue, ordered by queue_position), not stored on the queue row
|
|
// — membership changes through download.update / queue.reorder, per Queue's own schema
|
|
// note that a queue.upsert payload's taskIds is ignored.
|
|
|
|
#include <optional>
|
|
#include <string_view>
|
|
#include <vector>
|
|
|
|
#include "store/sqlite.hpp"
|
|
#include "velox_proto.hpp"
|
|
|
|
namespace velox::daemon::store {
|
|
|
|
class Queues {
|
|
public:
|
|
explicit Queues(Db& db) : db_(db) {}
|
|
|
|
DbResult<std::vector<velox::proto::Queue>> list();
|
|
|
|
// nullopt (not an error) if no queue has this id.
|
|
DbResult<std::optional<velox::proto::Queue>> get(std::string_view queue_id);
|
|
|
|
// 'running' or 'stopped' (Queue.schema.json / the state column's CHECK). false if the
|
|
// id doesn't exist.
|
|
DbResult<bool> set_state(std::string_view queue_id, std::string_view state);
|
|
|
|
// "Omit queueId to create" (queue.upsert's own words) — an empty id generates one.
|
|
// taskIds is ignored (membership changes only through download.update / queue.reorder,
|
|
// per the schema's own note); a create defaults to 'stopped', a replace keeps the
|
|
// queue's current run state (queue.upsert edits config, not run state).
|
|
DbResult<velox::proto::Queue> upsert(velox::proto::Queue queue);
|
|
|
|
private:
|
|
Db& db_;
|
|
};
|
|
|
|
} // namespace velox::daemon::store
|