sami/vdm

Files

T

samiandClaude Sonnet 5 3db0d01f9d daemon: download.add / download.list / download.get behind the store

VeloxDispatcher now takes a store::Db& and three handlers are real:

- download.list -> store::Tasks::list (filter / sort / paging in SQL) ->
  to_summary per row. No more empty-table stub.
- download.add -> resolve saveDir (spec, else saveTo.defaultDir; ~ expanded)
  and the leaf (spec.filename, else the URL's last segment percent-decoded,
  else download.bin) -> fs::resolve_target against canonicalize_root'd
  saveTo.allowedRoots. Any path-destination failure is -32011 with the
  *original* saveDir in data.path. On success a TaskRow is inserted in
  state `queued` (or `new` for startMode "manual") and {taskId, state}
  returned. The scheduler that would then admit it is D4.
- download.get -> store::Tasks::get; a real -32010 + data.taskId for an
  unknown id, else a TaskDetail (segmentDetail empty until the engine
  segments the task, which the schema permits).

util/time.hpp: now_iso() factored out of ws_server.cpp.

main.cpp constructs the dispatcher with the opened db. The three
integration tests build an in-memory migrated db for it; velox.client
now drives the full slice through the CLI — add outside roots -> -32011
with data.path, add into an allowed root -> a task that download.list
shows and download.get details, unknown id -> -32010. Verified with the
real binaries: velox add persists, velox ls shows it, it survives a
daemon restart, /etc is refused.

ASan+UBSan and TSan clean; 34 daemon/cli tests green. deferrals.md:
D2 down to just download.probe; D3 down to categories/queues/rules/
settings/limiter/schedule.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01Upd9WhG9oppieig5nRDLig

2026-09-10 19:58:45 +04:00

1.5 KiB

Raw Blame History

DAEMON — deferred work, tracked

Things that are deliberately incomplete in daemon/ right now, with why and when they close. Kept here (not buried in commit messages) so the next pass can see them at a glance.

#	What	Where	Why deferred	Closes when
D1	Pairing prompt is `EnvAutoApprover` (needs `VELOX_PAIR_AUTO=1`)	`rpc/pairing.hpp`, `main.cpp`	A GUI dialog / `org.freedesktop.Notifications` approver is integration work	Build step 7 (systemd + notifications)
D2	`download.probe` → `-32603`	`rpc/dispatcher.cpp`	`download.add` is wired (`fs/safepath` + store, real `-32011`); `download.probe` needs the engine's probe path for `-32013`	probe with the engine link (CORE stage 3 is landed; wire `Engine::probe`)
D3	Stub handlers for everything except `session.*`, `download.add/list/get`	`rpc/dispatcher.cpp`	No store behind them yet (categories/queues/rules/settings/limiter/schedule)	Per method, as the store query modules land behind them
D4	`sched/` is the pure `Governor` + schedule window only; no `Scheduler` wiring to store/engine/timer	`sched/`	`Engine` bodies land in CORE stage 8; `Scheduler` needs the UUID↔`vdm::TaskId` map, a store query layer, and a timer	After CORE stage 8 lands `Engine::start()`
D5	`event.*` fan-out not implemented; `session.subscribe` accepts and echoes but nothing is emitted	`rpc/uds_server.cpp`, `rpc/ws_server.cpp`	No task state to broadcast until the engine is wired	With the callback → `event.*` projection

1.5 KiB Raw Blame History

DAEMON — deferred work, tracked

1.5 KiB

Raw Blame History