Was 7/16 of tools/testserver/README.md's mode table covered by
engine_test.cpp. Adds the rest:
- engine_expiring_signed_url_recovers_via_refresh_url: an expired signed
URL 403s, the engine asks (paused, decision_calls >= 1) rather than
failing terminally, and DownloadHandle::refresh_url() with a freshly
signed URL completes it -- exercises both do_refresh_url() fixes and
the probe-level referrer retry's second-403 path from the previous
commit.
- engine_403_without_referer_retries_with_origin: no spec.referrer set,
the automatic single retry (previous commit) recovers with zero
decisions asked.
- engine_redirect_chain_follows_to_completion: 5 hops of a plain 302.
No core-side change needed -- documents that CURLOPT_FOLLOWLOCATION/
MAXREDIRS (already on, RequestOptions::follow_redirects) cover both
the probe's and every worker's own request, not just one of the two.
- engine_slow_loris_stall_timeout_fires: proves curl's stall detector
(CURLOPT_LOW_SPEED_LIMIT/_TIME, download_task.cpp's hardcoded 1024 B/s
for 30s) actually fires rather than hanging. Needed a real fix, not
just a test: every other test in this file relies on TestServer's
short 1s loris dribble to keep runtime down, but 1s of trickle
followed by full-speed streaming never accumulates curl's required 30
CONSECUTIVE seconds under the floor, so it would never actually abort
-- a test built on the default dribble would pass by the download
merely finishing a bit late, not by observing the stall timeout fire.
testserver_fixture.hpp's TestServer gained an explicit-loris-seconds
constructor (default ctor unchanged, still 1s) so this one test can
ask for a dribble (40s) that genuinely outlasts the threshold.
- engine_401_digest_then_provide_auth_completes: same shape as the
existing 401-basic test: http_client.cpp already asks libcurl for
CURLAUTH_ANY regardless of net::AuthScheme, so this needed no core
change -- it passed on the first run and is here to prove that's true
end-to-end, not just at the http_client unit level.
- engine_chunked_no_length_completes_single_segment: Transfer-Encoding:
chunked, no Content-Length anywhere (including HEAD). No core change
needed -- takes the same size-agnostic "unknown size, one plain-GET
segment" path as the existing no-range test.
- utf8/legacy-content-disposition: already covered end-to-end by
probe_reads_utf8_content_disposition and
probe_reads_legacy_content_disposition in probe_test.cpp (probe-level,
as these modes only affect the initial request) -- verified passing,
no new test needed.
All 20 engine_test.cpp cases and all 10 probe_test.cpp cases pass. Every
testserver.py spawned while writing and running this was reaped by
TestServer's destructor; verified no stragglers with `ps aux` after each
run.
Co-Authored-By: Claude Sonnet 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01Q3QrF7rCt21bkAjt9BCDFQ
samiandClaude Sonnet 5
79c29b47e8