samiandClaude Sonnet 5
6163898c14
HttpClient::Impl::drain_commands() default-constructed a std::deque<Command> every call, on every iteration of the worker thread's event loop (once per curl_multi_poll wake -- i.e. once per socket-readiness event on the transfer hot path), then swapped the (usually empty) command queue into it. In libstdc++, an empty std::deque still allocates its map array on construction, so this was a real allocation on the hot path regardless of whether any command (add/pause/resume/cancel) was actually pending -- which is the common case, since those are rare next to data arriving. Found via tools/bench's alloc-check, which is built in this change and exists specifically to catch this class of bug (AGENT-CORE.md: "no allocation in the curl write callback... checked in review and by a bench assertion"): before this fix it reported thousands of allocations/sec under a sustained transfer; after, single digits. Fixed by checking `w.queue.empty()` under the lock before touching `local` at all, so the deque is only constructed when there's actually something to swap into it. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Q3QrF7rCt21bkAjt9BCDFQ
Owner: lane CORE. See ../docs/agents/AGENT-CORE.md and ../docs/04-engine-design.md. No JSON, no SQL, no Qt, no RPC in this tree.