samiandClaude Opus 5
53421d6cb8
Schemas for the whole v1 surface: 38 methods, 9 events, 25 named types and the
JSON-RPC envelope, with x-privileged / x-transports / x-deadlineMs / x-errors
annotations that both generators emit as data rather than prose.
Four generators over one IR (contracts/codegen/schema_ir.py), so the C++ structs,
the TypeScript types and the OpenRPC document cannot disagree about what the
contract says:
gen_cpp.py -> core/generated/velox_proto.{hpp,cpp}
gen_ts.py -> extension/src/shared/protocol/
gen_openrpc.py -> contracts/openrpc.json
gen_cpp_conformance.py -> tests/conformance/cpp/fixture_dispatcher.hpp
Inbound parsing never throws: parse<T>() returns std::expected<T, ParseError> and
nlohmann's throwing ADL from_json is deliberately not emitted. Schema constraints
(minimum, maxLength, pattern, ...) become real runtime checks in both languages —
the daemon does not trust the extension and the extension does not trust the
daemon.
59 golden fixtures: a success case per method, 12 error cases, 9 events. Replayed
by tests/conformance/ against both the generated C++ and a live server over both
transports. tools/mockd serves the same fixtures with unhappy-path flags so the
GUI and EXT lanes never wait for veloxd.
run.sh also proves capture.offer fails open: with a daemon answering slower than
750 ms the client gives up and lets Firefox take the download.
core/generated/ is libveloxproto, a separate target from libveloxcore, which
still never sees JSON — see docs/adr/0009.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_012fgjnqFCS5h5L7gZTZo3rV
40 lines
1.0 KiB
JSON
40 lines
1.0 KiB
JSON
{
|
|
"name": "download.start \u2014 applied to a two-task selection",
|
|
"description": "A queued task jumps its queue; one already downloading is a no-op reported as changed false.",
|
|
"request": {
|
|
"jsonrpc": "2.0",
|
|
"id": 20,
|
|
"method": "download.start",
|
|
"params": {
|
|
"taskIds": [
|
|
"$taskId",
|
|
"$taskId2"
|
|
]
|
|
}
|
|
},
|
|
"response": {
|
|
"jsonrpc": "2.0",
|
|
"id": 20,
|
|
"result": {
|
|
"updated": [
|
|
{
|
|
"taskId": "3f7a2b1c-5d6e-4f80-9a1b-2c3d4e5f6071",
|
|
"state": "connecting",
|
|
"changed": true
|
|
},
|
|
{
|
|
"taskId": "8c1d4e5f-6a7b-4c8d-9e0f-1a2b3c4d5e6f",
|
|
"state": "connecting",
|
|
"changed": false
|
|
}
|
|
],
|
|
"failed": []
|
|
}
|
|
},
|
|
"assertions": [
|
|
"a task already in the target state is reported with changed false, not as a failure",
|
|
"an unknown id lands in failed[] with -32010 and never fails the whole call",
|
|
"event.task.state is emitted for every entry whose changed is true"
|
|
]
|
|
}
|