samiandClaude Sonnet 5
203d4a662f
Verified PKG's landed CI (.github/workflows/ci.yml, db7650b/8f45815) against this lane's actual tree, per the standing instruction that conformance as a required check is this lane's DoD to verify, not PKG's. It wasn't running: the `conformance` job's presence-check looks for tests/conformance/CMakeLists.txt or tests/conformance/package.json, and neither existed -- the job was silently short-circuiting to a green "skipped" on every PR, forever. The M0 exit gate was not gating anything. tests/conformance/CMakeLists.txt registers one ctest entry, labeled "conformance", that shells out to run.sh -- the exact command tests/conformance/README.md tells a human to run locally, so there is one definition of "the suite passed", not a CMake-flavoured near-duplicate of it. cpp/CMakeLists.txt's existing conformance_cpp test gets the same label, for a lane iterating on core/generated/ who wants the fast native-only path. Fixed a second landmine found while wiring this: the root CMakeLists.txt only find_package(nlohmann_json)'s when daemon/CMakeLists.txt exists, since daemon is its real consumer -- but daemon hasn't landed yet, so add_subdirectory(tests/conformance) would have failed to configure the moment this file existed, on every machine, until daemon merges. Fixed inside tests/conformance/cpp/CMakeLists.txt with an if(NOT TARGET) guard rather than widening the root file's condition, which is PKG's to change. run.sh now installs its own Python deps (jsonschema, referencing) on demand: they aren't in tools/bootstrap.sh's apt list -- that's PKG's script, these are this suite's own dependency -- so a bare CI image would otherwise fail check_contract.py with an ImportError before this suite even started. Verified end to end: `cmake --preset dev && ctest --test-dir build/dev -R '^conformance$'` passes in 23.8s, exercising the exact command and label the CI job uses. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_012fgjnqFCS5h5L7gZTZo3rV
27 lines
1.3 KiB
CMake
27 lines
1.3 KiB
CMake
# Wires the conformance suite into ctest, so `ctest -L conformance` — the check
|
|
# .github/workflows/ci.yml's `conformance` job runs, and the one BRANCH_PROTECTION.md
|
|
# names as required "when tests/conformance/ lands" — actually runs it. Without this file
|
|
# that job's presence-check finds neither a CMakeLists.txt nor a package.json here and
|
|
# silently no-ops to a green "skipped", forever: the M0 exit gate would never actually
|
|
# gate anything. Owned by lane PROTO.
|
|
#
|
|
# One ctest entry shells out to run.sh — the exact command tests/conformance/README.md
|
|
# tells a human to run locally. That is deliberate: there is exactly one definition of
|
|
# "the suite passed", not a CMake-flavoured near-duplicate of it that can drift from the
|
|
# real one. The native (C++) half also gets its own finer-grained test via add_subdirectory
|
|
# below, for a lane iterating on core/generated/ who doesn't want npm's cost every run.
|
|
|
|
add_subdirectory(cpp)
|
|
|
|
add_test(
|
|
NAME conformance
|
|
COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/run.sh
|
|
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
|
|
)
|
|
set_tests_properties(conformance PROPERTIES
|
|
LABELS "conformance"
|
|
# Installs two npm trees and runs a ten-minute-capable suite end to end; generous but
|
|
# not unbounded, so a genuinely hung mockd fails the job instead of the runner.
|
|
TIMEOUT 600
|
|
)
|