samiandClaude Sonnet 5
de83ee3cce
Continues the build order past the Add-URL/File-Info/Progress dialog flow.
- OptionsDialog: General/Save To/Connection/Downloads/Proxy/Sounds tabs, every
control bound to a real settings.* key (contracts/schema/types/Settings.
schema.json). The spec's File Types and Site Logins tabs have no settings.*
backing (categories go through category.upsert, credentials through the
Secret Service) so they don't exist here — a tab either binds to a real key
or isn't shipped. diffChanged() sends only what actually changed, matching
settings.set's "changed[] names exactly what took effect" contract.
- SchedulerDialog: per-queue schedule (schedule.get/set) plus maxConcurrent/
onComplete (queue.upsert), Start Now/Stop. Queue.schema.json already carries
the schedule so queue.list alone seeds the window.
- SpeedLimiterDialog: the live global limiter (limiter.get/set) — a different
thing from Options' downloads.speedLimit* default. buildParams() enforces
the schema's "0 with enabled true must not be offered".
- BatchDialog: clipboard-blob and {start..end}-wildcard tabs sharing one
category/queue/start-mode footer into download.addBatch.
- GrabberWizard: 4-step QWizard (project label -> start URL/depth/filters ->
file-type filter -> review), grabber.start feeding a poll+event.grabber.
progress-driven review page, Finish = grabber.harvest for the checked files.
- TrayIcon: active-count tooltip, Show/Add URL/Pause All/Resume All/Speed
Limiter submenu/Quit. Quit only closes the GUI — there is no RPC to stop
veloxd itself, filed as a new gap in daemon-requests-m1.md. MainWindow now
also hides to tray instead of closing when general.minimizeToTray is set.
Every dialog's non-widget logic (diffChanged, buildSchedule, buildParams,
parseUrlBlob/expandWildcard/buildAddBatchParams, buildFileTypes/
buildStartParams/buildHarvestParams) is a static pure function with its own
test, same shape as FileInfoDialog::buildSpec from the previous round.
Verified end-to-end against a running mockd under ASan+UBSan: all five
surfaces render real data (settings.get values, queue.list's two seeded
queues, limiter.get, a live grabber.start/status crawl returning 3 files) with
no sanitizer reports. gui-check (non-ASan) and dev (ASan+UBSan) presets both
build the whole repo clean; all gui-labeled ctest targets pass.
Co-Authored-By: Claude Sonnet 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01NSCdCWFXBTSBBK3MzWtJiC
47 lines
1.6 KiB
C++
47 lines
1.6 KiB
C++
// SpeedLimiterDialog::buildParams unit tests. Lane GUI.
|
|
//
|
|
// Red when disabling the limiter stops zeroing globalBps, enabling it with 0 KiB/s stops
|
|
// being clamped to 1 (Limiter.schema.json: "0 with enabled true means stop everything,
|
|
// which the GUI must not offer"), or the KiB/s -> bytes/s conversion drifts.
|
|
|
|
#include <QtTest>
|
|
|
|
#include "dialogs/SpeedLimiterDialog.hpp"
|
|
|
|
using velox::gui::SpeedLimiterDialog;
|
|
|
|
class TstSpeedLimiterDialog : public QObject {
|
|
Q_OBJECT
|
|
|
|
private slots:
|
|
void disabledSendsZero();
|
|
void enabledConvertsKibpsToBytesPerSec();
|
|
void enabledClampsZeroToOne();
|
|
void applyToRunningPassesThrough();
|
|
};
|
|
|
|
void TstSpeedLimiterDialog::disabledSendsZero() {
|
|
const QJsonObject p = SpeedLimiterDialog::buildParams(false, 512, false);
|
|
QCOMPARE(p.value("enabled").toBool(), false);
|
|
QCOMPARE(p.value("globalBps").toDouble(), 0.0);
|
|
}
|
|
|
|
void TstSpeedLimiterDialog::enabledConvertsKibpsToBytesPerSec() {
|
|
const QJsonObject p = SpeedLimiterDialog::buildParams(true, 512, false);
|
|
QCOMPARE(p.value("enabled").toBool(), true);
|
|
QCOMPARE(p.value("globalBps").toDouble(), 512.0 * 1024);
|
|
}
|
|
|
|
void TstSpeedLimiterDialog::enabledClampsZeroToOne() {
|
|
const QJsonObject p = SpeedLimiterDialog::buildParams(true, 0, false);
|
|
QCOMPARE(p.value("globalBps").toDouble(), 1024.0);
|
|
}
|
|
|
|
void TstSpeedLimiterDialog::applyToRunningPassesThrough() {
|
|
QVERIFY(SpeedLimiterDialog::buildParams(true, 1, true).value("applyToRunning").toBool());
|
|
QVERIFY(!SpeedLimiterDialog::buildParams(true, 1, false).value("applyToRunning").toBool());
|
|
}
|
|
|
|
QTEST_MAIN(TstSpeedLimiterDialog)
|
|
#include "tst_speedlimiterdialog.moc"
|