Files
vdm/contracts/fixtures/rules.upsert.json
samiandClaude Opus 5 53421d6cb8 proto: freeze the wire contract at 1.0.0
Schemas for the whole v1 surface: 38 methods, 9 events, 25 named types and the
JSON-RPC envelope, with x-privileged / x-transports / x-deadlineMs / x-errors
annotations that both generators emit as data rather than prose.

Four generators over one IR (contracts/codegen/schema_ir.py), so the C++ structs,
the TypeScript types and the OpenRPC document cannot disagree about what the
contract says:

  gen_cpp.py             -> core/generated/velox_proto.{hpp,cpp}
  gen_ts.py              -> extension/src/shared/protocol/
  gen_openrpc.py         -> contracts/openrpc.json
  gen_cpp_conformance.py -> tests/conformance/cpp/fixture_dispatcher.hpp

Inbound parsing never throws: parse<T>() returns std::expected<T, ParseError> and
nlohmann's throwing ADL from_json is deliberately not emitted. Schema constraints
(minimum, maxLength, pattern, ...) become real runtime checks in both languages —
the daemon does not trust the extension and the extension does not trust the
daemon.

59 golden fixtures: a success case per method, 12 error cases, 9 events. Replayed
by tests/conformance/ against both the generated C++ and a live server over both
transports. tools/mockd serves the same fixtures with unhappy-path flags so the
GUI and EXT lanes never wait for veloxd.

run.sh also proves capture.offer fails open: with a daemon answering slower than
750 ms the client gives up and lets Firefox take the download.

core/generated/ is libveloxproto, a separate target from libveloxcore, which
still never sees JSON — see docs/adr/0009.

Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_012fgjnqFCS5h5L7gZTZo3rV
2026-09-09 19:55:54 +04:00

98 lines
2.4 KiB
JSON

{
"name": "rules.upsert \u2014 add one rule and drop another atomically",
"description": "Applying adds and removes in one write means a reprioritisation never leaves the table half-valid.",
"request": {
"jsonrpc": "2.0",
"id": 39,
"method": "rules.upsert",
"params": {
"upsert": [
{
"ruleId": "big-to-queue",
"name": "Queue anything over 1 GiB",
"enabled": true,
"priority": 5,
"match": {
"extensions": null,
"mimeTypes": null,
"hostPattern": null,
"urlPattern": null,
"minSizeBytes": 1073741824,
"maxSizeBytes": null
},
"action": {
"categoryId": null,
"saveDir": null,
"queueId": "main",
"segments": null,
"startMode": "queue",
"capture": null
}
}
],
"remove": [
"never-intranet"
]
}
},
"response": {
"jsonrpc": "2.0",
"id": 39,
"result": {
"items": [
{
"ruleId": "big-to-queue",
"name": "Queue anything over 1 GiB",
"enabled": true,
"priority": 5,
"match": {
"extensions": null,
"mimeTypes": null,
"hostPattern": null,
"urlPattern": null,
"minSizeBytes": 1073741824,
"maxSizeBytes": null
},
"action": {
"categoryId": null,
"saveDir": null,
"queueId": "main",
"segments": null,
"startMode": "queue",
"capture": null
}
},
{
"ruleId": "iso-to-programs",
"name": "Disk images",
"enabled": true,
"priority": 10,
"match": {
"extensions": [
"iso",
"img"
],
"mimeTypes": null,
"hostPattern": null,
"urlPattern": null,
"minSizeBytes": null,
"maxSizeBytes": null
},
"action": {
"categoryId": "programs",
"saveDir": null,
"queueId": null,
"segments": 8,
"startMode": null,
"capture": null
}
}
]
}
},
"assertions": [
"the whole table comes back in priority order so the caller need not re-list",
"adds and removes commit together or not at all"
]
}