gui: floating drop target, clipboard global shortcut, theming, UI watchdog

Continues the build order past Options/Scheduler/Speed Limiter/Batch/ Grabber/tray. - DropTargetWidget: frameless always-on-top drop target (docs/03-gui-spec.md §5), position persisted, accepts a dropped http(s) URL or link text and opens FileInfoDialog directly (skipping Add URL, since the URL is already known). Shown/hidden from general.showDropTarget, live via event.settings.changed, same pattern MainWindow already used for general.minimizeToTray. - Clipboard, explicit path #2 (docs/06-risks-and-spikes.md R2): GlobalShortcut wraps org.freedesktop.portal.GlobalShortcuts (CreateSession -> BindShortcuts -> Activated), triggering the same Add URL flow. Guarded end-to-end on `if(TARGET Qt6::DBus)` / VELOX_GUI_HAVE_DBUS so a build without the component degrades to "feature skipped," not broken (gui/docs/pkg-qa-requests-m1.md R4). Best-effort by design per the risk doc: fails silent, never advertised. Verified live against the real portal (a real Wayland session, not just offscreen): `CreateSession` refuses every caller with "An app id is required" — reproduced identically via a bare `busctl` call with no Qt involved at all, so this is the portal requiring a sandboxed caller identity, not something fixable from an unconfined process. Recorded as a partial Spike S2 answer in docs/06-risks-and-spikes.md: this explicit path likely doesn't work for Velox as a traditionally-packaged app on stock GNOME, only if/when it ships confined. Also fixed a real leak this verification caught: QDBusInterface's introspection cache reads as a LeakSanitizer leak the first time anything touches D-Bus (tst_rtl went red under ASan) — switched to QDBusMessage::createMethodCall, which needs no introspection. - Theming (docs/03-gui-spec.md §7): gui/resources/qss/{idm-like,dark}.qss, each with a documented palette block up top (QSS itself has no variable syntax), applied by ThemeManager and kept live via QStyleHints::colorSchemeChanged. util/Theme.hpp gives the handful of inline C++ styles (status dot, offline banner, the eleven identical error-label styles across dialogs) named constants instead of a twelfth copy of the same hex. - UiThreadWatchdog: the M1 DoD's 200 ms debug-build watchdog. A background std::thread pings the UI thread every 50 ms via a queued invokeMethod and warns once (not per-poll) if a ping goes unanswered past 200 ms; no QThread, no Qt event loop of its own, so the watchdog itself can never be what blocks the thread it watches. No-op in a release build. Proven both ways in tst_uithreadwatchdog: fires on a genuinely blocked UI thread (synchronous sleep, no processEvents) and stays silent on a responsive one. Full non-conformance suite (55 tests across every lane, `ctest -LE conformance`) passes clean at this point, including the whole gui label under ASan+UBSan. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NSCdCWFXBTSBBK3MzWtJiC
gui: Options — Capture tab, saveTo.allowedRoots, lock coverage to the schema
2026-09-12 21:30:13 +04:00 · 2026-09-12 21:29:19 +04:00 · 2026-09-12 21:28:36 +04:00 · 2026-09-12 21:27:28 +04:00 · 2026-09-12 16:27:29 +04:00 · 2026-09-12 16:27:29 +04:00
60 changed files with 2213 additions and 1046 deletions
@@ -1,129 +0,0 @@
 .TH VELOX 1 "2026-09-12" "Velox" "User Commands"
 .SH NAME
 velox \- command-line client for veloxd, the Velox download manager daemon
 .SH SYNOPSIS
 .B velox
 .I command
 .RI [ options ]
 .SH DESCRIPTION
 .B velox
 talks to
 \fBveloxd\fR
 over its Unix-domain socket and gives a scriptable, terminal-first view of the same
 downloads the GUI and the Firefox extension see. It does no downloading itself \(em every
 command is a thin JSON-RPC call; the daemon owns all state.
 .PP
 .B veloxd
 must already be running (see
 .B ENVIRONMENT
 below for how
 .B velox
 finds it, and
 .BR systemctl (1)
 .RI ( "systemctl --user status velox" )
 for whether it's up). If nothing is listening on the socket,
 .B velox
 exits with status 3 rather than hanging.
 .SH COMMANDS
 .TP
 .BI "add " url " [\-\-dir " dir "] [\-\-out " name "] [\-\-segments " n ]
 Add a new download. Prints the new task's id and initial state.
 .RS
 .TP
 .BI "\-\-dir " dir
 Destination directory. Must resolve inside one of the daemon's configured
 .B saveTo.allowedRoots
 or the call fails; omit to use the configured default download directory.
 .TP
 .BI "\-\-out " name
 Filename to save as. Omit to derive one from the URL (or, once the daemon has probed it,
 from the server's own
 .BR Content-Disposition ).
 .TP
 .BI "\-\-segments " n
 Requested connection count for this download, 1\(en32. The daemon may use fewer \(em a
 per-host cap or a source that turns out not to support resuming both lower it. The
 .B ls
 table (and
 .RI "\-\-json's " segments
 field) show what was actually granted, not what was asked for.
 .RE
 .TP
 .B ls
 List every download the daemon knows about: id, state, progress, and filename. With
 .BR \-\-json ", the raw " download.list " result instead of the table."
 .TP
 .BI "pause " id " [" id " ...]"
 Pause one or more downloads by id. A download already paused, or already finished, is
 left alone \(em not an error.
 .TP
 .BI "resume " id " [" id " ...]"
 Resume one or more paused downloads.
 .TP
 .BI "rm " id " [" id " ...] " "[\-\-delete\-file]"
 Remove one or more downloads from the list. Without
 .BR \-\-delete\-file ,
 any partial data on disk
 .RI ( .veloxpart / .veloxpart.meta )
 is discarded but a
 .B completed
 file is left in place. With
 .BR \-\-delete\-file ,
 the finished file is deleted too \(em there is deliberately no default for this flag; you
 must say which you mean every time.
 .SH OPTIONS
 .TP
 .B \-\-json
 Print the raw JSON-RPC result instead of a formatted table. Works with every command;
 combine with
 .BR jq (1)
 for scripting. On error, the JSON form is an
 .B {"error": {...}}
 object on stdout rather than a message on stderr.
 .TP
 .B \-h ", " \-\-help
 Print usage and exit 0.
 .SH EXIT STATUS
 .TP
 .B 0
 Success.
 .TP
 .B 1
 The daemon reached the call but returned a JSON-RPC error (bad task id, path outside the
 allowed roots, and so on). The message is on stderr, or in the JSON error object with
 .BR \-\-json .
 .TP
 .B 2
 Usage error \(em missing argument, unknown option, or unknown command.
 .TP
 .B 3
 Could not reach
 .B veloxd
 at all: not running, or its socket is missing or unreachable.
 .SH ENVIRONMENT
 .TP
 .B XDG_RUNTIME_DIR
 .B velox
 connects to
 .IR "$XDG_RUNTIME_DIR/velox/velox.sock" .
 If unset, it falls back to
 .IR /run/user/ <uid> ,
 matching
 \fBveloxd\fR's
 own resolution \(em the two must agree for the client to find the daemon, so this is
 normally left to the desktop session's default rather than set by hand.
 .SH FILES
 .TP
 .I $XDG_RUNTIME_DIR/velox/velox.sock
 The daemon's Unix-domain socket, mode 0600, same-UID only (\fBSO_PEERCRED\fR checked on
 every connection \(em this is the transport's authorization, not an extra login).
 .SH SEE ALSO
 .BR systemctl (1),
 .BR jq (1)
 .PP
 .I docs/01-architecture.md
 and
 .I docs/agents/AGENT-DAEMON.md
 in the Velox source tree for the daemon's own build order and the wire protocol
 .B velox
 speaks.
@@ -20,7 +20,7 @@
      ],
      "defaults": {
        "url": "https://example.org/",
-        "categoryId": "compressed",
+        "categoryId": "programs",
        "startMode": "queue",
        "queueId": "main"
      }
@@ -30,5 +30,6 @@
    "the version check is transport-independent; this is replayed on the Unix socket so it is not masked by -32002",
    "data.expected is the daemon's own current protocol version string (kProtocolVersion), not a bare major and not pinnable in a golden file -- the conformance compare on error payloads is on `code` only, structural elsewhere, so echoing the live version is fine"
  ],
-  "transport": "uds"
+  "transport": "uds",
  "closesConnection": true
 }
@@ -75,7 +75,6 @@ target_link_libraries(veloxd_sched PUBLIC velox::proto velox::core veloxd_store
 add_library(veloxd_rpc STATIC
    src/rpc/runtime_dir.cpp
    src/rpc/single_instance.cpp
    src/rpc/systemd_activation.cpp
    src/rpc/event_loop.cpp
    src/rpc/event_hub.cpp
    src/rpc/uds_server.cpp
@@ -7,7 +7,7 @@ close. Kept here (not buried in commit messages) so the next pass can see them a
 |---|---|---|---|---|
 | ~~D7~~ | **Closed — `capture.offer` is real.** Applies `capture.enabled`/`excludedHosts`/`monitoredExtensions`/`monitoredMimeTypes`/`minSizeBytes` from settings, then the rules table (`store::Rules` + CORE's `vdm::rules::match_rules`/`glob_match` — DAEMON only converts its own stored `proto::Rule` JSON into CORE's plain `vdm::rules::Rule` vocabulary, per that header's own layering note), resolves the category folder (a rule's explicit `categoryId`/`saveDir`, else `store::Categories::guess_by_extension` — the same extension-guess `download.probe`'s `suggestedCategoryId` already used, now shared instead of duplicated), dedupes against active (non-terminal) tasks by exact URL, and on `take` calls `add_one()` — the same path `download.add` itself uses — so a captured download is a real, admitted, persisted task, not a special case. The 750 ms deadline (CLAUDE.md §4 / AGENT-DAEMON.md build step 6) is checked cooperatively between every step via a new `rpc::CaptureDataSource` seam (real impl wraps `store::*`; a test fake can jump its own clock forward to simulate "the store was slow just now" with zero real sleep) — catches the realistic failure mode (several slow steps adding up) though it can't preempt one pathologically stuck single call. Verified against real `veloxd` + `tools/testserver`: a monitored-type offer answers in ~5ms and actually creates + downloads the task; an unmonitored type, an excluded host, a rule-vetoed host, and a second offer for a still-active URL all answer `ignore` with the right `reason`; a bad category save dir surfaces its real `-32011` rather than being swallowed. New `capture_offer_test` covers all of the above plus the deadline itself (two cases, one per "slow" checkpoint), asserting real wall-clock time barely moves even though the fake clock jumped 2 simulated seconds — proof the check reads the injected clock, not a disguised sleep. | `rpc/capture_data_source.hpp`, `rpc/dispatcher.{hpp,cpp}`, `store/rules.{hpp,cpp}`, `store/categories.{hpp,cpp}`, `store/tasks.{hpp,cpp}` | — | done |
 | ~~D8~~ | **Closed alongside D7** — `capture.getRules` returns the same settings-backed `enabled`/`monitoredExtensions`/`monitoredMimeTypes`/`minSizeBytes`/`excludedHosts`/`bypassModifier` capture.offer itself reads, so the two can never drift. `rulesVersion` is a constant `1` — there is no persisted revision counter yet (nothing writes `rules.*` outside this process's own lifetime to need one across a restart), and the extension already re-fetches on `event.settings.changed` regardless of what this number does; noted in case a real counter becomes worth adding later. | `rpc/dispatcher.cpp` | `rulesVersion` is a placeholder constant | — |
-| D1 | Pairing prompt is `EnvAutoApprover` (needs `VELOX_PAIR_AUTO=1`) | `rpc/pairing.hpp`, `main.cpp` | A GUI dialog / `org.freedesktop.Notifications` approver is integration work | the `org.freedesktop.Notifications` half of build step 7 — the systemd half closed as D11 below |
+| D1 | Pairing prompt is `EnvAutoApprover` (needs `VELOX_PAIR_AUTO=1`) | `rpc/pairing.hpp`, `main.cpp` | A GUI dialog / `org.freedesktop.Notifications` approver is integration work | Build step 7 (systemd + notifications) |
 | — | **D1, checked this pass, not attempted:** `libdbus-1-dev` (or `libsystemd-dev` for `sd-bus`) has no headers installed in this build environment — only the runtime `.so`s (`dpkg -l`/`apt-cache policy` confirm `libdbus-1-3` present, `libdbus-1-dev` not, "Candidate" available but not installed). A real notification-backed approver needs one of those linked into `veloxd`, which is a new build dependency for `daemon/CMakeLists.txt` (`find_package`/`pkg_check_modules`) and — since packaging manifests need to know about it too — arguably a decision to surface rather than something to reach for silently mid-session. `PairingApprover::approve()` is also still synchronous by shape (its own doc comment already says so: "the real notification-backed approver will run async and is not this shape") — swapping it for the async pattern this session built for `download.probe` (`rpc::TaskActionPort` + the server-layer deferred-reply special-case) is the right shape once there's a real implementation to justify the churn; reshaping the interface with nothing behind it yet would just be churn. Left `EnvAutoApprover` in place rather than build a fragile hand-rolled D-Bus wire client to avoid the missing headers — a broken pairing approver is worse than an honest stub. | `rpc/pairing.hpp` | missing dev headers + an undiscussed new dependency | once `libdbus-1-dev`/`libsystemd-dev` is available and the dependency is approved |
 | ~~D2~~ | **Closed** — `download.probe` is real on both transports. It's genuinely async (the engine's probe pool, up to the schema's 30s `x-deadlineMs`) and so cannot fit `VeloxDispatcher::on_download_probe`'s synchronous `HandlerResult<T>` return — `uds_server.cpp`/`ws_server.cpp` special-case `"download.probe"` before the generic `dispatch()`, exactly the way they already special-case `session.hello`/`session.subscribe`, and queue the reply whenever the callback fires. `rpc::TaskActionPort::probe_now` (kept in proto/std terms, no `vdm::net::*`, so `veloxd_rpc` never needs `core/include`'s vdm headers) is what both transports call; `sched::Scheduler::probe_now` is the implementation — builds a `vdm::net::ProbeRequest`, runs it on the engine's probe pool, maps a failure to `-32013 ProbeFailed` (with `data.httpStatus` when there was one), and fills `suggestedCategoryId`/`suggestedSaveDir` with a plain extension match against the categories table (not the real rules engine — that's still D3). Verified live: a real probe answers in ~5ms; a bad host maps to `-32013`; a connection issuing a 10s `slow-loris` probe does not block a second connection's `download.list` (answered in ~1ms) — confirms the async design actually keeps the loop free, not just compiles. | `rpc/task_action_port.hpp`, `rpc/{uds_server,ws_server}.{hpp,cpp}`, `sched/scheduler.{cpp,hpp}` | — | done |
 | D3 | Stub handlers for the rest: `grabber.*`, `media.*` | `rpc/dispatcher.cpp` | HLS/DASH grabber and media-variant support don't exist anywhere in this build yet — a bigger feature than a store-wiring pass | M4 territory, per AGENT-DAEMON.md |
@@ -26,5 +26,4 @@ close. Kept here (not buried in commit messages) so the next pass can see them a
 | ~~D4b~~ | **Closed** — `download.pause`/`resume`/`start`/`cancel` and `queue.start`/`stop` all drive the scheduler now, and apply *immediately* (not deferred to the next tick — pausing/resuming/cancelling a live transfer can't wait up to 1s, and per ADR 0013 §3 the governor never touches a user-owned pause on its own). New `rpc::TaskActionPort` interface (owned by `rpc/`, implemented by `sched::Scheduler`) is the seam dispatcher.hpp depends on instead of `sched/scheduler.hpp` directly — avoids a real `veloxd_rpc` <-> `veloxd_sched` circular library dependency (`veloxd_sched` already links `veloxd_rpc` for `EventHub`). `Scheduler::user_pause/resume/start/cancel` + `pause_queue` engine-call-then-eager-transition, matching `tick()`'s existing `to_pause` pattern. Fixed a real bug hit while building this: `transition()` always overwrote `pause_reason` to NULL when the engine's own delayed pause-ack callback arrived with no explicit reason, clobbering whatever the actual initiator (user or governor) had just written — now it preserves the stored reason when none is supplied. Verified against real `veloxd` + `tools/testserver`: pausing a live single-segment throttled transfer freezes `downloadedBytes`, resume continues it from that point, cancel stops it; `queue.stop(pauseRunning:true)` pauses the queue's running task immediately. NOTE: `download.start`'s contract "a task in 'queued' jumps its queue" (priority bump) is not implemented — admission is still plain FIFO by `created_at`. | `sched/scheduler.{cpp,hpp}`, `rpc/task_action_port.hpp`, `rpc/dispatcher.{hpp,cpp}`, `store/queues.{cpp,hpp}` | — | done, except the queue-jump priority bump noted above |
 | ~~D5~~ | **Mostly closed** — `rpc/event_hub` fans out per-subscription; `session.subscribe` on both transports registers/updates/tears down a real subscription; `Scheduler::transition()` publishes `event.task.state` (with `previousState`) on every state change, scheduler-driven or engine-reported; `dispatcher::on_download_add` publishes `event.task.added`; a 250 ms timer batches `Scheduler::progress_snapshot()` into one `event.task.progress` array per AGENT-DAEMON.md item 5 / the schema's `x-maxRateHz: 4`. Verified live end to end. | — | `event.task.removed` has no source yet (`download.remove` is D3); `event.speed.global`, `event.notify`, `event.auth.required`, `event.settings.changed`, `event.grabber.progress` are unpublished — each lands with its owning handler | as each owning D3 handler lands |
 | ~~D6~~ | **Closed** — engine numbers now reach the store: `Scheduler::tick()` probes (`EnginePort::probe`) before every `start()`, persisting `sizeBytes`/`resumable`/validators via `Tasks::set_probe_result` before a byte moves; `Scheduler::persist_progress()` (called from `progress_snapshot()` *and* once more from `on_engine_state` right before `release()`/unmap on every terminal transition) writes `downloadedBytes`/`speedBps`/`segments`/`segmentDetail` from the engine's `Progress`, so a task that finishes between two 250 ms ticks (the common case for anything small or fast) still leaves real numbers instead of the pre-persistence defaults. `TaskSummary.segments` is sourced from `segments.size()` when the task has any (matching what actually lands in `segmentDetail`, per the schema's "exactly `segments` entries"), falling back to the engine's `effective_segments` (budget slots *held*, not necessarily physical range count — see `core/include/vdm/task/download.hpp`'s `Progress` comment) only pre-segmentation. `Tasks::set_final_bytes` tops up `on_finished`'s byte count as a last-resort backstop. Migration `0002` adds `speed_bps` to both `tasks` and `segments`, and fixes `segments.state`'s CHECK to include `'pending'` (0001 omitted it, so a pre-connect snapshot could never be written). Verified against real `veloxd` + `tools/testserver` (not just unit tests): `download.list`/`download.get` correct immediately after completion and after a daemon restart. | `sched/scheduler.{cpp,hpp}`, `store/{tasks,segments}.{cpp,hpp}`, `store/migrations/0002_*.sql` | — | done |
 | ~~D11~~ | **Closed — build order items 7 (the systemd half) and 9: `velox-nmhost`, socket activation, the systemd user units, and `velox(1)`.** `nmhost/src/main.cpp` (185 lines): a `poll()`-driven byte pump between Firefox's native-messaging framing on stdio (4-byte native-byte-order length prefix) and `veloxd`'s own NDJSON framing on the Unix socket — reframes each direction, no JSON parsing, no retry/backoff, exits the moment either side closes. Deliberately dependency-free (no `veloxd_*` library, no `nlohmann_json`) since it runs unconfined outside Firefox's sandbox whatever the packaging format. Two real bugs found and fixed while getting the integration test to actually pass rather than hang: (1) never set the pumped fds non-blocking, so the "drain what's available" read loop blocked on its own second `read()` instead of returning to `poll()`; (2) stdin and stdout are two different descriptors (0 and 1), not one — an early draft polled `POLLOUT` on fd 0, which is opened read-only, so EOF/writability were never both observable through the same `pollfd` entry. Both are exactly the class of bug a "trivial pump" invites and unit tests over the real binary (not just its helper functions) exist specifically to catch. `packaging/nativehost/com.velox.host.json` + its own `README.md` supersede `AGENT-DAEMON.md`'s stale "four locations" (spike S1 / ADR 0003 found only three are real — the fourth, `~/snap/firefox/common/.mozilla/...`, is not read by snap Firefox at all) and spell out the per-user-manifest / postinst implication for PKG/QA. `EnginePort`-style: `rpc/systemd_activation.cpp` is a from-scratch `sd_listen_fds()` (env vars only, no `libsystemd` link — `LISTEN_PID`/`LISTEN_FDS`, fd 3) that `UdsServer::start()` checks first, skipping its own create/bind/chmod/listen when systemd already bound the socket; `packaging/systemd/velox.socket` + `velox.service` are the unit pair, verified both by `systemd-analyze verify` and by an actual fork/dup2/execve simulation of the activation handshake (a real `session.hello` round-tripped over the handed-off fd with no `bind()` ever called inside the daemon for that run). `velox.service` deliberately skips `ProtectSystem=`/`ProtectHome=`/`ReadWritePaths=` — `saveTo.allowedRoots` is user-configurable to anywhere on the filesystem, and a sandbox here would turn a legitimately-configured save location into an opaque `EROFS`/`EACCES` instead of the daemon's own clear `-32011`. `cli/man/velox.1` documents the CLI as it actually exists today (`add`/`ls`/`pause`/`resume`/`rm`, `--json`, the three-tier `queue`/`settings` subcommands `AGENT-DAEMON.md` build step 8 originally sketched are not implemented in `cli/src/main.cpp` yet, so the page doesn't claim they are) — checked warning-free with `groff -mandoc -ww -z`. | `nmhost/{CMakeLists.txt,src/main.cpp,tests/}`, `daemon/src/rpc/{systemd_activation.{hpp,cpp},uds_server.cpp}`, `packaging/{nativehost,systemd}/`, `cli/man/velox.1` | — | done |
 | — | ~~Observed, not fixed (CORE, not this lane)~~ — **routed to CORE by the user.** `vdm::task::Progress.speed_bps` reads back as `0` for the whole lifetime of a live, real (non-fake) throttled download, despite `downloadedBytes` visibly advancing between polls — `core/src/task/download_task.cpp`'s per-worker EWMA never seems to produce a nonzero aggregate in this build. DAEMON passes `EnginePort::progress()`'s `speed_bps` straight through (`Scheduler::persist_progress`); nothing in this lane drops it. Still reproduces in the D4b live checks above (0 throughout a paused/resumed/cancelled transfer whose `downloadedBytes` visibly moved) — not re-filed, since it's already CORE's. |
@@ -1,37 +0,0 @@
 #include "rpc/systemd_activation.hpp"
 #include <unistd.h>
 #include <cstdlib>
 #include <string>
 namespace velox::daemon::rpc {
 namespace {
 constexpr int kListenFdsStart = 3;  // SD_LISTEN_FDS_START
 }  // namespace
 int systemd_activated_fd() {
    const char* pid_env = std::getenv("LISTEN_PID");
    const char* fds_env = std::getenv("LISTEN_FDS");
    int fd = -1;
    if (pid_env != nullptr && fds_env != nullptr) {
        try {
            if (std::stol(pid_env) == static_cast<long>(::getpid()) && std::stol(fds_env) == 1) {
                fd = kListenFdsStart;
            }
        } catch (...) {
            // Malformed env from something other than systemd; treat as not activated.
        }
    }
    // Contract: consumed once, then cleared, so a value meant for veloxd is never
    // mistaken for one meant for a process it might itself exec later.
    ::unsetenv("LISTEN_PID");
    ::unsetenv("LISTEN_FDS");
    ::unsetenv("LISTEN_FDNAMES");
    return fd;
 }
 }  // namespace velox::daemon::rpc
@@ -1,20 +0,0 @@
 #pragma once
 // Minimal sd_listen_fds(3) reimplementation — one function, no libsystemd dependency, for
 // the one fd velox.socket ever hands us. See velox.socket / velox.service in
 // packaging/nativehost's systemd unit pair: the socket unit binds
 // $XDG_RUNTIME_DIR/velox/velox.sock itself (before veloxd ever runs, so the very first
 // connection attempt after boot is queued by the kernel rather than refused) and execs
 // veloxd with that listening fd already open at fd 3, LISTEN_FDS=1, LISTEN_PID=<our pid>.
 namespace velox::daemon::rpc {
 // The systemd-activated listening socket fd, or -1 if this process was not socket-
 // activated (LISTEN_PID doesn't match our pid, or LISTEN_FDS is unset/not exactly 1 — more
 // than one would mean a unit file mismatch, since veloxd only ever asks for one socket).
 // Clears LISTEN_PID/LISTEN_FDS from the environment on the way out either way, per
 // sd_listen_fds's own contract, so a value meant for us is never mistaken for one meant for
 // a process veloxd might itself exec later.
 int systemd_activated_fd();
 }  // namespace velox::daemon::rpc
@@ -12,10 +12,7 @@
 #include <nlohmann/json.hpp>
 #include <fcntl.h>
 #include "rpc/event_loop.hpp"
 #include "rpc/systemd_activation.hpp"
 #include "version.hpp"
 namespace velox::daemon::rpc {
@@ -77,20 +74,6 @@ UdsServer::~UdsServer() {
 }
 std::error_code UdsServer::start() {
    // velox.socket (systemd user unit, socket activation): the unit binds this path itself
    // before veloxd ever runs and hands the already-listening fd over at fd 3 — the first
    // connection after boot is queued by the kernel rather than refused, and there is no
    // window where a client sees ECONNREFUSED while the daemon is still starting. Skips
    // create/bind/chmod/listen entirely; the socket file's lifecycle (including removal on
    // stop) belongs to the unit, not to us, so bound_ stays false.
    if (const int activated = systemd_activated_fd(); activated >= 0) {
        ::fcntl(activated, F_SETFL, O_NONBLOCK);
        ::fcntl(activated, F_SETFD, FD_CLOEXEC);
        listen_fd_ = activated;
        loop_.add_fd(listen_fd_, kRead, [this](int, unsigned) { on_listener_readable(); });
        return {};
    }
    if (path_.size() + 1 > sizeof(sockaddr_un::sun_path)) return errc(ENAMETOOLONG);
    const int fd = ::socket(AF_UNIX, SOCK_STREAM | SOCK_NONBLOCK | SOCK_CLOEXEC, 0);
@@ -24,7 +24,6 @@ veloxd_test(sched_scheduler  LIBS veloxd_sched veloxd_rpc)
 veloxd_test(event_hub               LIBS veloxd_rpc)
 veloxd_test(store_categories_queues LIBS veloxd_store)
 veloxd_test(single_instance          LIBS veloxd_rpc)
 veloxd_test(systemd_activation        LIBS veloxd_rpc)
 veloxd_test(dispatcher_settings      LIBS veloxd_rpc veloxd_store)
 veloxd_test(capture_offer            LIBS veloxd_rpc veloxd_store)
 veloxd_test(dispatcher_misc          LIBS veloxd_rpc veloxd_store)
@@ -1,53 +0,0 @@
 // systemd_activated_fd(): the LISTEN_PID/LISTEN_FDS contract, without a real systemd.
 #include <unistd.h>
 #include <cstdlib>
 #include <string>
 #include "check.hpp"
 #include "rpc/systemd_activation.hpp"
 using namespace velox::daemon::rpc;
 namespace {
 void set_env(const char* k, const std::string& v) { ::setenv(k, v.c_str(), 1); }
 }  // namespace
 void run() {
    // Not activated: neither var set.
    ::unsetenv("LISTEN_PID");
    ::unsetenv("LISTEN_FDS");
    CHECK_EQ(systemd_activated_fd(), -1);
    // LISTEN_PID for a different process: not us, so not activated.
    set_env("LISTEN_PID", std::to_string(::getpid() + 1));
    set_env("LISTEN_FDS", "1");
    CHECK_EQ(systemd_activated_fd(), -1);
    // Consumed regardless of the outcome — a stale value from some other process's
    // exec chain must not leak into what veloxd checks next time.
    CHECK(::getenv("LISTEN_PID") == nullptr);
    CHECK(::getenv("LISTEN_FDS") == nullptr);
    // Our own pid, LISTEN_FDS=1: activated, fd 3 (SD_LISTEN_FDS_START).
    set_env("LISTEN_PID", std::to_string(::getpid()));
    set_env("LISTEN_FDS", "1");
    CHECK_EQ(systemd_activated_fd(), 3);
    CHECK(::getenv("LISTEN_PID") == nullptr);
    // Our own pid but LISTEN_FDS=2: a unit file mismatch (veloxd only ever asks for one
    // socket) — refuse rather than guess which of two fds is the right one.
    set_env("LISTEN_PID", std::to_string(::getpid()));
    set_env("LISTEN_FDS", "2");
    CHECK_EQ(systemd_activated_fd(), -1);
    // Garbage LISTEN_FDS: not activated, not a crash.
    set_env("LISTEN_PID", std::to_string(::getpid()));
    set_env("LISTEN_FDS", "not-a-number");
    CHECK_EQ(systemd_activated_fd(), -1);
    ::unsetenv("LISTEN_PID");
    ::unsetenv("LISTEN_FDS");
 }
 TEST_MAIN()
@@ -53,6 +53,24 @@ capture, and the Add-URL dialog pre-fills from the clipboard when opened. Backgr
 monitoring is a bonus if the spike says yes. **Do not let this block the release, and do
 not promise it in the UI before S2 answers.**
 **Spike S2, item (c) answered — verified live, not the full spike:** on this desktop
 (GNOME/Mutter, Ubuntu 26.04, plain non-Flatpak/non-snap process), `CreateSession` on
 `org.freedesktop.portal.GlobalShortcuts` refuses every caller with `"An app id is
 required"` — reproduced two ways: `gui/src/clipboard/GlobalShortcut.cpp`'s real async
 D-Bus call, and a bare `busctl --user call … CreateSession` from an interactive shell
 (no Qt involved at all), both under a real Wayland session (`WAYLAND_DISPLAY` set), not
 just offscreen. Because the second reproduction has no Qt/app-level identity to configure
 at all and still fails identically, this looks like the portal requiring the caller's
 *bus connection* to already carry a sandboxed app id (Flatpak/snap portal-confined) —
 something no amount of `QGuiApplication::setDesktopFileName()` or similar can supply from
 an unconfined process. **Practical read:** the global-shortcut explicit path likely does
 not work at all for Velox as a traditionally-packaged (.deb/AppImage) app on stock
 GNOME — only if/when it ships confined. The code is still in (best-effort, fails silent
 exactly like this, never advertised — see the file's own header), since it costs nothing
 and activates automatically the day that changes. Items (a) `QClipboard::dataChanged`
 cross-app, (b) `wlr-data-control`, and (d) XWayland fallback are **still unanswered** —
 this was one item of S2's four, not the full spike.
 ---
 ## R3 — AMO review friction 🟠 MEDIUM
@@ -43,11 +43,7 @@ Read `contracts/`, `core/include/`, `docs/`. Never write in `core/`, `gui/`, or
   output. Build this early: it is how you test the daemon before the GUI exists.
 9. **`velox-nmhost`** — 4-byte-length-prefixed stdio ⇄ Unix socket pump. **Under 300 lines,
   zero business logic**, and it must exit cleanly when Firefox closes the pipe. Install
-   manifests to the three real locations in `docs/05` §4 / `docs/adr/0003` — not four:
+   manifests to all four locations listed in `docs/05` §4.
   spike S1 found `~/snap/firefox/common/.mozilla/native-messaging-hosts/` (the intuitive
   "inside the snap" path) is not actually read by snap Firefox, and corrected `docs/05` §4
   down from its original four-location list. `packaging/nativehost/README.md` has the
   current table.
 ## Definition of done (M1)
 - Passes the full conformance suite as a server, over **both** transports.
@@ -35,10 +35,21 @@ add_library(velox-gui-lib STATIC
    src/dialogs/BatchDialog.cpp
    src/dialogs/GrabberWizard.cpp
    src/tray/TrayIcon.cpp
    src/widgets/DropTargetWidget.cpp
    src/util/ThemeManager.cpp
    src/util/UiThreadWatchdog.cpp
    src/mainwindow/CategoryPanel.cpp
    src/mainwindow/MainWindow.cpp
 )
 # docs/03-gui-spec.md §7: the two QSS skins ThemeManager picks between, embedded so the
 # app needs no external file at runtime.
 qt_add_resources(velox-gui-lib "theme"
    PREFIX "/qss"
    BASE "resources/qss"
    FILES resources/qss/idm-like.qss resources/qss/dark.qss
 )
 target_include_directories(velox-gui-lib PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/src)
 target_compile_features(velox-gui-lib PUBLIC cxx_std_23)
 target_compile_options(velox-gui-lib PRIVATE -Wall -Wextra -Wpedantic -Werror)
@@ -47,8 +58,23 @@ target_link_libraries(velox-gui-lib PUBLIC
    Qt6::Widgets
    Qt6::Svg
    Qt6::Network
    Threads::Threads
 )
 # docs/06-risks-and-spikes.md R2's explicit path #2 (a global shortcut via
 # org.freedesktop.portal.GlobalShortcuts) needs Qt6::DBus, which the root CMakeLists.txt
 # does not request yet (gui/docs/pkg-qa-requests-m1.md R4 — PKG/QA's file, not ours).
 # Guarded exactly like the veloxproto check above: compiles in automatically the moment
 # that lands, and MainWindow only wires it up when VELOX_GUI_HAVE_DBUS is defined.
 if(TARGET Qt6::DBus)
    target_sources(velox-gui-lib PRIVATE src/clipboard/GlobalShortcut.cpp)
    target_link_libraries(velox-gui-lib PUBLIC Qt6::DBus)
    target_compile_definitions(velox-gui-lib PUBLIC VELOX_GUI_HAVE_DBUS)
 else()
    message(STATUS "velox-gui: Qt6::DBus not available — the clipboard global-shortcut "
                   "path (gui/docs/pkg-qa-requests-m1.md R4) is skipped, not broken.")
 endif()
 add_executable(velox-gui src/main.cpp)
 target_compile_options(velox-gui PRIVATE -Wall -Wextra -Wpedantic -Werror)
 target_link_libraries(velox-gui PRIVATE velox-gui-lib)
@@ -121,26 +121,101 @@ Notes for whoever applies it:
 ---
-## R3 — the GUI DoD gates have nowhere to run in CI
+## R3 — the GUI DoD gates have nowhere to run in CI — RESOLVED, ready to wire in
-To be precise about what already works: `VELOX_BUILD_GUI` defaults `ON`, the `ci` preset
+**Status: done on GUI's side.** The harness `tests/integration/README.md` was waiting on
-inherits `dev`, and once `gui/` is on `main` the `build` and `sanitizers` jobs configure
+now exists, builds, and has been run end-to-end (all three gates, all three unhappy-path
-and build `velox-gui` and run `ctest --preset ci`, which picks up all three GUI checks
+sub-phases) against a real `mockd` with no changes needed to the pre-drafted job below.
 (`gui_downloadtablemodel`, `gui_rtl`, `gui_no_download_logic`). That part is covered.
-What has no home is the part of the GUI M1 definition of done that isn't a unit test:
+**Path:** `gui/tests/dod/run.sh <gate> [--json <path>]`, exactly the contract
 `tests/integration/README.md` specifies. `<gate>` is `scroll-60fps` | `rss-flat` |
 `unhappy-path`. It builds and tears down its own `mockd` (isolated `XDG_RUNTIME_DIR` via
 `mktemp -d`), needs no network, and leaves nothing running on any exit path (`trap
 cleanup EXIT INT TERM`) — verified live by checking for orphaned `tsx`/`mockd` processes
 after both a passing and a forced-failing run of each gate.
-1. **10 000 rows scroll at 60 fps** (`mockd --tasks 10000`) — needs a frame-timing probe
+**One change from the pre-drafted job:** the "Configure + build" step needs to also build
-   against the offscreen (or Xvfb) view; red when a scroll frame exceeds ~16 ms at the
+the harness binary, not just `velox-gui`:
-   99th percentile.
+```diff
-2. **Flat memory over 10 minutes of progress events** — needs RSS sampled across a
+- cmake --build --preset dev --target velox-gui
-   10-minute `mockd --tasks 10000` run; red when RSS grows more than a small fixed slack
+ cmake --build --preset dev --target velox-gui gui-dod-harness
-   (a leak in the progress-patch path is the thing this catches).
+```
-3. **Unhappy-path recovery** — `mockd --slow`, `--flaky <f>`, `--drop-connection <s>`:
+Nothing else in the pre-drafted YAML needs to change — the `# TODO(GUI): path` comment on
-   the client must show the banner and recover without a freeze or crash; red on a crash,
+the `scroll-60fps` line can just come off along with the marker on the line below it.
   a hang (watchdog), or the connection state never returning to `Connected`.
-GUI owns writing that harness (`gui/tests/` + a driver script, headless against `mockd`).
+**`rss-flat`'s slack: 20 MiB (`VELOX_DOD_RSS_SLACK_KIB`, default `20480`).** Chosen by
-Wiring it into `.github/workflows/ci.yml` as its own job — with the 10-minute one likely
+running the gate locally (`VELOX_DOD_RSS_DURATION_SEC=8` override, i.e. not the real
-`nightly` rather than per-PR — is PKG/QA. Say the word and it comes over as a follow-up
+10-minute number) a handful of times against `mockd --tasks 10000 --seed 1` and looking at
-request with the job stanza pre-written.
+actual post-warm-up growth (single-digit MiB per run here) — 20 MiB gives real headroom
 above that noise floor without being so loose a genuine per-tick leak in the progress-patch
 path could hide under it. This has **not** been proven against a full real 10-minute
 sanitized run (that's the nightly job's own first execution) or tuned against
 production-length data yet; treat it as GUI's stated starting number, not a
 load-tested constant, and expect it may need retuning after the first few real
 `gui-dod-nightly` runs land actual series data.
 **One caveat worth deciding on explicitly: the pre-drafted job builds with `cmake --preset
 dev`, i.e. ASan+UBSan (CLAUDE.md: "default for all lanes").** `scroll-60fps`'s frame
 budget already compensates (`gui/tests/dod/dod_harness.cpp` multiplies 16.6 ms by 4× when
 it detects a sanitized build — measured p99 here was ~50 ms against ASan overhead, well
 under the scaled 66.4 ms budget, so the multiplier is doing real work, not padding for no
 reason). `rss-flat`'s slack does **not** get a similar adjustment — ASan's allocator
 (redzones, quarantine) can look like real growth over a long run in a way this hasn't been
 validated against yet. Two honest options: run `gui-dod-nightly` against a `release`-preset
 build instead of `dev` (loses the sanitizers' own bug-catching value for this one job), or
 accept `VELOX_DOD_RSS_SLACK_KIB` may need a second, larger number for the ASan build once
 real 10-minute data exists. GUI's preference is the second (keep sanitizers on
 everywhere), but this is genuinely PKG/QA's call since it's their job definition.
 **Verified live**, under the exact `ASAN_OPTIONS=detect_leaks=1:halt_on_error=1` the
 `sanitizers` job already sets (checked against `.github/workflows/ci.yml` rather than
 assumed) — no leak-suppression flag needed, on any of the three gates:
 * `scroll-60fps` against `mockd --tasks 10000 --seed 1`: PASS at p99 ≈ 50 ms (budget
  66.4 ms sanitized). Forced red once via `VELOX_DOD_FRAME_BUDGET_MS=1` to confirm the
  fail path and exit code actually work, not just the pass path.
 * `rss-flat` at `VELOX_DOD_RSS_DURATION_SEC=6/8`: PASS, ~4-6 MiB growth against the
  20 MiB slack.
 * `unhappy-path`, all three phases (`--slow 900`, `--flaky 0.3`, `--drop-connection 5`):
  PASS. One real finding from building this: `--drop-connection` is currently a no-op
  over the Unix socket transport in `mockd` itself (only wired for WebSocket) — filed as
  `gui/docs/proto-requests-m1.md` since that's PROTO's file to fix, not GUI's. The gate
  still passes today on the weaker (but real, and the actually-documented) condition that
  the client reaches and holds `Connected`; it just isn't proving a real mid-session drop
  yet for that one phase.
 Two bugs surfaced and fixed *by* building this harness, both in `gui/`'s own RPC client
 (caught by ASan, not assumed): `RpcClient::stop()` left `conn_` dangling after joining its
 worker thread, so any caller that called `stop()` and then let the client destruct hit a
 double-free — the harness's own `client.stop()` at shutdown found it on the first run.
 Separately, `RpcClient`'s initial `download.list` call had a hardcoded `limit: 1000` with
 no paging, silently capping the table at 1000 rows regardless of how many the daemon
 actually has — `scroll-60fps` against `--tasks 10000` refused to run rather than
 "passing" against a 1000-row table, which is what caught it. Both fixed on `lane/gui`
 before this request was filed.
 ---
 ## R4 — root `CMakeLists.txt`'s `find_package(Qt6 ...)` should list `DBus` explicitly
 Not currently broken — flagging a "works, but by accident" for the record. `gui/src/
 clipboard/GlobalShortcut.cpp` (docs/06-risks-and-spikes.md R2's explicit path #2:
 `org.freedesktop.portal.GlobalShortcuts`) needs `Qt6::DBus`. **Verified live: the target
 already exists and links today**, even though the root `find_package` doesn't list `DBus`
 in `COMPONENTS` — this Qt 6 packaging apparently exports every module's CMake target once
 any component pulls in the shared prefix, `DBus` included. `gui/CMakeLists.txt` still
 guards the clipboard sources on `if(TARGET Qt6::DBus)` (same pattern the file already uses
 for `veloxproto`), so if that turns out to be environment-specific rather than a general
 Qt 6 CMake guarantee, the build degrades to "feature skipped," not "build broken," on
 whatever machine finds out otherwise.
 Worth making explicit anyway, since relying on undocumented target leakage is fragile:
 ```diff
 - find_package(Qt6 6.6 REQUIRED COMPONENTS Widgets Svg Network LinguistTools)
 + find_package(Qt6 6.6 REQUIRED COMPONENTS Widgets Svg Network DBus LinguistTools)
 ```
 No apt change needed either way — `qt6-base-dev` (already in `APT_GUI`) ships `QtDBus`'s
 headers directly (verified live: `dpkg -L qt6-base-dev | grep -i dbus` lists the whole
 `QtDBus/` include tree).
@@ -0,0 +1,105 @@
 # GUI → PROTO requests (M1)
 Filed by lane GUI while building `gui/tests/dod/` (gui/docs/pkg-qa-requests-m1.md R3's
 harness). Touches `tools/mockd/` — PROTO-owned (CLAUDE.md §1) — so GUI is not making the
 edit. Apply-ready below.
 ---
 ## `mockd --drop-connection` is a no-op over the Unix socket transport
 `--drop-connection <s>` is documented as "terminate every connection every N seconds, to
 exercise reconnect logic" and is exactly what `gui/tests/dod/run.sh unhappy-path` needs
 for its drop-connection phase. It works — but only over WebSocket.
 **Repro:** `tools/mockd/src/index.ts`'s `startUds()` call passes `args.slow` and stops
 there:
 ```ts
 startUds(args.uds, dispatcher, connections, log, args.slow);
 ```
 `startWs()`, two lines below, gets the full options object including `dropEverySec`.
 `startUds()`'s own signature (`tools/mockd/src/transport/uds.ts`) has no
 `dropEverySec` parameter at all, and nothing in it ever calls `socket.destroy()` — the
 periodic-drop `setInterval` that `startWs` has (its last ~6 lines) simply does not exist
 on the UDS side.
 **Verified live**, not inferred from reading: ran `mockd --no-ws --drop-connection 5`,
 connected `gui/tests/dod/dod_harness unhappy-path --phase drop-connection` against it
 (UDS, the GUI's only transport) with a 45 s observation window, and `stateChanged` never
 fired — the connection sat in `Connected` the entire time. Same command with `--flaky 0.3`
 correctly leaves the connection state alone (that flag only fails individual call
 replies, which is right), so this is specific to `--drop-connection` and the UDS
 transport, not a harness-side detection problem.
 **Effect:** every GUI/CLI/nmhost consumer of mockd — the only transport they actually
 use — cannot be tested against a dropped connection at all today. `gui/tests/dod/run.sh`
 ships its `unhappy-path` drop-connection phase anyway (log intentionally records
 `sawDisruption` in its JSON so this is visible, not silently green), but it is currently
 only proving the client survives 45 quiet seconds, not a real drop.
 ### Fix — mirror `ws.ts`'s existing pattern onto `uds.ts`
 **`tools/mockd/src/transport/uds.ts`:**
 ```diff
 export function startUds(
   path: string,
   dispatcher: Dispatcher,
   connections: Set<Connection>,
   log: (msg: string) => void,
   delayMs: number,
 +  dropEverySec: number = 0,
 ): Server {
   mkdirSync(dirname(path), { recursive: true });
   rmSync(path, { force: true });
 +  const sockets = new Set<Socket>();
   const server = createServer((socket: Socket) => {
 +    sockets.add(socket);
     const session: Session = { transport: 'uds', paired: true, subscribed: new Set(), sessionId: randomUUID() };
     const conn: Connection = {
       session,
       send: (frame) => {
         if (!socket.destroyed) socket.write(JSON.stringify(frame) + '\n');
       },
     };
     connections.add(conn);
     log(`uds: client connected (${connections.size} open)`);
     ...
     socket.on('error', (err) => log(`uds: socket error: ${err.message}`));
     socket.on('close', () => {
       connections.delete(conn);
 +      sockets.delete(socket);
       log(`uds: client disconnected (${connections.size} open)`);
     });
   });
   server.listen(path, () => log(`uds: listening on ${path}`));
 +
 +  if (dropEverySec > 0) {
 +    setInterval(() => {
 +      log(`uds: dropping ${sockets.size} connection(s) (--drop-connection)`);
 +      for (const s of sockets) s.destroy();
 +    }, dropEverySec * 1000).unref();
 +  }
 +
   return server;
 }
 ```
 **`tools/mockd/src/index.ts`** (~line 205):
 ```diff
 -    startUds(args.uds, dispatcher, connections, log, args.slow);
 +    startUds(args.uds, dispatcher, connections, log, args.slow, args.dropEverySec);
 ```
 Both use `.unref()`/existing shutdown handling already in `index.ts`, so no change needed
 there. `socket.destroy()` (vs. `.end()`) matches `ws.ts`'s `.terminate()` — an abrupt drop,
 which is the point of the flag.
 Not urgent for M0/M1 GUI work — `gui/tests/dod/run.sh`'s other two unhappy-path phases
 (`--slow`, `--flaky`) both work correctly over UDS today, and the drop-connection phase
 still exercises 45 s of otherwise-idle connection handling. But the flag's whole purpose
 is unmet on the transport every real consumer uses, and the fix is a direct port of code
 that already exists two files over.
@@ -0,0 +1,112 @@
 /* Velox — dark theme. Lane GUI. Structured identically to idm-like.qss — diff the two
 * when changing either.
 *
 * --- palette -----------------------------------------------------------------------
 *   --bg            #202225   window and dialog background
 *   --surface       #2b2d31   table/tree, input field backgrounds
 *   --surface-alt   #313338   alternating row colour
 *   --border        #3f4147   panel/header/input borders
 *   --text          #e6e7ea   primary text
 *   --text-muted    #9a9da3   secondary text (headers, disabled)
 *   --accent        #4c94e0   selection, focus ring, progress fill
 *   --accent-hover  #5da2ea   hovered accent (buttons, tabs)
 * -------------------------------------------------------------------------------------
 */
 QMainWindow, QDialog {
    background: #202225;
    color: #e6e7ea;
 }
 QTreeView, QTableView, QListView {
    background: #2b2d31;
    alternate-background-color: #313338;
    color: #e6e7ea;
    border: 1px solid #3f4147;
    selection-background-color: #4c94e0;
    selection-color: #202225;
 }
 QHeaderView::section {
    background: #313338;
    color: #9a9da3;
    border: none;
    border-right: 1px solid #3f4147;
    border-bottom: 1px solid #3f4147;
    padding: 4px 6px;
 }
 QLineEdit, QPlainTextEdit, QSpinBox, QComboBox {
    background: #2b2d31;
    border: 1px solid #3f4147;
    border-radius: 3px;
    padding: 2px 4px;
    color: #e6e7ea;
 }
 QLineEdit:focus, QPlainTextEdit:focus, QSpinBox:focus, QComboBox:focus {
    border: 1px solid #4c94e0;
 }
 QPushButton {
    background: #2b2d31;
    border: 1px solid #3f4147;
    border-radius: 3px;
    padding: 4px 12px;
    color: #e6e7ea;
 }
 QPushButton:hover {
    border-color: #5da2ea;
 }
 QPushButton:default {
    background: #4c94e0;
    border-color: #4c94e0;
    color: #202225;
 }
 QPushButton:default:hover {
    background: #5da2ea;
 }
 QTabWidget::pane {
    border: 1px solid #3f4147;
    background: #2b2d31;
 }
 QTabBar::tab {
    background: #313338;
    border: 1px solid #3f4147;
    border-bottom: none;
    padding: 4px 12px;
    color: #9a9da3;
 }
 QTabBar::tab:selected {
    background: #2b2d31;
    color: #e6e7ea;
 }
 QProgressBar {
    border: 1px solid #3f4147;
    border-radius: 3px;
    background: #313338;
    text-align: center;
    color: #e6e7ea;
 }
 QProgressBar::chunk {
    background: #4c94e0;
 }
 QMenu {
    background: #2b2d31;
    border: 1px solid #3f4147;
    color: #e6e7ea;
 }
 QMenu::item:selected {
    background: #4c94e0;
    color: #202225;
 }
@@ -0,0 +1,119 @@
 /* Velox — light theme. Lane GUI.
 *
 * docs/agents/AGENT-GUI.md build order step 8: "colours in one variables block at the
 * top of the QSS; no hard-coded hex scattered through widget code." QSS itself has no
 * variable syntax (Qt has never added one), so this block is the actual palette, kept in
 * one place and referenced from every rule below by comment rather than repeated ad hoc —
 * every hex value that appears more than once below is listed here first. dark.qss is
 * structured identically with its own values, so the two stay easy to diff against each
 * other when one changes.
 *
 * --- palette -----------------------------------------------------------------------
 *   --bg            #f4f5f7   window and dialog background
 *   --surface       #ffffff   table/tree, input field backgrounds
 *   --surface-alt   #eef0f3   alternating row colour
 *   --border        #d3d7dc   panel/header/input borders
 *   --text          #202225   primary text
 *   --text-muted    #6b7078   secondary text (headers, disabled)
 *   --accent        #2f7dd1   selection, focus ring, progress fill
 *   --accent-hover  #3f8ce0   hovered accent (buttons, tabs)
 * -------------------------------------------------------------------------------------
 */
 QMainWindow, QDialog {
    background: #f4f5f7;
    color: #202225;
 }
 QTreeView, QTableView, QListView {
    background: #ffffff;
    alternate-background-color: #eef0f3;
    color: #202225;
    border: 1px solid #d3d7dc;
    selection-background-color: #2f7dd1;
    selection-color: #ffffff;
 }
 QHeaderView::section {
    background: #eef0f3;
    color: #6b7078;
    border: none;
    border-right: 1px solid #d3d7dc;
    border-bottom: 1px solid #d3d7dc;
    padding: 4px 6px;
 }
 QLineEdit, QPlainTextEdit, QSpinBox, QComboBox {
    background: #ffffff;
    border: 1px solid #d3d7dc;
    border-radius: 3px;
    padding: 2px 4px;
    color: #202225;
 }
 QLineEdit:focus, QPlainTextEdit:focus, QSpinBox:focus, QComboBox:focus {
    border: 1px solid #2f7dd1;
 }
 QPushButton {
    background: #ffffff;
    border: 1px solid #d3d7dc;
    border-radius: 3px;
    padding: 4px 12px;
    color: #202225;
 }
 QPushButton:hover {
    border-color: #3f8ce0;
 }
 QPushButton:default {
    background: #2f7dd1;
    border-color: #2f7dd1;
    color: #ffffff;
 }
 QPushButton:default:hover {
    background: #3f8ce0;
 }
 QTabWidget::pane {
    border: 1px solid #d3d7dc;
    background: #ffffff;
 }
 QTabBar::tab {
    background: #eef0f3;
    border: 1px solid #d3d7dc;
    border-bottom: none;
    padding: 4px 12px;
    color: #6b7078;
 }
 QTabBar::tab:selected {
    background: #ffffff;
    color: #202225;
 }
 QProgressBar {
    border: 1px solid #d3d7dc;
    border-radius: 3px;
    background: #eef0f3;
    text-align: center;
    color: #202225;
 }
 QProgressBar::chunk {
    background: #2f7dd1;
 }
 QMenu {
    background: #ffffff;
    border: 1px solid #d3d7dc;
    color: #202225;
 }
 QMenu::item:selected {
    background: #2f7dd1;
    color: #ffffff;
 }
@@ -0,0 +1,172 @@
 #include "clipboard/GlobalShortcut.hpp"
 #include <QCoreApplication>
 #include <QDBusArgument>
 #include <QDBusConnection>
 #include <QDBusConnectionInterface>
 #include <QDBusMessage>
 #include <QDBusObjectPath>
 #include <QDBusPendingCallWatcher>
 #include <QDBusPendingReply>
 #include <QLoggingCategory>
 #include <QRandomGenerator>
 namespace velox::gui {
 namespace {
 Q_LOGGING_CATEGORY(lcShortcut, "velox.gui.globalshortcut")
 constexpr auto kService = "org.freedesktop.portal.Desktop";
 constexpr auto kObjectPath = "/org/freedesktop/portal/desktop";
 constexpr auto kShortcutsIface = "org.freedesktop.portal.GlobalShortcuts";
 constexpr auto kRequestIface = "org.freedesktop.portal.Request";
 constexpr auto kShortcutId = "add-url-from-clipboard";
 QString newToken(const QString &prefix) {
    return prefix + QString::number(QRandomGenerator::global()->generate64(), 16);
 }
 // org.freedesktop.portal.Request object paths embed the caller's own unique bus name
 // with ':' and '.' rewritten to '_' — reconstructing that is documented but fragile;
 // every portal client instead just uses the exact path CreateSession/BindShortcuts hand
 // back in their reply, which is what every call below does.
 void connectToRequestResponse(const QDBusObjectPath &requestPath, QObject *receiver,
                              const char *slot) {
    QDBusConnection::sessionBus().connect(QString::fromLatin1(kService), requestPath.path(),
                                          QString::fromLatin1(kRequestIface),
                                          QStringLiteral("Response"), receiver, slot);
 }
 }  // namespace
 GlobalShortcut::GlobalShortcut(QObject *parent) : QObject(parent) {}
 void GlobalShortcut::requestBinding() {
    if (requested_) {
        return;
    }
    requested_ = true;
    if (!QDBusConnection::sessionBus().isConnected()) {
        qCInfo(lcShortcut, "no D-Bus session bus — global shortcut unavailable this session");
        return;
    }
    // GlobalShortcuts is an *impl* portal some desktops never install; check the name is
    // even owned before making a call whose only failure mode would otherwise be a vague
    // D-Bus service-unknown error.
    if (!QDBusConnection::sessionBus().interface()->isServiceRegistered(
            QString::fromLatin1(kService))) {
        qCInfo(lcShortcut, "no xdg-desktop-portal on this session bus");
        return;
    }
    // QDBusMessage::createMethodCall + asyncCall, not QDBusInterface: the interface class
    // introspects the remote object on first use and caches the result in a process-wide
    // QDBusMetaObject table it never frees — by design (Qt intends it to live for the
    // process's lifetime so repeated calls skip introspection), but that reads as a real
    // LeakSanitizer leak the first time anything in this binary touches D-Bus at all,
    // which is exactly what happened here (caught live, `ctest -L gui`'s tst_rtl went red
    // under ASan). A raw method-call message needs no introspection and allocates nothing
    // that outlives this call.
    QDBusMessage call = QDBusMessage::createMethodCall(
        QString::fromLatin1(kService), QString::fromLatin1(kObjectPath),
        QString::fromLatin1(kShortcutsIface), QStringLiteral("CreateSession"));
    const QVariantMap options{
        {QStringLiteral("handle_token"), newToken(QStringLiteral("velox_create_"))},
        {QStringLiteral("session_handle_token"), newToken(QStringLiteral("velox_session_"))},
    };
    call << options;
    auto *watcher =
        new QDBusPendingCallWatcher(QDBusConnection::sessionBus().asyncCall(call), this);
    connect(watcher, &QDBusPendingCallWatcher::finished, this, [this, watcher] {
        watcher->deleteLater();
        const QDBusPendingReply<QDBusObjectPath> reply = *watcher;
        if (reply.isError()) {
            qCInfo(lcShortcut, "CreateSession failed: %s", qUtf8Printable(reply.error().message()));
            return;
        }
        connectToRequestResponse(reply.value(), this,
                                 SLOT(onCreateSessionResponse(uint, QVariantMap)));
    });
 }
 void GlobalShortcut::onCreateSessionResponse(uint code, const QVariantMap &results) {
    if (code != 0) {
        qCInfo(lcShortcut, "CreateSession request denied/failed (code %u)", code);
        return;
    }
    sessionHandle_ = results.value(QStringLiteral("session_handle")).toString();
    if (sessionHandle_.isEmpty()) {
        qCWarning(lcShortcut, "CreateSession succeeded with no session_handle — portal bug?");
        return;
    }
    bindShortcuts();
 }
 void GlobalShortcut::bindShortcuts() {
    // a(sa{sv}): one (id, properties) pair per shortcut. QtDBus has no automatic
    // marshalling for a struct-in-array-of-variants shape this specific, so it is built by
    // hand with QDBusArgument — the documented escape hatch for exactly this case.
    QDBusArgument shortcutsArg;
    shortcutsArg.beginArray(qMetaTypeId<QDBusArgument>());
    shortcutsArg.beginStructure();
    shortcutsArg << QString::fromLatin1(kShortcutId);
    QVariantMap props{
        {QStringLiteral("description"),
         QCoreApplication::translate("velox::gui::GlobalShortcut",
                                     "Add URL from clipboard (Velox)")},
    };
    shortcutsArg << props;
    shortcutsArg.endStructure();
    shortcutsArg.endArray();
    QDBusMessage call = QDBusMessage::createMethodCall(
        QString::fromLatin1(kService), QString::fromLatin1(kObjectPath),
        QString::fromLatin1(kShortcutsIface), QStringLiteral("BindShortcuts"));
    const QVariantMap options{
        {QStringLiteral("handle_token"), newToken(QStringLiteral("velox_bind_"))}};
    call << QVariant::fromValue(QDBusObjectPath(sessionHandle_))
         << QVariant::fromValue(shortcutsArg) << QString() << options;
    auto *watcher =
        new QDBusPendingCallWatcher(QDBusConnection::sessionBus().asyncCall(call), this);
    connect(watcher, &QDBusPendingCallWatcher::finished, this, [this, watcher] {
        watcher->deleteLater();
        const QDBusPendingReply<QDBusObjectPath> reply = *watcher;
        if (reply.isError()) {
            qCInfo(lcShortcut, "BindShortcuts failed: %s", qUtf8Printable(reply.error().message()));
            return;
        }
        connectToRequestResponse(reply.value(), this,
                                 SLOT(onBindShortcutsResponse(uint, QVariantMap)));
    });
 }
 void GlobalShortcut::onBindShortcutsResponse(uint code, const QVariantMap &results) {
    if (code != 0) {
        // The user declined the "let Velox bind a shortcut" prompt, or the compositor
        // doesn't implement the portal even though the service exists. Both silent,
        // permanent for this session — see the header comment.
        qCInfo(lcShortcut, "BindShortcuts request declined/failed (code %u)", code);
        return;
    }
    qCInfo(lcShortcut, "global shortcut bound: %s", kShortcutId);
    Q_UNUSED(results);
    QDBusConnection::sessionBus().connect(
        QString::fromLatin1(kService), QString::fromLatin1(kObjectPath),
        QString::fromLatin1(kShortcutsIface), QStringLiteral("Activated"), this,
        SLOT(onPortalActivated(QDBusObjectPath, QString, qulonglong, QVariantMap)));
 }
 void GlobalShortcut::onPortalActivated(const QDBusObjectPath &sessionHandle,
                                       const QString &shortcutId, qulonglong timestamp,
                                       const QVariantMap &options) {
    Q_UNUSED(timestamp);
    Q_UNUSED(options);
    if (sessionHandle.path() != sessionHandle_ || shortcutId != QLatin1String(kShortcutId)) {
        return;  // another session/shortcut on the same signal, not ours
    }
    emit activated();
 }
 }  // namespace velox::gui
@@ -0,0 +1,59 @@
 // Explicit clipboard capture, path #2. Lane GUI.
 //
 // docs/06-risks-and-spikes.md R2: a Wayland client cannot passively observe clipboard
 // changes made by other applications — not a bug, a deliberate security property, and
 // the mechanism IDM's clipboard capture relies on does not exist here. The ship-regardless
 // design has three *explicit* paths instead; this is the second one — a global shortcut
 // via org.freedesktop.portal.GlobalShortcuts that reads the clipboard on demand when the
 // user presses it. (#1 is the extension's context menu, EXT's; #3 is AddUrlDialog's
 // clipboard prefill on open, already in place.)
 //
 // Best-effort by design, same as the risk doc says to treat all of this: the portal may
 // not exist on this desktop, the compositor may not implement it even if the portal
 // service does, or the user may decline the one-time "let Velox bind a global shortcut"
 // prompt. Every one of those is silent, permanent for this session, and never surfaced as
 // an error — there is nothing actionable for the user to do about a desktop that doesn't
 // have this, and the explicit paths (menu, prefill) still work regardless. Never promise
 // this in the UI before it has actually fired once.
 #pragma once
 #include <QObject>
 #include <QVariantMap>
 class QDBusObjectPath;
 namespace velox::gui {
 class GlobalShortcut : public QObject {
    Q_OBJECT
  public:
    explicit GlobalShortcut(QObject *parent = nullptr);
    /// Fire-and-forget: asks the portal for a session, then to bind one shortcut. There is
    /// no synchronous "is this supported" answer — connect activated() and find out from
    /// whether it ever fires. Safe to call once at startup; safe to call on a desktop with
    /// no portal at all (logs and returns, does nothing further).
    void requestBinding();
  signals:
    /// The bound shortcut was pressed. No payload on purpose: the receiver reads the
    /// clipboard itself at this moment (the "on demand" part of the explicit-path design),
    /// so nothing here ever touches clipboard content that wasn't asked for right now.
    void activated();
  private slots:
    void onCreateSessionResponse(uint code, const QVariantMap &results);
    void onBindShortcutsResponse(uint code, const QVariantMap &results);
    void onPortalActivated(const QDBusObjectPath &sessionHandle, const QString &shortcutId,
                           qulonglong timestamp, const QVariantMap &options);
  private:
    void bindShortcuts();
    QString sessionHandle_;
    bool requested_ = false;
 };
 }  // namespace velox::gui
@@ -21,6 +21,7 @@
 #include "rpc/Protocol.hpp"
 #include "rpc/RpcClient.hpp"
 #include "util/Theme.hpp"
 namespace velox::gui {
 namespace {
@@ -164,7 +165,7 @@ BatchDialog::BatchDialog(rpc::RpcClient *client, QJsonArray categories, QJsonArr
    });
    queueCombo_->setEnabled(false);
-    errorLabel_->setStyleSheet(QStringLiteral("color: #c0392b;"));
+    errorLabel_->setStyleSheet(theme::errorLabelStyle());
    errorLabel_->setWordWrap(true);
    errorLabel_->hide();
@@ -18,6 +18,7 @@
 #include <QVBoxLayout>
 #include "rpc/RpcClient.hpp"
 #include "util/Theme.hpp"
 namespace velox::gui {
 namespace {
@@ -101,7 +102,7 @@ FileInfoDialog::FileInfoDialog(rpc::RpcClient *client, QString url, QJsonArray c
    form->addRow(tr("Buffer:"), bufferCombo_);
    form->addRow(QString(), remember);
-    errorLabel_->setStyleSheet(QStringLiteral("color: #c0392b;"));
+    errorLabel_->setStyleSheet(theme::errorLabelStyle());
    errorLabel_->setWordWrap(true);
    errorLabel_->hide();
@@ -23,6 +23,7 @@
 #include "rpc/Protocol.hpp"
 #include "rpc/RpcClient.hpp"
 #include "util/Theme.hpp"
 namespace velox::gui {
 namespace {
@@ -177,7 +178,7 @@ class GrabberReviewPage : public QWizardPage {
        startModeCombo_->addItem(QObject::tr("Download Later"), QStringLiteral("later"));
        errorLabel_ = new QLabel(this);
-        errorLabel_->setStyleSheet(QStringLiteral("color: #c0392b;"));
+        errorLabel_->setStyleSheet(theme::errorLabelStyle());
        errorLabel_->hide();
        auto *footer = new QFormLayout;
@@ -9,6 +9,7 @@
 #include <QJsonArray>
 #include <QLabel>
 #include <QLineEdit>
 #include <QPlainTextEdit>
 #include <QPointer>
 #include <QPushButton>
 #include <QSpinBox>
@@ -18,6 +19,7 @@
 #include "rpc/Protocol.hpp"
 #include "rpc/RpcClient.hpp"
 #include "util/Theme.hpp"
 namespace velox::gui {
 namespace {
@@ -43,7 +45,7 @@ void setBufferCombo(QComboBox *combo, qint64 bytes) {
    combo->setCurrentIndex(combo->count() / 2);  // an unrecognized value: land near the middle
 }
-QStringList splitHosts(const QString &text) {
+QStringList splitCsv(const QString &text) {
    QStringList out;
    for (const QString &h : text.split(QLatin1Char(','), Qt::SkipEmptyParts)) {
        out << h.trimmed();
@@ -51,6 +53,14 @@ QStringList splitHosts(const QString &text) {
    return out;
 }
 QString joinArray(const QJsonArray &a) {
    QStringList items;
    for (const QJsonValue &v : a) {
        items << v.toString();
    }
    return items.join(QStringLiteral(", "));
 }
 }  // namespace
 QStringList OptionsDialog::allKeys() {
@@ -61,10 +71,18 @@ QStringList OptionsDialog::allKeys() {
        "general.confirmOnExit",
        "general.language",
        "general.checkForUpdates",
        "capture.enabled",
        "capture.monitoredExtensions",
        "capture.monitoredMimeTypes",
        "capture.minSizeBytes",
        "capture.excludedHosts",
        "capture.bypassModifier",
        "capture.autoStartTypes",
        "saveTo.defaultDir",
        "saveTo.tempDir",
        "saveTo.fileExistsPolicy",
        "saveTo.createSubfolderPerSite",
        "saveTo.allowedRoots",
        "connection.preset",
        "connection.maxSegmentsPerDownload",
        "connection.bufferBytes",
@@ -112,13 +130,14 @@ OptionsDialog::OptionsDialog(rpc::RpcClient *client, QWidget *parent)
    resize(560, 480);
    buildGeneralTab();
    buildCaptureTab();
    buildSaveToTab();
    buildConnectionTab();
    buildDownloadsTab();
    buildProxyTab();
    buildSoundsTab();
-    statusLabel_->setStyleSheet(QStringLiteral("color: #c0392b;"));
+    statusLabel_->setStyleSheet(theme::errorLabelStyle());
    statusLabel_->hide();
    auto *buttons = new QDialogButtonBox(
@@ -183,6 +202,37 @@ void OptionsDialog::buildGeneralTab() {
    tabs_->addTab(page, tr("General"));
 }
 void OptionsDialog::buildCaptureTab() {
    auto *page = new QWidget(this);
    captureEnabled_ = new QCheckBox(tr("Capture downloads from the browser extension"), page);
    monitoredExtensions_ = new QLineEdit(page);
    monitoredExtensions_->setPlaceholderText(tr("comma-separated, e.g. zip, iso, mp4"));
    monitoredMimeTypes_ = new QLineEdit(page);
    monitoredMimeTypes_->setPlaceholderText(tr("comma-separated, e.g. application/zip"));
    minSizeKiB_ = new QSpinBox(page);
    minSizeKiB_->setRange(0, 2000000);
    minSizeKiB_->setSuffix(tr(" KiB"));
    excludedHosts_ = new QLineEdit(page);
    excludedHosts_->setPlaceholderText(tr("comma-separated, e.g. *.google.com"));
    bypassModifier_ = new QComboBox(page);
    bypassModifier_->addItem(tr("Alt"), QStringLiteral("alt"));
    bypassModifier_->addItem(tr("Ctrl"), QStringLiteral("ctrl"));
    bypassModifier_->addItem(tr("Shift"), QStringLiteral("shift"));
    bypassModifier_->addItem(tr("None"), QStringLiteral("none"));
    autoStartTypes_ = new QLineEdit(page);
    autoStartTypes_->setPlaceholderText(tr("extensions that skip the File Info dialog"));
    auto *form = new QFormLayout(page);
    form->addRow(captureEnabled_);
    form->addRow(tr("Monitored extensions:"), monitoredExtensions_);
    form->addRow(tr("Monitored MIME types:"), monitoredMimeTypes_);
    form->addRow(tr("Minimum size:"), minSizeKiB_);
    form->addRow(tr("Never capture from:"), excludedHosts_);
    form->addRow(tr("Bypass-capture modifier key:"), bypassModifier_);
    form->addRow(tr("Auto-start these types:"), autoStartTypes_);
    tabs_->addTab(page, tr("Capture"));
 }
 void OptionsDialog::buildSaveToTab() {
    auto *page = new QWidget(this);
    defaultDir_ = new QLineEdit(page);
@@ -193,6 +243,11 @@ void OptionsDialog::buildSaveToTab() {
    fileExistsPolicy_->addItem(tr("Overwrite"), QStringLiteral("overwrite"));
    fileExistsPolicy_->addItem(tr("Resume"), QStringLiteral("resume"));
    createSubfolderPerSite_ = new QCheckBox(tr("Create a subfolder per site"), page);
    allowedRoots_ = new QPlainTextEdit(page);
    allowedRoots_->setPlaceholderText(
        tr("One directory per line — every save path must "
           "canonicalize inside one of these"));
    allowedRoots_->setMaximumHeight(80);
    auto *defaultDirRow = new QWidget(page);
    auto *defaultDirLayout = new QHBoxLayout(defaultDirRow);
@@ -215,6 +270,7 @@ void OptionsDialog::buildSaveToTab() {
    form->addRow(tr("Temp folder:"), tempDirRow);
    form->addRow(tr("If a file already exists:"), fileExistsPolicy_);
    form->addRow(createSubfolderPerSite_);
    form->addRow(tr("Allowed save roots:"), allowedRoots_);
    tabs_->addTab(page, tr("Save To"));
 }
@@ -390,12 +446,27 @@ void OptionsDialog::populateFrom(const QJsonObject &v) {
    language_->setCurrentIndex(langIdx >= 0 ? langIdx : 0);
    checkForUpdates_->setChecked(v.value("general.checkForUpdates").toBool(true));
    captureEnabled_->setChecked(v.value("capture.enabled").toBool(true));
    monitoredExtensions_->setText(joinArray(v.value("capture.monitoredExtensions").toArray()));
    monitoredMimeTypes_->setText(joinArray(v.value("capture.monitoredMimeTypes").toArray()));
    minSizeKiB_->setValue(static_cast<int>(v.value("capture.minSizeBytes").toDouble() / 1024));
    excludedHosts_->setText(joinArray(v.value("capture.excludedHosts").toArray()));
    const int bypassIdx =
        bypassModifier_->findData(v.value("capture.bypassModifier").toString("alt"));
    bypassModifier_->setCurrentIndex(bypassIdx >= 0 ? bypassIdx : 0);
    autoStartTypes_->setText(joinArray(v.value("capture.autoStartTypes").toArray()));
    defaultDir_->setText(v.value("saveTo.defaultDir").toString());
    tempDir_->setText(v.value("saveTo.tempDir").toString());
    const int policyIdx =
        fileExistsPolicy_->findData(v.value("saveTo.fileExistsPolicy").toString("ask"));
    fileExistsPolicy_->setCurrentIndex(policyIdx >= 0 ? policyIdx : 0);
    createSubfolderPerSite_->setChecked(v.value("saveTo.createSubfolderPerSite").toBool());
    QStringList roots;
    for (const QJsonValue &r : v.value("saveTo.allowedRoots").toArray()) {
        roots << r.toString();
    }
    allowedRoots_->setPlainText(roots.join(QLatin1Char('\n')));
    const int presetIdx =
        connectionPreset_->findData(v.value("connection.preset").toString("auto"));
@@ -452,10 +523,28 @@ QJsonObject OptionsDialog::currentValues() const {
    v["general.language"] = language_->currentData().toString();
    v["general.checkForUpdates"] = checkForUpdates_->isChecked();
    v["capture.enabled"] = captureEnabled_->isChecked();
    v["capture.monitoredExtensions"] =
        QJsonArray::fromStringList(splitCsv(monitoredExtensions_->text()));
    v["capture.monitoredMimeTypes"] =
        QJsonArray::fromStringList(splitCsv(monitoredMimeTypes_->text()));
    v["capture.minSizeBytes"] = static_cast<qint64>(minSizeKiB_->value()) * 1024;
    v["capture.excludedHosts"] = QJsonArray::fromStringList(splitCsv(excludedHosts_->text()));
    v["capture.bypassModifier"] = bypassModifier_->currentData().toString();
    v["capture.autoStartTypes"] = QJsonArray::fromStringList(splitCsv(autoStartTypes_->text()));
    v["saveTo.defaultDir"] = defaultDir_->text();
    v["saveTo.tempDir"] = tempDir_->text();
    v["saveTo.fileExistsPolicy"] = fileExistsPolicy_->currentData().toString();
    v["saveTo.createSubfolderPerSite"] = createSubfolderPerSite_->isChecked();
    QStringList roots;
    for (const QString &line : allowedRoots_->toPlainText().split(QLatin1Char('\n'))) {
        const QString trimmed = line.trimmed();
        if (!trimmed.isEmpty()) {
            roots << trimmed;
        }
    }
    v["saveTo.allowedRoots"] = QJsonArray::fromStringList(roots);
    v["connection.preset"] = connectionPreset_->currentData().toString();
    v["connection.maxSegmentsPerDownload"] = maxSegmentsPerDownload_->value();
@@ -479,7 +568,7 @@ QJsonObject OptionsDialog::currentValues() const {
    v["proxy.host"] = proxyHost_->text();
    v["proxy.port"] = proxyPort_->value();
    v["proxy.username"] = proxyUsername_->text();
-    v["proxy.bypassHosts"] = QJsonArray::fromStringList(splitHosts(proxyBypassHosts_->text()));
+    v["proxy.bypassHosts"] = QJsonArray::fromStringList(splitCsv(proxyBypassHosts_->text()));
    v["proxy.pacUrl"] = proxyPacUrl_->text();
    v["sounds.enabled"] = soundsEnabled_->isChecked();
@@ -1,11 +1,12 @@
 // The Options dialog. Lane GUI.
 //
 // docs/03-gui-spec.md §4: every control here maps 1:1 onto a settings.* key from
-// contracts/schema/types/Settings.schema.json. The spec's "File Types" and "Site Logins"
+// contracts/schema/types/Settings.schema.json. The spec's "File Types" tab turned out to
-// tabs have no backing key (per-category extension lists live on Category via
+// have real backing after all (capture.monitoredExtensions/monitoredMimeTypes/
-// category.upsert, not settings.*; login credentials go to the Secret Service) — a real
+// autoStartTypes are settings.* keys, not Category — a mistake in an earlier pass here,
-// tab either binds to a real key or does not exist here, so those two are left out rather
+// caught while checking this dialog covers all 43 keys against the now-live real veloxd);
-// than shipped as fake affordances.
+// it is named "Capture" below to match what it actually configures. "Site Logins" still
 // has no settings.* key (credentials go to the Secret Service) and stays out.
 #pragma once
@@ -16,6 +17,7 @@ class QCheckBox;
 class QComboBox;
 class QLabel;
 class QLineEdit;
 class QPlainTextEdit;
 class QSpinBox;
 class QTabWidget;
@@ -45,6 +47,7 @@ class OptionsDialog : public QDialog {
  private:
    void buildGeneralTab();
    void buildCaptureTab();
    void buildSaveToTab();
    void buildConnectionTab();
    void buildDownloadsTab();
@@ -67,11 +70,21 @@ class OptionsDialog : public QDialog {
    QComboBox *language_;
    QCheckBox *checkForUpdates_;
    // Capture
    QCheckBox *captureEnabled_;
    QLineEdit *monitoredExtensions_;
    QLineEdit *monitoredMimeTypes_;
    QSpinBox *minSizeKiB_;
    QLineEdit *excludedHosts_;
    QComboBox *bypassModifier_;
    QLineEdit *autoStartTypes_;
    // Save To
    QLineEdit *defaultDir_;
    QLineEdit *tempDir_;
    QComboBox *fileExistsPolicy_;
    QCheckBox *createSubfolderPerSite_;
    QPlainTextEdit *allowedRoots_;
    // Connection
    QComboBox *connectionPreset_;
@@ -17,6 +17,7 @@
 #include "rpc/Protocol.hpp"
 #include "rpc/RpcClient.hpp"
 #include "util/Theme.hpp"
 namespace velox::gui {
 namespace {
@@ -126,7 +127,7 @@ SchedulerDialog::SchedulerDialog(rpc::RpcClient *client, QWidget *parent)
        }
    });
-    statusLabel_->setStyleSheet(QStringLiteral("color: #c0392b;"));
+    statusLabel_->setStyleSheet(theme::errorLabelStyle());
    statusLabel_->hide();
    form_->setEnabled(false);  // no queue selected yet
@@ -12,6 +12,7 @@
 #include "rpc/Protocol.hpp"
 #include "rpc/RpcClient.hpp"
 #include "util/Theme.hpp"
 namespace velox::gui {
@@ -38,7 +39,7 @@ SpeedLimiterDialog::SpeedLimiterDialog(rpc::RpcClient *client, QWidget *parent)
    kibps_->setEnabled(false);
    connect(enabled_, &QCheckBox::toggled, kibps_, &QWidget::setEnabled);
-    statusLabel_->setStyleSheet(QStringLiteral("color: #c0392b;"));
+    statusLabel_->setStyleSheet(theme::errorLabelStyle());
    statusLabel_->hide();
    auto *form = new QFormLayout;
@@ -11,6 +11,8 @@
 #include "mainwindow/MainWindow.hpp"
 #include "rpc/Protocol.hpp"
 #include "rpc/RpcClient.hpp"
 #include "util/ThemeManager.hpp"
 #include "util/UiThreadWatchdog.hpp"
 namespace {
@@ -45,6 +47,16 @@ int main(int argc, char **argv) {
        app.installTranslator(&translator);
    }
    // docs/03-gui-spec.md §7: follows QStyleHints::colorScheme() live, not just at
    // startup. Owned by main() (not MainWindow) since it's an application-wide concern.
    velox::gui::ThemeManager theme;
    theme.apply();
    // AGENT-GUI.md M1 DoD: "no blocking call on the UI thread: verified with a 200 ms
    // watchdog in debug builds." No-op in a release build — see UiThreadWatchdog::start().
    velox::gui::UiThreadWatchdog watchdog;
    watchdog.start();
    velox::gui::rpc::RpcClient client(defaultSocketPath());
    velox::gui::MainWindow window(&client);
    window.show();
@@ -37,8 +37,14 @@
 #include "rpc/RpcClient.hpp"
 #include "tray/TrayIcon.hpp"
 #include "util/Format.hpp"
 #include "util/Theme.hpp"
 #include "widgets/DropTargetWidget.hpp"
 #include "widgets/ProgressDelegate.hpp"
 #ifdef VELOX_GUI_HAVE_DBUS
 #include "clipboard/GlobalShortcut.hpp"
 #endif
 namespace velox::gui {
 namespace {
@@ -88,7 +94,9 @@ MainWindow::MainWindow(rpc::RpcClient *client, QWidget *parent)
    bannerLabel->setObjectName(QStringLiteral("offlineBannerLabel"));
    bannerLayout->addWidget(bannerLabel);
    bannerLayout->addStretch();
-    offlineBanner_->setStyleSheet(QStringLiteral("background: #5a3a00; color: #ffd9a0;"));
+    offlineBanner_->setStyleSheet(
        QStringLiteral("background: %1; color: %2;")
            .arg(QLatin1String(theme::kOfflineBannerBg), QLatin1String(theme::kOfflineBannerText)));
    offlineBanner_->setVisible(false);
    auto *splitter = new QSplitter(Qt::Horizontal, this);
@@ -111,9 +119,10 @@ MainWindow::MainWindow(rpc::RpcClient *client, QWidget *parent)
    buildMenus();
    buildToolBar();
    buildTray();
    buildDropTarget();
    // --- status bar -----------------------------------------------------------------
-    connDot_->setStyleSheet(dotStyle(QStringLiteral("#c0392b")));
+    connDot_->setStyleSheet(dotStyle(QLatin1String(theme::kDanger)));
    statusBar()->addPermanentWidget(countsLabel_, 1);
    statusBar()->addPermanentWidget(connText_);
    statusBar()->addPermanentWidget(connDot_);
@@ -261,6 +270,23 @@ void MainWindow::buildTray() {
    trayIcon_->show();
 }
 void MainWindow::buildDropTarget() {
    // Qt::Tool + a parent keeps it grouped with the main window (no separate taskbar
    // entry, destroyed when MainWindow is) while still floating independently per spec.
    dropTarget_ = new DropTargetWidget(this);
    connect(dropTarget_, &DropTargetWidget::urlDropped, this, &MainWindow::onUrlDropped);
    connect(dropTarget_, &DropTargetWidget::addUrlRequested, this, &MainWindow::openAddUrlDialog);
 #ifdef VELOX_GUI_HAVE_DBUS
    // docs/06-risks-and-spikes.md R2, explicit path #2. Best-effort: requestBinding() is
    // silent and permanent-for-this-session on any desktop that lacks the portal or
    // declines the prompt — see GlobalShortcut's own header for why that's by design.
    globalShortcut_ = new GlobalShortcut(this);
    connect(globalShortcut_, &GlobalShortcut::activated, this, &MainWindow::openAddUrlDialog);
    globalShortcut_->requestBinding();
 #endif
 }
 void MainWindow::closeEvent(QCloseEvent *event) {
    if (minimizeToTrayEnabled_ && trayIcon_ && trayIcon_->isVisible()) {
        hide();
@@ -275,11 +301,11 @@ void MainWindow::closeEvent(QCloseEvent *event) {
 void MainWindow::onConnectionState(rpc::ConnectionState state) {
    connText_->setText(tr(rpc::toString(state)));
-    QString colour = QStringLiteral("#c0392b");  // red
+    QString colour = QLatin1String(theme::kDanger);
    if (state == rpc::ConnectionState::Connected) {
-        colour = QStringLiteral("#27ae60");  // green
+        colour = QLatin1String(theme::kSuccess);
    } else if (state != rpc::ConnectionState::Disconnected) {
-        colour = QStringLiteral("#e67e22");  // amber
+        colour = QLatin1String(theme::kWarning);
    }
    connDot_->setStyleSheet(dotStyle(colour));
@@ -299,7 +325,7 @@ void MainWindow::onConnectionState(rpc::ConnectionState state) {
    if (online) {
        fetchTree();
-        fetchMinimizeToTraySetting();
+        fetchGeneralUiSettings();
    }
 }
@@ -318,29 +344,40 @@ void MainWindow::fetchTree() {
    });
 }
-void MainWindow::fetchMinimizeToTraySetting() {
+void MainWindow::fetchGeneralUiSettings() {
-    client_->call(QStringLiteral("settings.get"),
+    client_->call(
-                  QJsonObject{{"keys", QJsonArray{QStringLiteral("general.minimizeToTray")}}},
+        QStringLiteral("settings.get"),
        QJsonObject{{"keys", QJsonArray{QStringLiteral("general.minimizeToTray"),
                                        QStringLiteral("general.showDropTarget")}}},
        [this](const rpc::RpcReply &reply) {
-                      if (reply.ok()) {
+            if (!reply.ok()) {
-                          minimizeToTrayEnabled_ = reply.result.toObject()
+                return;
-                                                       .value("values")
+            }
-                                                       .toObject()
+            const QJsonObject values = reply.result.toObject().value("values").toObject();
-                                                       .value("general.minimizeToTray")
+            minimizeToTrayEnabled_ = values.value("general.minimizeToTray").toBool();
-                                                       .toBool();
+            if (dropTarget_) {
                dropTarget_->setVisible(values.value("general.showDropTarget").toBool(true));
            }
        });
 }
 void MainWindow::onSettingsChanged(const QJsonObject &params) {
    for (const QJsonValue &key : params.value("keys").toArray()) {
-        if (key.toString() == QLatin1String("general.minimizeToTray")) {
+        const QString k = key.toString();
-            fetchMinimizeToTraySetting();
+        if (k == QLatin1String("general.minimizeToTray") ||
            k == QLatin1String("general.showDropTarget")) {
            fetchGeneralUiSettings();
            break;
        }
    }
 }
 void MainWindow::onUrlDropped(const QString &url) {
    auto *info = new FileInfoDialog(client_, url, categoriesCache_, queuesCache_, this);
    info->setAttribute(Qt::WA_DeleteOnClose);
    info->show();
 }
 void MainWindow::openAddUrlDialog() {
    AddUrlDialog dlg(this);
    if (dlg.exec() != QDialog::Accepted) {
@@ -26,6 +26,10 @@ namespace velox::gui {
 class DownloadTableModel;
 class CategoryPanel;
 class TrayIcon;
 class DropTargetWidget;
 #ifdef VELOX_GUI_HAVE_DBUS
 class GlobalShortcut;
 #endif
 namespace rpc {
 class RpcClient;
 }  // namespace rpc
@@ -64,14 +68,16 @@ class MainWindow : public QMainWindow {
    void openGrabberWizard();
    void showAndRaise();
    void onSettingsChanged(const QJsonObject &params);
    void onUrlDropped(const QString &url);
  private:
    void buildActions();
    void buildMenus();
    void buildToolBar();
    void buildTray();
    void buildDropTarget();
    void fetchTree();
-    void fetchMinimizeToTraySetting();
+    void fetchGeneralUiSettings();
    QStringList selectedTaskIds() const;
    QStringList allTaskIds() const;
    void actOnTasks(const char *methodName, const QStringList &ids);
@@ -102,7 +108,11 @@ class MainWindow : public QMainWindow {
    QJsonArray categoriesCache_;
    QJsonArray queuesCache_;
    TrayIcon *trayIcon_ = nullptr;
    DropTargetWidget *dropTarget_ = nullptr;
    bool minimizeToTrayEnabled_ = false;
 #ifdef VELOX_GUI_HAVE_DBUS
    GlobalShortcut *globalShortcut_ = nullptr;
 #endif
    QLabel *connDot_;
    QLabel *connText_;
@@ -56,6 +56,13 @@ void RpcClient::stop() {
    QMetaObject::invokeMethod(conn_, "stop", Qt::QueuedConnection);
    thread_.quit();
    thread_.wait();
    // thread_.wait() does not return until thread_'s own finish() has already flushed the
    // DeferredDelete this class's own connect(&thread_, &QThread::finished, conn_,
    // &QObject::deleteLater) posted — conn_ is gone by now. Null it out so a later call
    // (stop() is a public slot; a caller stopping and then destroying the client is normal
    // use, and the destructor's own `delete conn_` for the never-started case must not
    // run a second time against memory this path already freed).
    conn_ = nullptr;
 }
 void RpcClient::call(const QString &methodName, const QJsonObject &params,
@@ -76,17 +83,44 @@ void RpcClient::onConnectionState(int state) {
 }
 void RpcClient::requestInitialList() {
-    call(QString::fromLatin1(method::kDownloadList), QJsonObject{{"limit", 1000}},
+    fetchListPage(0, {});
-         [this](const RpcReply &reply) {
+}
 // download.list.schema.json: "Filtering, sorting and paging all happen in the daemon so
 // the GUI never materializes 100k rows to show 40" — limit maxes out at 5000, so one call
 // cannot ever return everything for a table the DoD's own gate says can hold 10 000 rows.
 // A single fixed-limit call here silently truncated the table below that (caught by
 // gui/tests/dod's scroll-60fps gate refusing to run against a 1000-row table when mockd
 // seeded 10000). Page until `total` is satisfied, then reset the model exactly once.
 void RpcClient::fetchListPage(int offset, QJsonArray accumulated) {
    constexpr int kPageSize = 5000;  // download.list's own maximum
    constexpr int kMaxPages = 100;   // 500 000 rows — a safety cap, not an expected ceiling
    call(QString::fromLatin1(method::kDownloadList),
         QJsonObject{{"offset", offset}, {"limit", kPageSize}},
         [this, offset, accumulated](const RpcReply &reply) mutable {
             if (!reply.ok()) {
                 qCWarning(lcRpc, "download.list failed: %d %s", reply.error.code,
                           qUtf8Printable(reply.error.message));
                 if (!accumulated.isEmpty()) {
                     emit taskListReset(accumulated);  // show what we got rather than nothing
                 }
                 return;
             }
-             const QJsonArray items = reply.result.toObject().value("items").toArray();
+             const QJsonObject result = reply.result.toObject();
-             qCInfo(lcRpc, "initial download.list: %lld row(s)",
+             const QJsonArray page = result.value("items").toArray();
-                    static_cast<long long>(items.size()));
+             const qint64 total = static_cast<qint64>(result.value("total").toDouble());
-             emit taskListReset(items);
+             for (const QJsonValue &item : page) {
                 accumulated.append(item);
             }
             const bool morePages =
                 !page.isEmpty() && accumulated.size() < total && (offset / kPageSize) < kMaxPages;
             if (morePages) {
                 fetchListPage(offset + static_cast<int>(page.size()), accumulated);
                 return;
             }
             qCInfo(lcRpc, "initial download.list: %lld of %lld row(s)",
                    static_cast<long long>(accumulated.size()), static_cast<long long>(total));
             emit taskListReset(accumulated);
         });
 }
@@ -67,6 +67,7 @@ class RpcClient : public QObject {
  private:
    void requestInitialList();
    void fetchListPage(int offset, QJsonArray accumulated);
    QThread thread_;
    RpcConnection *conn_ = nullptr;  // owned by thread_ affinity, deleted on thread finish
@@ -154,10 +154,12 @@ void RpcConnection::dispatchFrame(const QJsonObject &frame) {
                socket_->abort();  // version mismatch or refused — bounce and retry
                return;
            }
-            sendRaw(kSubscribeId, QString::fromLatin1(method::kSessionSubscribe),
+            sendRaw(
-                    QJsonObject{{"events", QJsonArray{event::kTaskAdded, event::kTaskRemoved,
+                kSubscribeId, QString::fromLatin1(method::kSessionSubscribe),
-                                                      event::kTaskState, event::kTaskProgress,
+                QJsonObject{
-                                                      event::kSpeedGlobal, event::kNotify}}});
+                    {"events", QJsonArray{event::kTaskAdded, event::kTaskRemoved, event::kTaskState,
                                          event::kTaskProgress, event::kSpeedGlobal, event::kNotify,
                                          event::kSettingsChanged, event::kGrabberProgress}}});
            return;
        }
        if (id == kSubscribeId) {
@@ -0,0 +1,33 @@
 // Named semantic colours for the handful of places that set an inline style directly
 // (status dot, offline banner, error labels) rather than through the QSS skin. Lane GUI.
 //
 // docs/agents/AGENT-GUI.md build order step 8: "colours in one variables block... no
 // hard-coded hex scattered through widget code." QSS itself has no variable syntax, so
 // ThemeManager's stylesheets carry their own documented palette block for everything QSS
 // covers; these are the few colours C++ sets directly (a connection-state dot, an error
 // label) because they're driven by application state rather than a widget's style role,
 // and belong here instead of a fourth copy of the same hex string.
 #pragma once
 #include <QString>
 namespace velox::gui::theme {
 // Status-dot / banner colours. Deliberately the same in light and dark — a red "you're
 // disconnected" dot needs to stay legible and unambiguous regardless of theme, not
 // follow it.
 inline constexpr auto kDanger = "#c0392b";   // disconnected, errors
 inline constexpr auto kSuccess = "#27ae60";  // connected
 inline constexpr auto kWarning = "#e67e22";  // reconnecting
 inline constexpr auto kOfflineBannerBg = "#5a3a00";
 inline constexpr auto kOfflineBannerText = "#ffd9a0";
 /// The inline style every dialog's error label already used identically eleven times
 /// over, spelled out once.
 inline QString errorLabelStyle() {
    return QStringLiteral("color: %1;").arg(QLatin1String(kDanger));
 }
 }  // namespace velox::gui::theme
@@ -0,0 +1,42 @@
 #include "util/ThemeManager.hpp"
 #include <QApplication>
 #include <QFile>
 #include <QLoggingCategory>
 #include <QStyleHints>
 namespace velox::gui {
 namespace {
 Q_LOGGING_CATEGORY(lcTheme, "velox.gui.theme")
 QString loadQss(const QString &resourcePath) {
    QFile f(resourcePath);
    if (!f.open(QIODevice::ReadOnly | QIODevice::Text)) {
        qCWarning(lcTheme, "could not load %s", qUtf8Printable(resourcePath));
        return {};
    }
    return QString::fromUtf8(f.readAll());
 }
 }  // namespace
 ThemeManager::ThemeManager(QObject *parent) : QObject(parent) {
    connect(QGuiApplication::styleHints(), &QStyleHints::colorSchemeChanged, this,
            &ThemeManager::onColorSchemeChanged);
 }
 void ThemeManager::apply() {
    const bool dark = QGuiApplication::styleHints()->colorScheme() == Qt::ColorScheme::Dark;
    const QString qss =
        loadQss(dark ? QStringLiteral(":/qss/dark.qss") : QStringLiteral(":/qss/idm-like.qss"));
    if (!qss.isEmpty()) {
        qApp->setStyleSheet(qss);
    }
 }
 void ThemeManager::onColorSchemeChanged() {
    apply();
 }
 }  // namespace velox::gui
@@ -0,0 +1,25 @@
 // Applies gui/resources/qss/{idm-like,dark}.qss and follows the system light/dark
 // preference live. Lane GUI. docs/03-gui-spec.md §7.
 #pragma once
 #include <QObject>
 namespace velox::gui {
 class ThemeManager : public QObject {
    Q_OBJECT
  public:
    explicit ThemeManager(QObject *parent = nullptr);
    /// Loads and applies the stylesheet matching the current
    /// QStyleHints::colorScheme(), and connects to colorSchemeChanged() so a live
    /// light/dark switch (e.g. GNOME's night-light toggle) re-applies without a restart.
    void apply();
  private slots:
    void onColorSchemeChanged();
 };
 }  // namespace velox::gui
@@ -0,0 +1,66 @@
 #include "util/UiThreadWatchdog.hpp"
 #include <chrono>
 #include <QDateTime>
 #include <QLoggingCategory>
 #include <QMetaObject>
 namespace velox::gui {
 namespace {
 Q_LOGGING_CATEGORY(lcWatchdog, "velox.gui.watchdog")
 constexpr int kPollMs = 50;
 constexpr int kStallThresholdMs = 200;
 qint64 nowMs() {
    return QDateTime::currentMSecsSinceEpoch();
 }
 }  // namespace
 UiThreadWatchdog::UiThreadWatchdog(QObject *parent) : QObject(parent) {}
 UiThreadWatchdog::~UiThreadWatchdog() {
    running_.store(false);
    if (worker_.joinable()) {
        worker_.join();
    }
 }
 void UiThreadWatchdog::start() {
 #ifdef QT_NO_DEBUG
    return;  // release build: no thread, no overhead
 #endif
    running_.store(true);
    worker_ = std::thread([this] { loop(); });
 }
 void UiThreadWatchdog::loop() {
    while (running_.load()) {
        std::this_thread::sleep_for(std::chrono::milliseconds(kPollMs));
        if (pingInFlight_.load()) {
            const qint64 elapsed = nowMs() - pingSentAtMs_.load();
            if (elapsed >= kStallThresholdMs && !stalledAlready_.exchange(true)) {
                qCWarning(lcWatchdog,
                          "UI thread has not answered a ping in %lld ms (budget %d ms) — "
                          "something is blocking it",
                          static_cast<long long>(elapsed), kStallThresholdMs);
            }
            continue;  // don't pile up a second ping while one is still outstanding
        }
        stalledAlready_.store(false);
        pingSentAtMs_.store(nowMs());
        pingInFlight_.store(true);
        QMetaObject::invokeMethod(this, "ackFromUiThread", Qt::QueuedConnection);
    }
 }
 void UiThreadWatchdog::ackFromUiThread() {
    pingInFlight_.store(false);
 }
 }  // namespace velox::gui
@@ -0,0 +1,48 @@
 // Debug-build UI-thread watchdog. Lane GUI.
 //
 // docs/agents/AGENT-GUI.md M1 DoD: "No blocking call on the UI thread: verified with a
 // 200 ms watchdog in debug builds." A background std::thread pings the UI thread every
 // 50 ms via a queued QMetaObject::invokeMethod and checks the previous ping actually got
 // answered within 200 ms; if not, it logs once (not once per poll — a real stall can last
 // seconds, and re-warning every 50 ms of it says nothing new). No Qt event loop, no
 // QThread subclass: the only cross-thread contact is the queued invoke itself and three
 // atomics, so the watchdog itself can never be what blocks the thread it's watching.
 //
 // No-op in a release build (`start()` returns immediately when QT_NO_DEBUG is defined) —
 // this is a diagnostic, not a feature; it must add zero overhead to what ships.
 #pragma once
 #include <QObject>
 #include <atomic>
 #include <thread>
 namespace velox::gui {
 class UiThreadWatchdog : public QObject {
    Q_OBJECT
  public:
    explicit UiThreadWatchdog(QObject *parent = nullptr);
    ~UiThreadWatchdog() override;
    /// Call once, from the UI thread, after the event loop exists (i.e. anywhere in
    /// main() before QApplication::exec()). No-op in a release build.
    void start();
  public slots:
    /// Queued-invoked onto the UI thread by the watchdog's own background thread. Not
    /// meant to be called directly.
    void ackFromUiThread();
  private:
    void loop();
    std::thread worker_;
    std::atomic<bool> running_{false};
    std::atomic<bool> pingInFlight_{false};
    std::atomic<bool> stalledAlready_{false};
    std::atomic<qint64> pingSentAtMs_{0};
 };
 }  // namespace velox::gui
@@ -0,0 +1,140 @@
 #include "widgets/DropTargetWidget.hpp"
 #include <QCloseEvent>
 #include <QContextMenuEvent>
 #include <QDragEnterEvent>
 #include <QDropEvent>
 #include <QGuiApplication>
 #include <QMenu>
 #include <QMimeData>
 #include <QMouseEvent>
 #include <QPainter>
 #include <QScreen>
 #include <QSettings>
 #include <QUrl>
 namespace velox::gui {
 namespace {
 constexpr int kSize = 56;
 }  // namespace
 DropTargetWidget::DropTargetWidget(QWidget *parent) : QWidget(parent) {
    setWindowFlags(Qt::FramelessWindowHint | Qt::WindowStaysOnTopHint | Qt::Tool);
    setAttribute(Qt::WA_TranslucentBackground);
    setAcceptDrops(true);
    setFixedSize(kSize, kSize);
    setToolTip(tr("Drop a link here to download it with Velox"));
    setMouseTracking(true);
    restorePosition();
 }
 void DropTargetWidget::restorePosition() {
    QSettings settings;
    const QVariant saved = settings.value(QStringLiteral("dropTarget/pos"));
    if (saved.canConvert<QPoint>()) {
        move(saved.toPoint());
        return;
    }
    // First run: bottom-right corner of the primary screen, inset from the edge — IDM's
    // own default corner.
    if (const QScreen *screen = QGuiApplication::primaryScreen()) {
        const QRect avail = screen->availableGeometry();
        move(avail.right() - kSize - 24, avail.bottom() - kSize - 24);
    }
 }
 void DropTargetWidget::savePosition() {
    QSettings settings;
    settings.setValue(QStringLiteral("dropTarget/pos"), pos());
 }
 void DropTargetWidget::closeEvent(QCloseEvent *event) {
    savePosition();
    QWidget::closeEvent(event);
 }
 void DropTargetWidget::paintEvent(QPaintEvent * /*event*/) {
    QPainter p(this);
    p.setRenderHint(QPainter::Antialiasing);
    QColor fill = palette().highlight().color();
    fill.setAlpha(hovered_ ? 220 : 170);
    p.setBrush(fill);
    p.setPen(Qt::NoPen);
    p.drawEllipse(rect().adjusted(2, 2, -2, -2));
    p.setPen(QPen(palette().highlightedText().color(), 2));
    const QRectF arrow = rect().adjusted(kSize / 3, kSize / 4, -kSize / 3, -kSize / 3);
    p.drawLine(QPointF(arrow.center().x(), arrow.top()),
               QPointF(arrow.center().x(), arrow.bottom()));
    p.drawLine(QPointF(arrow.center().x(), arrow.bottom()),
               QPointF(arrow.left(), arrow.center().y()));
    p.drawLine(QPointF(arrow.center().x(), arrow.bottom()),
               QPointF(arrow.right(), arrow.center().y()));
 }
 QString DropTargetWidget::firstUrlFrom(const QMimeData *mime) {
    if (mime->hasUrls()) {
        for (const QUrl &u : mime->urls()) {
            if (u.scheme() == QLatin1String("http") || u.scheme() == QLatin1String("https")) {
                return u.toString();
            }
        }
    }
    if (mime->hasText()) {
        const QUrl u(mime->text().trimmed());
        if (u.isValid() &&
            (u.scheme() == QLatin1String("http") || u.scheme() == QLatin1String("https"))) {
            return u.toString();
        }
    }
    return {};
 }
 void DropTargetWidget::dragEnterEvent(QDragEnterEvent *event) {
    if (!firstUrlFrom(event->mimeData()).isEmpty()) {
        event->acceptProposedAction();
        hovered_ = true;
        update();
    }
 }
 void DropTargetWidget::dropEvent(QDropEvent *event) {
    hovered_ = false;
    update();
    const QString url = firstUrlFrom(event->mimeData());
    if (!url.isEmpty()) {
        event->acceptProposedAction();
        emit urlDropped(url);
    }
 }
 void DropTargetWidget::mousePressEvent(QMouseEvent *event) {
    if (event->button() == Qt::LeftButton) {
        dragging_ = true;
        dragStartOffset_ = event->pos();
    }
 }
 void DropTargetWidget::mouseMoveEvent(QMouseEvent *event) {
    if (dragging_) {
        move(event->globalPosition().toPoint() - dragStartOffset_);
    }
 }
 void DropTargetWidget::mouseReleaseEvent(QMouseEvent *event) {
    if (event->button() == Qt::LeftButton && dragging_) {
        dragging_ = false;
        savePosition();
    }
 }
 void DropTargetWidget::contextMenuEvent(QContextMenuEvent *event) {
    QMenu menu(this);
    menu.addAction(tr("Add URL…"), this, &DropTargetWidget::addUrlRequested);
    menu.addSeparator();
    menu.addAction(tr("Hide"), this, &QWidget::close);
    menu.exec(event->globalPos());
 }
 }  // namespace velox::gui
@@ -0,0 +1,50 @@
 // The floating drop target. Lane GUI.
 //
 // docs/03-gui-spec.md §5: "frameless always-on-top QWidget, accepts dropped links,
 // right-click menu, position remembered. IDM's drop box, minus the branding." Shown only
 // when general.showDropTarget is on (MainWindow owns fetching that setting and toggling
 // this widget's visibility, same as it already does for general.minimizeToTray).
 #pragma once
 #include <QPoint>
 #include <QWidget>
 class QMimeData;
 namespace velox::gui {
 class DropTargetWidget : public QWidget {
    Q_OBJECT
  public:
    explicit DropTargetWidget(QWidget *parent = nullptr);
  signals:
    /// A URL was dropped (from a link, or from plain text that parses as one). The
    /// receiver decides what "add a download" means — same contract as AddUrlDialog's
    /// accepted URL, just skipping the dialog since this one already has the URL.
    void urlDropped(const QString &url);
    void addUrlRequested();  // right-click menu's explicit "Add URL…" entry
  protected:
    void paintEvent(QPaintEvent *event) override;
    void dragEnterEvent(QDragEnterEvent *event) override;
    void dropEvent(QDropEvent *event) override;
    void mousePressEvent(QMouseEvent *event) override;
    void mouseMoveEvent(QMouseEvent *event) override;
    void mouseReleaseEvent(QMouseEvent *event) override;
    void contextMenuEvent(QContextMenuEvent *event) override;
    void closeEvent(QCloseEvent *event) override;
  private:
    void restorePosition();
    void savePosition();
    static QString firstUrlFrom(const QMimeData *mime);
    bool dragging_ = false;
    QPoint dragStartOffset_;
    bool hovered_ = false;
 };
 }  // namespace velox::gui
@@ -82,12 +82,14 @@ set_tests_properties(gui_fileinfodialog PROPERTIES
    LABELS "gui"
    ENVIRONMENT "QT_QPA_PLATFORM=offscreen")
-# tst_optionsdialog — OptionsDialog::diffChanged, the "only send what changed" logic.
+# tst_optionsdialog — OptionsDialog::diffChanged, the "only send what changed" logic, and
-#   Red when an unchanged key gets resent, or a key missing from `original` stops
+# allKeys() against the real schema.
-#   counting as changed.
+#   Red when an unchanged key gets resent, a key missing from `original` stops counting
 #   as changed, or allKeys() drifts from Settings.schema.json in either direction.
 add_executable(tst_optionsdialog tst_optionsdialog.cpp)
 target_compile_features(tst_optionsdialog PRIVATE cxx_std_23)
 target_compile_options(tst_optionsdialog PRIVATE -Wall -Wextra -Wpedantic -Werror)
 target_compile_definitions(tst_optionsdialog PRIVATE VELOX_REPO_ROOT="${CMAKE_SOURCE_DIR}")
 target_link_libraries(tst_optionsdialog PRIVATE velox-gui-lib Qt6::Widgets Qt6::Test)
 add_test(NAME gui_optionsdialog COMMAND tst_optionsdialog)
 set_tests_properties(gui_optionsdialog PROPERTIES
@@ -144,6 +146,21 @@ set_tests_properties(gui_grabberwizard PROPERTIES
    LABELS "gui"
    ENVIRONMENT "QT_QPA_PLATFORM=offscreen")
 # tst_uithreadwatchdog — the 200 ms debug-build UI-thread watchdog.
 #   Red when a genuinely blocked UI thread (synchronous sleep, no processEvents) stops
 #   producing a warning, or a responsive one starts producing a false-positive one.
 add_executable(tst_uithreadwatchdog tst_uithreadwatchdog.cpp)
 target_compile_features(tst_uithreadwatchdog PRIVATE cxx_std_23)
 target_compile_options(tst_uithreadwatchdog PRIVATE -Wall -Wextra -Wpedantic -Werror)
 target_link_libraries(tst_uithreadwatchdog PRIVATE velox-gui-lib Qt6::Widgets Qt6::Test)
 add_test(NAME gui_uithreadwatchdog COMMAND tst_uithreadwatchdog)
 set_tests_properties(gui_uithreadwatchdog PROPERTIES
    LABELS "gui"
    ENVIRONMENT "QT_QPA_PLATFORM=offscreen")
 # gui-dod-harness — the M1 DoD gates (scroll-60fps / rss-flat / unhappy-path).
 add_subdirectory(dod)
 # gui_no_download_logic — CLAUDE.md §3 as an executable check, not a hope.
 #   Red when: a download-logic token (curl, raw pwrite, sqlite, QSqlDatabase) appears
 #   under gui/src. grep exits 0 only when it finds a match, so a hit fails the test.
@@ -0,0 +1,11 @@
 # gui-dod-harness — the GUI M1 DoD gates. Lane GUI.
 #
 # Not a ctest target: run.sh invokes this directly against a mockd it starts and
 # tears down itself (gui/docs/pkg-qa-requests-m1.md R3). Built under the same
 # VELOX_BUILD_TESTS gate as the rest of gui/tests since it only ever runs in CI/dev, never
 # ships.
 add_executable(gui-dod-harness dod_harness.cpp)
 target_compile_features(gui-dod-harness PRIVATE cxx_std_23)
 target_compile_options(gui-dod-harness PRIVATE -Wall -Wextra -Wpedantic -Werror)
 target_link_libraries(gui-dod-harness PRIVATE velox-gui-lib Qt6::Widgets)
@@ -0,0 +1,416 @@
 // GUI M1 DoD gate harness. Lane GUI.
 //
 // gui/docs/pkg-qa-requests-m1.md R3 / tests/integration/README.md: PKG/QA's CI job
 // invokes this (via run.sh) as `<gate> --sock <path> [--json <path>]`, one gate per run:
 //
 //   scroll-60fps  — mockd --tasks 10000, a scripted scroll over the whole table; fail on
 //                   a p99 per-step paint time over budget (16.6 ms, i.e. 60 fps).
 //   rss-flat      — mockd --tasks 10000 streaming progress for --duration-sec (default
 //                   600 = 10 min); fail if RSS grows past a fixed slack after warm-up.
 //   unhappy-path  — one phase (--phase slow|flaky|drop-connection, label only: the actual
 //                   mockd flag is run.sh's job) against a client that must reach
 //                   Connected and hold it, no crash, no hang.
 //
 // Exit 0 pass, non-zero fail. --json <path> writes one result object. A watchdog timer
 // converts a hang into a non-zero exit itself — nothing here should ever need an external
 // timeout(1) to end it.
 //
 // "Fling scroll" and "frame" are approximate in a headless/offscreen run: there is no
 // compositor to hand a real frame to, so what is measured is wall-clock time for one
 // scroll step's model-driven repaint — the CPU cost a real frame would also have to pay,
 // just without a GPU present/vsync on top of it. That is the part a progress-patch
 // regression or a delegate doing needless work would actually blow.
 #include <algorithm>
 #include <cmath>
 #include <cstdio>
 #include <functional>
 #include <numeric>
 #include <vector>
 #include <QApplication>
 #include <QCommandLineParser>
 #include <QElapsedTimer>
 #include <QEventLoop>
 #include <QFile>
 #include <QJsonArray>
 #include <QJsonDocument>
 #include <QJsonObject>
 #include <QRegularExpression>
 #include <QScrollBar>
 #include <QTimer>
 #include <QTreeView>
 #include "models/DownloadTableModel.hpp"
 #include "rpc/RpcClient.hpp"
 #include "widgets/ProgressDelegate.hpp"
 using velox::gui::DownloadTableModel;
 using velox::gui::ProgressDelegate;
 namespace rpc = velox::gui::rpc;
 namespace {
 // Pumps the event loop in small slices until `pred` is true or `timeoutMs` elapses.
 // Never blocks longer than that — every wait in this file is bounded, which is what lets
 // the process reach its own exit(1) instead of needing the watchdog for the common case.
 bool waitFor(const std::function<bool()> &pred, int timeoutMs) {
    QElapsedTimer t;
    t.start();
    while (!pred() && t.elapsed() < timeoutMs) {
        QCoreApplication::processEvents(QEventLoop::AllEvents, 20);
    }
    return pred();
 }
 qint64 readRssKiB() {
    QFile f(QStringLiteral("/proc/self/status"));
    if (!f.open(QIODevice::ReadOnly | QIODevice::Text)) {
        return -1;
    }
    static const QRegularExpression kWs(QStringLiteral("\\s+"));
    for (const QByteArray &lineBytes : f.readAll().split('\n')) {
        const QString line = QString::fromLatin1(lineBytes);
        if (line.startsWith(QLatin1String("VmRSS:"))) {
            const QStringList parts = line.split(kWs, Qt::SkipEmptyParts);
            if (parts.size() >= 2) {
                bool ok = false;
                const qint64 kib = parts[1].toLongLong(&ok);
                return ok ? kib : -1;
            }
        }
    }
    return -1;
 }
 double percentile(std::vector<double> v, double p) {
    if (v.empty()) {
        return 0.0;
    }
    std::sort(v.begin(), v.end());
    int idx = static_cast<int>(std::ceil(p * static_cast<double>(v.size()))) - 1;
    idx = std::clamp(idx, 0, static_cast<int>(v.size()) - 1);
    return v[static_cast<std::size_t>(idx)];
 }
 // ASan/UBSan add real overhead to every paint; the pre-drafted CI job builds this with
 // `cmake --preset dev`, which is ASan+UBSan by default (CLAUDE.md: "default for all
 // lanes"). Scaling the budget under a sanitized build is an honest adjustment for
 // instrumentation cost, not a loosened bar — VELOX_DOD_FRAME_BUDGET_MS still overrides it
 // outright for whoever wants to tune this per-runner.
 bool isSanitizedBuild() {
 #if defined(__SANITIZE_ADDRESS__) || defined(__SANITIZE_THREAD__)
    return true;
 #elif defined(__has_feature)
 #if __has_feature(address_sanitizer) || __has_feature(thread_sanitizer)
    return true;
 #else
    return false;
 #endif
 #else
    return false;
 #endif
 }
 void writeJson(const QString &path, const QJsonObject &obj) {
    if (path.isEmpty()) {
        return;
    }
    QFile f(path);
    if (!f.open(QIODevice::WriteOnly | QIODevice::Truncate | QIODevice::Text)) {
        std::fprintf(stderr, "warning: could not write --json output to %s\n",
                     qUtf8Printable(path));
        return;
    }
    f.write(QJsonDocument(obj).toJson(QJsonDocument::Indented));
 }
 void wireModel(rpc::RpcClient *client, DownloadTableModel *model) {
    QObject::connect(client, &rpc::RpcClient::taskListReset, model,
                     &DownloadTableModel::resetFromJson);
    QObject::connect(client, &rpc::RpcClient::taskProgress, model,
                     &DownloadTableModel::applyProgress);
    QObject::connect(client, &rpc::RpcClient::taskAdded, model,
                     &DownloadTableModel::applyTaskAdded);
    QObject::connect(client, &rpc::RpcClient::taskStateChanged, model,
                     &DownloadTableModel::applyTaskState);
    QObject::connect(client, &rpc::RpcClient::taskRemoved, model,
                     &DownloadTableModel::applyTaskRemoved);
 }
 int runScroll60Fps(rpc::RpcClient &client, const QString &jsonPath) {
    DownloadTableModel model;
    wireModel(&client, &model);
    if (!waitFor([&] { return client.state() == rpc::ConnectionState::Connected; }, 15000)) {
        std::fprintf(stderr, "FAIL: never reached Connected\n");
        return 1;
    }
    if (!waitFor([&] { return model.rowCount() >= 9000; }, 15000)) {
        std::fprintf(stderr,
                     "FAIL: table never loaded (rowCount=%d) — run mockd with "
                     "--tasks 10000\n",
                     model.rowCount());
        return 1;
    }
    QTreeView view;
    view.setModel(&model);
    view.setUniformRowHeights(true);
    view.setItemDelegateForColumn(DownloadTableModel::ColStatus, new ProgressDelegate(&view));
    view.resize(1000, 700);
    view.show();
    waitFor([] { return false; }, 100);  // let the initial show/layout settle
    auto *bar = view.verticalScrollBar();
    const int maxV = bar->maximum();
    if (maxV <= 0) {
        std::fprintf(stderr, "FAIL: nothing to scroll (scrollbar max=%d)\n", maxV);
        return 1;
    }
    // A scripted "fling": ease-out steps (big jumps first, settling to small ones), the
    // shape a real flick-scroll decelerates through, rather than a uniform crawl.
    constexpr int kSteps = 240;
    std::vector<double> frameMs;
    frameMs.reserve(kSteps);
    for (int i = 1; i <= kSteps; ++i) {
        const double t = static_cast<double>(i) / kSteps;
        const double eased = 1.0 - std::pow(1.0 - t, 3.0);
        const int value = static_cast<int>(static_cast<double>(maxV) * eased);
        QElapsedTimer frame;
        frame.start();
        bar->setValue(value);
        QCoreApplication::sendPostedEvents();
        view.viewport()->repaint();  // synchronous: times the paint, not just the request
        frameMs.push_back(static_cast<double>(frame.nsecsElapsed()) / 1e6);
    }
    const double p99 = percentile(frameMs, 0.99);
    const double maxMs = *std::max_element(frameMs.begin(), frameMs.end());
    const double meanMs =
        std::accumulate(frameMs.begin(), frameMs.end(), 0.0) / static_cast<double>(frameMs.size());
    double budgetMs = 16.6;
    if (isSanitizedBuild()) {
        budgetMs *= 4.0;  // instrumentation overhead, not a lowered bar — see isSanitizedBuild()
    }
    const QString override = qEnvironmentVariable("VELOX_DOD_FRAME_BUDGET_MS");
    if (!override.isEmpty()) {
        bool ok = false;
        const double v = override.toDouble(&ok);
        if (ok) {
            budgetMs = v;
        }
    }
    const bool pass = p99 <= budgetMs;
    std::printf("%s: p99=%.2f ms mean=%.2f ms max=%.2f ms budget=%.2f ms over %d steps, %d rows\n",
                pass ? "PASS" : "FAIL", p99, meanMs, maxMs, budgetMs, kSteps, model.rowCount());
    writeJson(jsonPath, QJsonObject{
                            {"gate", "scroll-60fps"},
                            {"rows", model.rowCount()},
                            {"steps", kSteps},
                            {"p99Ms", p99},
                            {"meanMs", meanMs},
                            {"maxMs", maxMs},
                            {"budgetMs", budgetMs},
                            {"sanitized", isSanitizedBuild()},
                            {"pass", pass},
                        });
    return pass ? 0 : 1;
 }
 int runRssFlat(rpc::RpcClient &client, const QString &jsonPath, int durationSec) {
    DownloadTableModel model;
    wireModel(&client, &model);
    if (!waitFor([&] { return client.state() == rpc::ConnectionState::Connected; }, 15000)) {
        std::fprintf(stderr, "FAIL: never reached Connected\n");
        return 1;
    }
    if (!waitFor([&] { return model.rowCount() >= 9000; }, 15000)) {
        std::fprintf(stderr,
                     "FAIL: table never loaded (rowCount=%d) — run mockd with "
                     "--tasks 10000\n",
                     model.rowCount());
        return 1;
    }
    // Kept visible: a hidden model-only run would miss any leak that lives in painting
    // (delegate scratch state, style caches) rather than in the model's own row patches.
    QTreeView view;
    view.setModel(&model);
    view.setUniformRowHeights(true);
    view.setItemDelegateForColumn(DownloadTableModel::ColStatus, new ProgressDelegate(&view));
    view.resize(1000, 700);
    view.show();
    const int warmupSec = std::min(30, std::max(1, durationSec / 10));
    QJsonArray series;
    std::vector<qint64> afterWarmup;
    QEventLoop loop;
    QTimer sampler;
    sampler.setInterval(1000);
    int elapsedSec = 0;
    QObject::connect(&sampler, &QTimer::timeout, [&] {
        ++elapsedSec;
        const qint64 rssKiB = readRssKiB();
        series.append(QJsonObject{{"t", elapsedSec}, {"rssKiB", rssKiB}});
        if (elapsedSec > warmupSec) {
            afterWarmup.push_back(rssKiB);
        }
        if (elapsedSec >= durationSec) {
            loop.quit();
        }
    });
    sampler.start();
    loop.exec();
    qint64 growthKiB = 0;
    if (afterWarmup.size() >= 2) {
        const qint64 minRss = *std::min_element(afterWarmup.begin(), afterWarmup.end());
        growthKiB = afterWarmup.back() - minRss;
    }
    qint64 slackKiB = 20 * 1024;  // 20 MiB: see gui/docs/pkg-qa-requests-m1.md R3 for why
    const QString override = qEnvironmentVariable("VELOX_DOD_RSS_SLACK_KIB");
    if (!override.isEmpty()) {
        bool ok = false;
        const qint64 v = override.toLongLong(&ok);
        if (ok) {
            slackKiB = v;
        }
    }
    const bool pass = afterWarmup.size() >= 2 && growthKiB <= slackKiB;
    std::printf("%s: growth=%lld KiB slack=%lld KiB over %ds (warmup %ds), %d rows\n",
                pass ? "PASS" : "FAIL", static_cast<long long>(growthKiB),
                static_cast<long long>(slackKiB), durationSec, warmupSec, model.rowCount());
    writeJson(jsonPath, QJsonObject{
                            {"gate", "rss-flat"},
                            {"rows", model.rowCount()},
                            {"durationSec", durationSec},
                            {"warmupSec", warmupSec},
                            {"growthKiB", growthKiB},
                            {"slackKiB", slackKiB},
                            {"series", series},
                            {"pass", pass},
                        });
    return pass ? 0 : 1;
 }
 int runUnhappyPath(rpc::RpcClient &client, const QString &jsonPath, const QString &phase) {
    bool sawDisconnectOrReconnecting = false;
    QObject::connect(&client, &rpc::RpcClient::stateChanged, &client, [&](rpc::ConnectionState s) {
        if (s == rpc::ConnectionState::Reconnecting || s == rpc::ConnectionState::Disconnected) {
            sawDisconnectOrReconnecting = true;
        }
    });
    // 45 s covers mockd's slowest documented --slow value plus a couple of backoff
    // cycles; the harness's own watchdog (see main()) is the real ceiling on a hang.
    constexpr int kObserveMs = 45000;
    const bool reachedConnected =
        waitFor([&] { return client.state() == rpc::ConnectionState::Connected; }, kObserveMs);
    QElapsedTimer t;
    t.start();
    while (t.elapsed() < kObserveMs) {
        QCoreApplication::processEvents(QEventLoop::AllEvents, 50);
    }
    const bool finalConnected = client.state() == rpc::ConnectionState::Connected;
    const bool pass = reachedConnected && finalConnected;
    std::printf("%s [%s]: reachedConnected=%d finalConnected=%d sawDisruption=%d\n",
                pass ? "PASS" : "FAIL", qUtf8Printable(phase), reachedConnected, finalConnected,
                sawDisconnectOrReconnecting);
    writeJson(jsonPath, QJsonObject{
                            {"gate", "unhappy-path"},
                            {"phase", phase},
                            {"reachedConnected", reachedConnected},
                            {"finalConnected", finalConnected},
                            {"sawDisruption", sawDisconnectOrReconnecting},
                            {"pass", pass},
                        });
    return pass ? 0 : 1;
 }
 }  // namespace
 int main(int argc, char **argv) {
    QApplication app(argc, argv);
    qRegisterMetaType<rpc::ConnectionState>();
    qRegisterMetaType<rpc::RpcReply>();
    QCommandLineParser parser;
    parser.setApplicationDescription(
        QStringLiteral("GUI M1 DoD gate harness (gui/docs/pkg-qa-requests-m1.md R3)"));
    parser.addHelpOption();
    parser.addPositionalArgument(QStringLiteral("gate"),
                                 QStringLiteral("scroll-60fps | rss-flat | unhappy-path"));
    QCommandLineOption sockOpt(QStringLiteral("sock"), QStringLiteral("veloxd UDS socket path"),
                               QStringLiteral("path"));
    QCommandLineOption jsonOpt(QStringLiteral("json"),
                               QStringLiteral("write one result object here"),
                               QStringLiteral("path"));
    QCommandLineOption durationOpt(QStringLiteral("duration-sec"),
                                   QStringLiteral("rss-flat duration override (default 600)"),
                                   QStringLiteral("sec"));
    QCommandLineOption phaseOpt(QStringLiteral("phase"),
                                QStringLiteral("unhappy-path sub-phase label, for the JSON only"),
                                QStringLiteral("phase"), QStringLiteral("unspecified"));
    parser.addOption(sockOpt);
    parser.addOption(jsonOpt);
    parser.addOption(durationOpt);
    parser.addOption(phaseOpt);
    parser.process(app);
    const QStringList pos = parser.positionalArguments();
    if (pos.isEmpty() || !parser.isSet(sockOpt)) {
        std::fprintf(stderr,
                     "usage: dod_harness <gate> --sock <path> [--json <path>] "
                     "[--duration-sec <n>] [--phase <label>]\n");
        return 2;
    }
    const QString gate = pos.first();
    const int durationSec = parser.isSet(durationOpt) ? parser.value(durationOpt).toInt() : 600;
    rpc::RpcClient client(parser.value(sockOpt));
    client.start();
    // The harness's own watchdog: whatever gate is running, it must exit on its own by
    // this ceiling. Firing is itself a failure (a hang), not a signal for the caller to
    // timeout(1) around — see the file comment.
    int watchdogSec = 120;
    if (gate == QLatin1String("rss-flat")) {
        watchdogSec = durationSec + 90;
    } else if (gate == QLatin1String("unhappy-path")) {
        watchdogSec = 75;
    }
    QTimer watchdog;
    watchdog.setSingleShot(true);
    QObject::connect(&watchdog, &QTimer::timeout, [watchdogSec] {
        std::fprintf(stderr, "FAIL: dod_harness watchdog fired — hung past %ds\n", watchdogSec);
        std::exit(3);
    });
    watchdog.start(watchdogSec * 1000);
    int rc = 2;
    if (gate == QLatin1String("scroll-60fps")) {
        rc = runScroll60Fps(client, parser.value(jsonOpt));
    } else if (gate == QLatin1String("rss-flat")) {
        rc = runRssFlat(client, parser.value(jsonOpt), durationSec);
    } else if (gate == QLatin1String("unhappy-path")) {
        rc = runUnhappyPath(client, parser.value(jsonOpt), parser.value(phaseOpt));
    } else {
        std::fprintf(stderr, "unknown gate: %s\n", qUtf8Printable(gate));
    }
    client.stop();
    return rc;
 }
@@ -0,0 +1,197 @@
 #!/usr/bin/env bash
 # GUI M1 DoD gate driver. Lane GUI.
 #
 # gui/docs/pkg-qa-requests-m1.md R3 / tests/integration/README.md's invocation contract:
 #
 #   gui/tests/dod/run.sh <gate> [--json <path>]
 #
 # <gate> is one of: scroll-60fps | rss-flat | unhappy-path
 #
 # Headless-capable: works under offscreen QT_QPA_PLATFORM (the default here) or under
 # Xvfb (xvfb-run -a gui/tests/dod/run.sh ...) if DISPLAY is already set. Exit 0 pass,
 # non-zero fail. Spawns and tears down its own mockd; no network, no writes outside a
 # tempdir except the caller's --json path; never leaves a child process running, on
 # either exit path (see cleanup() / the EXIT trap).
 #
 # Env overrides, for local iteration — CI's real run uses none of these:
 #   VELOX_BUILD_DIR             build directory holding bin/gui-dod-harness (default: the
 #                                first of build/ci, build/dev that has the binary)
 #   VELOX_DOD_RSS_DURATION_SEC  shorten the 10-minute rss-flat soak
 #   VELOX_DOD_FRAME_BUDGET_MS   override the scroll-60fps per-step budget (default 16.6,
 #                                x4 under a sanitized build — see dod_harness.cpp)
 #   VELOX_DOD_RSS_SLACK_KIB     override the rss-flat growth slack (default 20*1024)
 set -u -o pipefail
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_ROOT="$(cd "$SCRIPT_DIR/../../.." && pwd)"
 MOCKD_DIR="$REPO_ROOT/tools/mockd"
 usage() {
    echo "usage: $0 <scroll-60fps|rss-flat|unhappy-path> [--json <path>]" >&2
    exit 2
 }
 GATE="${1:-}"
 [ -n "$GATE" ] || usage
 shift || true
 JSON_PATH=""
 while [ $# -gt 0 ]; do
    case "$1" in
        --json) JSON_PATH="$2"; shift 2 ;;
        *) echo "unknown argument: $1" >&2; usage ;;
    esac
 done
 case "$GATE" in
    scroll-60fps|rss-flat|unhappy-path) ;;
    *) usage ;;
 esac
 # --- locate the harness binary -----------------------------------------------------------
 HARNESS=""
 for d in "${VELOX_BUILD_DIR:-}" "$REPO_ROOT/build/ci" "$REPO_ROOT/build/dev"; do
    [ -n "$d" ] || continue
    if [ -x "$d/bin/gui-dod-harness" ]; then
        HARNESS="$d/bin/gui-dod-harness"
        break
    fi
 done
 if [ -z "$HARNESS" ]; then
    echo "FAIL: gui-dod-harness not found. Build it first:" >&2
    echo "  cmake --preset dev && cmake --build --preset dev --target gui-dod-harness" >&2
    exit 2
 fi
 # --- locate mockd's runner ----------------------------------------------------------------
 MOCKD_RUNNER=""
 if [ -x "$MOCKD_DIR/node_modules/.bin/tsx" ]; then
    MOCKD_RUNNER=("$MOCKD_DIR/node_modules/.bin/tsx" "$MOCKD_DIR/src/index.ts")
 elif command -v npx >/dev/null 2>&1; then
    MOCKD_RUNNER=(npx --prefix "$MOCKD_DIR" tsx "$MOCKD_DIR/src/index.ts")
 else
    echo "FAIL: no tsx runner for mockd found. Run: (cd tools/mockd && npm ci)" >&2
    exit 2
 fi
 : "${QT_QPA_PLATFORM:=offscreen}"
 export QT_QPA_PLATFORM
 # --- isolated runtime dir, and the socket mockd/the harness will use -----------------------
 WORKDIR="$(mktemp -d "${TMPDIR:-/tmp}/velox-gui-dod.XXXXXX")"
 export XDG_RUNTIME_DIR="$WORKDIR/xdg"
 mkdir -p "$XDG_RUNTIME_DIR/velox"
 SOCK="$XDG_RUNTIME_DIR/velox/velox.sock"
 MOCKD_PID=""
 cleanup() {
    if [ -n "$MOCKD_PID" ] && kill -0 "$MOCKD_PID" 2>/dev/null; then
        kill "$MOCKD_PID" 2>/dev/null
        wait "$MOCKD_PID" 2>/dev/null
    fi
    rm -rf "$WORKDIR"
 }
 trap cleanup EXIT INT TERM
 start_mockd() {
    # "$@" are extra mockd flags for this phase.
    rm -f "$SOCK"
    ( cd "$MOCKD_DIR" && exec "${MOCKD_RUNNER[@]}" --no-ws "$@" ) \
        >"$WORKDIR/mockd.log" 2>&1 &
    MOCKD_PID=$!
    local waited=0
    while [ ! -S "$SOCK" ]; do
        if ! kill -0 "$MOCKD_PID" 2>/dev/null; then
            echo "FAIL: mockd exited before listening. Log:" >&2
            cat "$WORKDIR/mockd.log" >&2
            return 1
        fi
        sleep 0.2
        waited=$((waited + 1))
        if [ "$waited" -gt 100 ]; then
            echo "FAIL: mockd never created its socket within 20s" >&2
            return 1
        fi
    done
    return 0
 }
 stop_mockd() {
    if [ -n "$MOCKD_PID" ] && kill -0 "$MOCKD_PID" 2>/dev/null; then
        kill "$MOCKD_PID" 2>/dev/null
        wait "$MOCKD_PID" 2>/dev/null
    fi
    MOCKD_PID=""
 }
 # run_harness <extra harness args...> — belt-and-braces external timeout on top of the
 # harness's own internal watchdog: if the Qt event loop itself ever wedges, its QTimer
 # watchdog can't fire either, and this is what still turns that into a bounded failure
 # instead of a wait forever. Either way this script's own caller never needs timeout(1).
 run_harness() {
    timeout --signal=KILL "$1" "$HARNESS" --sock "$SOCK" "${@:2}"
 }
 JSON_ARGS=()
 [ -n "$JSON_PATH" ] && JSON_ARGS=(--json "$JSON_PATH")
 case "$GATE" in
    scroll-60fps)
        start_mockd --tasks 10000 --seed 1 || exit 1
        run_harness 90 scroll-60fps "${JSON_ARGS[@]}"
        RC=$?
        stop_mockd
        exit "$RC"
        ;;
    rss-flat)
        DURATION="${VELOX_DOD_RSS_DURATION_SEC:-600}"
        start_mockd --tasks 10000 --seed 1 || exit 1
        run_harness "$((DURATION + 120))" rss-flat --duration-sec "$DURATION" "${JSON_ARGS[@]}"
        RC=$?
        stop_mockd
        exit "$RC"
        ;;
    unhappy-path)
        # Three phases, one mockd flag each; every phase must pass. mockd's own README
        # documents these flags (--slow/--flaky/--drop-connection).
        OVERALL_RC=0
        declare -A PHASE_FLAGS=(
            [slow]="--slow 900"
            [flaky]="--flaky 0.3"
            [drop-connection]="--drop-connection 5"
        )
        MERGED="{}"
        for phase in slow flaky drop-connection; do
            # shellcheck disable=SC2206
            flags=(${PHASE_FLAGS[$phase]})
            start_mockd "${flags[@]}" || { OVERALL_RC=1; continue; }
            PHASE_JSON="$WORKDIR/phase-$phase.json"
            run_harness 75 unhappy-path --phase "$phase" --json "$PHASE_JSON"
            RC=$?
            stop_mockd
            [ "$RC" -eq 0 ] || OVERALL_RC=1
            if [ -n "$JSON_PATH" ] && [ -f "$PHASE_JSON" ]; then
                MERGED="$(python3 -c "
 import json, sys
 merged = json.loads(sys.argv[1])
 phase = json.load(open(sys.argv[2]))
 merged.setdefault('gate', 'unhappy-path')
 merged.setdefault('phases', {})
 merged['phases'][sys.argv[3]] = phase
 print(json.dumps(merged))
 " "$MERGED" "$PHASE_JSON" "$phase")"
            fi
        done
        if [ -n "$JSON_PATH" ]; then
            python3 -c "
 import json, sys
 merged = json.loads(sys.argv[1])
 merged['pass'] = sys.argv[2] == '0'
 json.dump(merged, open(sys.argv[3], 'w'), indent=2)
 " "$MERGED" "$OVERALL_RC" "$JSON_PATH"
        fi
        exit "$OVERALL_RC"
        ;;
 esac
@@ -5,6 +5,8 @@
 // effect" contract and spams event.settings.changed with noise), or a key present in
 // `current` but absent from `original` stops being treated as changed.
 #include <QFile>
 #include <QJsonDocument>
 #include <QJsonObject>
 #include <QtTest>
@@ -20,6 +22,7 @@ class TstOptionsDialog : public QObject {
    void onlyChangedKeysAreReturned();
    void keyAbsentFromOriginalCountsAsChanged();
    void allKeysAreNonEmptyAndUnique();
    void allKeysMatchesTheSchemaExactly();
 };
 void TstOptionsDialog::identicalValuesProduceNoDiff() {
@@ -50,5 +53,24 @@ void TstOptionsDialog::allKeysAreNonEmptyAndUnique() {
    QCOMPARE(QSet<QString>(keys.begin(), keys.end()).size(), keys.size());
 }
 // Red when a key is added to (or removed from) Settings.schema.json without the same
 // change landing here — either direction is a real bug: an invented key settings.set
 // would reject with -32602, or a real key the dialog silently never shows.
 void TstOptionsDialog::allKeysMatchesTheSchemaExactly() {
    QFile f(QStringLiteral(VELOX_REPO_ROOT "/contracts/schema/types/Settings.schema.json"));
    QVERIFY2(f.open(QIODevice::ReadOnly), qUtf8Printable(f.errorString()));
    const QJsonObject schema = QJsonDocument::fromJson(f.readAll()).object();
    const QJsonObject properties = schema.value("properties").toObject();
    QVERIFY(!properties.isEmpty());
    QSet<QString> schemaKeys;
    for (auto it = properties.constBegin(); it != properties.constEnd(); ++it) {
        schemaKeys.insert(it.key());
    }
    const QStringList dialogKeysList = OptionsDialog::allKeys();
    const QSet<QString> dialogKeys(dialogKeysList.begin(), dialogKeysList.end());
    QCOMPARE(dialogKeys, schemaKeys);
 }
 QTEST_MAIN(TstOptionsDialog)
 #include "tst_optionsdialog.moc"
@@ -0,0 +1,89 @@
 // UiThreadWatchdog unit tests. Lane GUI.
 //
 // Red when a genuinely blocked UI thread (a synchronous sleep with no processEvents in
 // between — the exact shape of the bug this exists to catch) stops producing a warning,
 // or a responsive one starts producing a false-positive one.
 #include <QMutex>
 #include <QMutexLocker>
 #include <QThread>
 #include <QtTest>
 #include "util/UiThreadWatchdog.hpp"
 using velox::gui::UiThreadWatchdog;
 namespace {
 QMutex g_mutex;
 QString g_lastWarning;
 QtMessageHandler g_prevHandler = nullptr;
 // Qt's own message handler is process-global and can run on any thread — the watchdog's
 // warning comes from its background thread while this test's main thread is deliberately
 // blocked, so this needs real synchronization, not just a plain global (this test runs
 // under the `tsan` preset too).
 void captureHandler(QtMsgType type, const QMessageLogContext &ctx, const QString &msg) {
    if (type == QtWarningMsg) {
        QMutexLocker locker(&g_mutex);
        g_lastWarning = msg;
    }
    if (g_prevHandler) {
        g_prevHandler(type, ctx, msg);
    }
 }
 QString lastWarning() {
    QMutexLocker locker(&g_mutex);
    return g_lastWarning;
 }
 }  // namespace
 class TstUiThreadWatchdog : public QObject {
    Q_OBJECT
  private slots:
    void init();
    void cleanup();
    void firesOnABlockedUiThread();
    void staysQuietWhenResponsive();
 };
 void TstUiThreadWatchdog::init() {
    QMutexLocker locker(&g_mutex);
    g_lastWarning.clear();
    g_prevHandler = qInstallMessageHandler(captureHandler);
 }
 void TstUiThreadWatchdog::cleanup() {
    qInstallMessageHandler(g_prevHandler);
 }
 void TstUiThreadWatchdog::firesOnABlockedUiThread() {
    UiThreadWatchdog wd;
    wd.start();
    // Block this thread (the watchdog's "UI thread" here) synchronously and well past
    // the 200 ms budget — no processEvents at all, exactly what a real stall looks like
    // and exactly what this exists to catch.
    QThread::msleep(500);
    // Let the event loop run so the queued ack the watchdog sent before the sleep started
    // finally lands (harmless — the warning it's checking for already fired mid-sleep,
    // from the watchdog's own background thread).
    QTest::qWait(150);
    QVERIFY2(lastWarning().contains(QStringLiteral("blocking")), qUtf8Printable(lastWarning()));
 }
 void TstUiThreadWatchdog::staysQuietWhenResponsive() {
    UiThreadWatchdog wd;
    wd.start();
    QTest::qWait(400);  // event loop stays responsive throughout — well past the budget
    QVERIFY(lastWarning().isEmpty());
 }
 QTEST_MAIN(TstUiThreadWatchdog)
 #include "tst_uithreadwatchdog.moc"
@@ -1,14 +0,0 @@
 # nmhost/ — velox-nmhost, the Firefox native-messaging host. Owned by lane DAEMON.
 #
 # Deliberately dependency-free: no veloxd_* library, no nlohmann_json, no SQLite. It is a
 # byte-level pump between two framings (see src/main.cpp's own header comment) and runs
 # unconfined outside Firefox's sandbox (ADR 0003) — the less it links, the less there is to
 # go wrong running from wherever a snap/deb/flatpak install puts it.
 add_executable(velox-nmhost src/main.cpp)
 target_compile_features(velox-nmhost PRIVATE cxx_std_23)
 target_compile_options(velox-nmhost PRIVATE -Wall -Wextra -Wpedantic -Werror)
 if(VELOX_BUILD_TESTS AND EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/tests/CMakeLists.txt)
    add_subdirectory(tests)
 endif()
@@ -1,203 +0,0 @@
 // velox-nmhost — Firefox native-messaging host. A dumb pump between two framings, nothing
 // else: stdin/stdout speak Firefox's own protocol (a 4-byte native-byte-order length
 // prefix, then that many bytes of UTF-8 JSON); $XDG_RUNTIME_DIR/velox/velox.sock speaks
 // veloxd's own NDJSON (one '\n'-terminated JSON value per line, daemon/src/rpc/ndjson.hpp).
 // Reframing between the two is the entire job.
 //
 // Runs unconfined outside Firefox's snap sandbox with the real $HOME and
 // $XDG_RUNTIME_DIR (ADR 0003 §Q2) — see packaging/nativehost/ for the manifest this is
 // installed as, and which native-messaging-hosts directory actually gets read by which
 // Firefox flavour.
 //
 // No business logic: no JSON parsing (frames are pure byte spans; only the length prefix
 // and the line boundary matter here), no retry/backoff (the extension re-launches a fresh
 // host on its own reconnect), no protocol version check (veloxd and the extension settle
 // that between themselves once the pump hands their bytes through). Exits the moment
 // either side closes.
 #include <fcntl.h>
 #include <sys/socket.h>
 #include <sys/un.h>
 #include <unistd.h>
 #include <cerrno>
 #include <cstdint>
 #include <cstdlib>
 #include <cstring>
 #include <poll.h>
 #include <string>
 namespace {
 // Firefox's own cap (host -> browser) is 1 MiB; this is just a sanity backstop against a
 // runaway peer so a malformed stream can't grow a buffer without bound.
 constexpr std::size_t kMaxFrameBytes = 8 * 1024 * 1024;
 std::string socket_path() {
    const char* xdg = std::getenv("XDG_RUNTIME_DIR");
    std::string base = (xdg != nullptr && xdg[0] != '\0') ? xdg
                                                          : ("/run/user/" + std::to_string(::getuid()));
    if (!base.empty() && base.back() == '/') base.pop_back();
    return base + "/velox/velox.sock";
 }
 int connect_socket(const std::string& path) {
    const int fd = ::socket(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0);
    if (fd < 0) return -1;
    sockaddr_un addr{};
    addr.sun_family = AF_UNIX;
    if (path.size() + 1 > sizeof(addr.sun_path)) {
        ::close(fd);
        return -1;
    }
    std::memcpy(addr.sun_path, path.c_str(), path.size());
    if (::connect(fd, reinterpret_cast<sockaddr*>(&addr), sizeof(addr)) != 0) {
        ::close(fd);
        return -1;
    }
    return fd;
 }
 // Reads everything currently available into `buf`. true on EOF, false otherwise (short
 // reads / EAGAIN just return with whatever was appended).
 bool read_available(int fd, std::string& buf) {
    char chunk[65536];
    for (;;) {
        const ssize_t n = ::read(fd, chunk, sizeof(chunk));
        if (n > 0) {
            buf.append(chunk, static_cast<std::size_t>(n));
            continue;
        }
        if (n == 0) return true;  // EOF
        if (errno == EAGAIN || errno == EWOULDBLOCK) return false;
        if (errno == EINTR) continue;
        return true;  // treat any other error as if the peer hung up
    }
 }
 // Writes as much of `buf` as the fd accepts right now, trimming what was sent. Returns
 // false on a hard error (peer gone); EAGAIN is not an error, just "try again later".
 bool flush_some(int fd, std::string& buf) {
    while (!buf.empty()) {
        const ssize_t n = ::write(fd, buf.data(), buf.size());
        if (n > 0) {
            buf.erase(0, static_cast<std::size_t>(n));
            continue;
        }
        if (n < 0 && (errno == EAGAIN || errno == EWOULDBLOCK)) return true;
        if (n < 0 && errno == EINTR) continue;
        return false;
    }
    return true;
 }
 // stdin frames (4-byte length + payload) -> NDJSON lines appended to `to_socket`.
 // Malformed (oversized) length is a hard stop.
 bool drain_stdin_frames(std::string& in, std::string& to_socket) {
    for (;;) {
        if (in.size() < 4) return true;
        std::uint32_t len;
        std::memcpy(&len, in.data(), 4);
        if (len > kMaxFrameBytes) return false;
        if (in.size() < 4 + len) return true;
        to_socket.append(in, 4, len);
        to_socket.push_back('\n');
        in.erase(0, 4 + len);
    }
 }
 // NDJSON lines from the socket -> stdout frames (4-byte length + payload) appended to
 // `to_stdout`.
 bool drain_socket_lines(std::string& in, std::string& to_stdout) {
    for (;;) {
        const auto nl = in.find('\n');
        if (nl == std::string::npos) {
            if (in.size() > kMaxFrameBytes) return false;
            return true;
        }
        std::string_view line(in.data(), nl);
        if (!line.empty() && line.back() == '\r') line.remove_suffix(1);
        if (line.size() > kMaxFrameBytes) return false;
        const auto len = static_cast<std::uint32_t>(line.size());
        to_stdout.append(reinterpret_cast<const char*>(&len), 4);
        to_stdout.append(line);
        in.erase(0, nl + 1);
    }
 }
 }  // namespace
 int main() {
    const int sock = connect_socket(socket_path());
    if (sock < 0) return 1;  // daemon not running / socket missing: nothing to pump
    // Every fd this pumps must be non-blocking: read_available()'s own drain loop keeps
    // calling read() until it actually sees EAGAIN, and a blocking fd never returns that —
    // it just blocks inside the "drain what's available" loop instead of going back to
    // poll(), which stalls the whole pump the moment one side has more to send than fits
    // in a single read().
    ::fcntl(0, F_SETFL, ::fcntl(0, F_GETFL) | O_NONBLOCK);
    ::fcntl(1, F_SETFL, ::fcntl(1, F_GETFL) | O_NONBLOCK);
    ::fcntl(sock, F_SETFL, ::fcntl(sock, F_GETFL) | O_NONBLOCK);
    std::string stdin_buf, stdout_buf, socket_in_buf, socket_out_buf;
    bool stdin_eof = false;
    // Three distinct descriptors, not two: stdin (0) and stdout (1) are separate pipes
    // (read-only and write-only respectively — never the same fd, even though they sit
    // next to each other in a shell's mental model of "the process's stdio"), plus the
    // bidirectional socket.
    enum { kStdin, kStdout, kSock };
    for (;;) {
        pollfd fds[3] = {
            {0, 0, 0},
            {1, 0, 0},
            {sock, 0, 0},
        };
        if (!stdin_eof) fds[kStdin].events |= POLLIN;
        if (!stdout_buf.empty()) fds[kStdout].events |= POLLOUT;
        fds[kSock].events |= POLLIN;
        if (!socket_out_buf.empty()) fds[kSock].events |= POLLOUT;
        // Nothing left to wait for: both directions exhausted.
        if (fds[kStdin].events == 0 && fds[kStdout].events == 0 && fds[kSock].events == 0) break;
        const int n = ::poll(fds, 3, -1);
        if (n < 0) {
            if (errno == EINTR) continue;
            break;
        }
        if (fds[kStdout].revents & POLLOUT) {
            if (!flush_some(1, stdout_buf)) break;  // Firefox closed our stdout
        }
        if (fds[kSock].revents & POLLOUT) {
            if (!flush_some(sock, socket_out_buf)) break;
        }
        if (fds[kStdin].revents & (POLLIN | POLLHUP)) {
            if (read_available(0, stdin_buf)) stdin_eof = true;
            if (!drain_stdin_frames(stdin_buf, socket_out_buf)) break;
        }
        if (fds[kSock].revents & (POLLIN | POLLHUP)) {
            const bool socket_eof = read_available(sock, socket_in_buf);
            if (!drain_socket_lines(socket_in_buf, stdout_buf)) break;
            if (socket_eof) {
                // The daemon is gone. Flush whatever we already turned into stdout
                // frames, then stop — there is nothing left to relay either direction.
                (void)flush_some(1, stdout_buf);
                break;
            }
        }
        if ((fds[kStdin].revents | fds[kStdout].revents | fds[kSock].revents) &
            (POLLERR | POLLNVAL))
            break;
        // Firefox closed the pipe: nothing more will ever arrive on stdin, and once our
        // own outbound backlog drains there is nothing left to send it either. Stop
        // rather than idle forever relaying replies nobody reads.
        if (stdin_eof && socket_out_buf.empty()) break;
    }
    ::close(sock);
    return 0;
 }
@@ -1,13 +0,0 @@
 # Integration test only — velox-nmhost has no internal functions worth unit-testing in
 # isolation (it's ~15 lines of byte-shuffling helpers around one poll() loop); what matters
 # is the real binary's observable behaviour over real pipes and a real socket.
 add_executable(velox_nmhost_pump_test pump_test.cpp)
 target_compile_features(velox_nmhost_pump_test PRIVATE cxx_std_23)
 target_compile_options(velox_nmhost_pump_test PRIVATE -Wall -Wextra -Wpedantic -Werror)
 target_compile_definitions(velox_nmhost_pump_test PRIVATE
    VELOX_NMHOST_BIN="$<TARGET_FILE:velox-nmhost>")
 add_dependencies(velox_nmhost_pump_test velox-nmhost)
 add_test(NAME nmhost.pump COMMAND velox_nmhost_pump_test)
 set_tests_properties(nmhost.pump PROPERTIES TIMEOUT 30)
@@ -1,54 +0,0 @@
 #pragma once
 // Minimal test harness: CHECK accumulates failures, TEST_MAIN reports and sets the exit
 // code. Copied from daemon/tests/check.hpp rather than shared across a build-dependency —
 // nmhost is deliberately dependency-free, tests included.
 #include <cstdio>
 #include <string>
 #include <vector>
 namespace veloxd_test {
 inline std::vector<std::string>& failures() {
    static std::vector<std::string> f;
    return f;
 }
 inline int& checks() {
    static int n = 0;
    return n;
 }
 }  // namespace veloxd_test
 #define CHECK(cond)                                                                     \
    do {                                                                               \
        ++::veloxd_test::checks();                                                     \
        if (!(cond)) {                                                                 \
            ::veloxd_test::failures().push_back(std::string(__FILE__) + ":" +          \
                                               std::to_string(__LINE__) + ": " + #cond); \
        }                                                                              \
    } while (0)
 #define CHECK_EQ(a, b)                                                                  \
    do {                                                                               \
        ++::veloxd_test::checks();                                                     \
        auto _va = (a);                                                                \
        auto _vb = (b);                                                                \
        if (!(_va == _vb)) {                                                           \
            ::veloxd_test::failures().push_back(std::string(__FILE__) + ":" +          \
                                               std::to_string(__LINE__) + ": " + #a +  \
                                               " == " + #b);                           \
        }                                                                              \
    } while (0)
 #define TEST_MAIN()                                                                     \
    int main() {                                                                        \
        run();                                                                          \
        for (const auto& f : ::veloxd_test::failures()) std::printf("FAIL %s\n", f.c_str()); \
        std::printf("%d/%d checks passed\n",                                            \
                    ::veloxd_test::checks() -                                           \
                        static_cast<int>(::veloxd_test::failures().size()),             \
                    ::veloxd_test::checks());                                           \
        return ::veloxd_test::failures().empty() ? 0 : 1;                               \
    }
@@ -1,148 +0,0 @@
 // Integration test for velox-nmhost: spawns the real binary, feeds it a framed stdin
 // message, answers over a fake Unix socket standing in for veloxd, and checks what comes
 // back out on stdout — plus that it exits promptly once stdin closes.
 #include <sys/socket.h>
 #include <sys/stat.h>
 #include <sys/un.h>
 #include <sys/wait.h>
 #include <unistd.h>
 #include <cstdint>
 #include <cstdlib>
 #include <cstring>
 #include <ctime>
 #include <string>
 #include "check.hpp"
 namespace {
 std::string make_temp_dir() {
    char tmpl[] = "/tmp/velox-nmhost-test-XXXXXX";
    const char* dir = ::mkdtemp(tmpl);
    return dir ? dir : "/tmp";
 }
 // Firefox's own framing: 4-byte native-byte-order length, then that many bytes.
 std::string frame(const std::string& payload) {
    std::uint32_t len = static_cast<std::uint32_t>(payload.size());
    std::string out(reinterpret_cast<char*>(&len), 4);
    out += payload;
    return out;
 }
 // Reads exactly one framed message off `fd`, blocking. Empty on EOF/short read.
 std::string read_frame(int fd) {
    std::uint32_t len = 0;
    std::size_t got = 0;
    while (got < 4) {
        const ssize_t n = ::read(fd, reinterpret_cast<char*>(&len) + got, 4 - got);
        if (n <= 0) return {};
        got += static_cast<std::size_t>(n);
    }
    std::string payload(len, '\0');
    got = 0;
    while (got < len) {
        const ssize_t n = ::read(fd, payload.data() + got, len - got);
        if (n <= 0) return {};
        got += static_cast<std::size_t>(n);
    }
    return payload;
 }
 bool write_all(int fd, const std::string& s) {
    std::size_t off = 0;
    while (off < s.size()) {
        const ssize_t n = ::write(fd, s.data() + off, s.size() - off);
        if (n <= 0) return false;
        off += static_cast<std::size_t>(n);
    }
    return true;
 }
 }  // namespace
 void run() {
    const std::string dir = make_temp_dir();
    const std::string velox_dir = dir + "/velox";
    CHECK(::mkdir(velox_dir.c_str(), 0700) == 0);
    const std::string sock_path = velox_dir + "/velox.sock";
    // A bare listening socket standing in for veloxd.
    const int listen_fd = ::socket(AF_UNIX, SOCK_STREAM, 0);
    CHECK(listen_fd >= 0);
    sockaddr_un addr{};
    addr.sun_family = AF_UNIX;
    std::memcpy(addr.sun_path, sock_path.c_str(), sock_path.size());
    CHECK(::bind(listen_fd, reinterpret_cast<sockaddr*>(&addr), sizeof(addr)) == 0);
    CHECK(::listen(listen_fd, 1) == 0);
    int child_stdin[2];   // [0] read (child), [1] write (parent)
    int child_stdout[2];  // [0] read (parent), [1] write (child)
    CHECK(::pipe(child_stdin) == 0);
    CHECK(::pipe(child_stdout) == 0);
    ::setenv("XDG_RUNTIME_DIR", dir.c_str(), 1);
    const pid_t pid = ::fork();
    CHECK(pid >= 0);
    if (pid == 0) {
        ::dup2(child_stdin[0], 0);
        ::dup2(child_stdout[1], 1);
        ::close(child_stdin[0]);
        ::close(child_stdin[1]);
        ::close(child_stdout[0]);
        ::close(child_stdout[1]);
        ::close(listen_fd);
        ::execl(VELOX_NMHOST_BIN, "velox-nmhost", nullptr);
        ::_exit(127);
    }
    ::close(child_stdin[0]);
    ::close(child_stdout[1]);
    // Accept nmhost's connection.
    const int conn = ::accept(listen_fd, nullptr, nullptr);
    CHECK(conn >= 0);
    // stdin (framed) -> socket (NDJSON line).
    CHECK(write_all(child_stdin[1], frame(R"({"hello":1})")));
    char line[256] = {};
    ssize_t n = ::read(conn, line, sizeof(line) - 1);
    CHECK(n > 0);
    CHECK_EQ(std::string(line, static_cast<std::size_t>(n)), std::string("{\"hello\":1}\n"));
    // socket (NDJSON line) -> stdout (framed).
    CHECK(write_all(conn, "{\"world\":2}\n"));
    const std::string got = read_frame(child_stdout[0]);
    CHECK_EQ(got, std::string(R"({"world":2})"));
    // A second round trip on the same connection, to prove buffering across calls works
    // (not just "the first message happens to line up with one read()").
    CHECK(write_all(child_stdin[1], frame(R"({"again":3})")));
    n = ::read(conn, line, sizeof(line) - 1);
    CHECK(n > 0);
    CHECK_EQ(std::string(line, static_cast<std::size_t>(n)), std::string("{\"again\":3}\n"));
    // Firefox closes the pipe: nmhost must exit promptly rather than hang.
    ::close(child_stdin[1]);
    int status = 0;
    pid_t waited = -1;
    for (int i = 0; i < 50 && waited != pid; ++i) {
        waited = ::waitpid(pid, &status, WNOHANG);
        if (waited == pid) break;
        struct timespec ts{0, 20'000'000};  // 20ms
        ::nanosleep(&ts, nullptr);
    }
    CHECK_EQ(waited, pid);
    if (waited == pid) CHECK(WIFEXITED(status));
    ::close(conn);
    ::close(child_stdout[0]);
    ::close(listen_fd);
    ::unlink(sock_path.c_str());
    ::rmdir(velox_dir.c_str());
    ::rmdir(dir.c_str());
 }
 TEST_MAIN()
@@ -1,97 +0,0 @@
 # packaging/nativehost — the Firefox native-messaging manifest
 Owner: lane DAEMON (`packaging/nativehost/**` is explicitly DAEMON's per `CLAUDE.md`'s
 lane table, unlike the rest of `packaging/`, which is PKG/QA's). This directory holds the
 manifest `velox-nmhost` (built from `nmhost/`) is registered under, and this file is the
 one place that says exactly which on-disk locations need it and why — the
 "install manifests to all four locations" line in `docs/agents/AGENT-DAEMON.md`'s build
 order predates `docs/adr/0003-native-messaging-under-snap.md`, which cut that down to
 three *real* ones. Read the ADR before touching this list; it is the empirical spike, not
 a guess.
 ## The manifest
 `com.velox.host.json` in this directory is the template:
 ```json
 {
  "name": "com.velox.host",
  "description": "Velox download manager — native messaging bridge to veloxd",
  "path": "/usr/libexec/velox/velox-nmhost",
  "type": "stdio",
  "allowed_extensions": ["velox@velox.download"]
 }
 ```
 - `name` is what the extension calls `browser.runtime.connectNative("com.velox.host")`
  with (`extension/src/background/transport/native.ts`'s `HOST_NAME`) — do not rename one
  without the other.
 - `allowed_extensions` must match `extension/manifest.json`'s
  `browser_specific_settings.gecko.id` exactly (`[email protected]`). A mismatch here is
  a silent failure: Firefox reports "no such native application" as if the manifest didn't
  exist at all, which reads exactly like a missing-file bug and is easy to chase in the
  wrong place.
 - `path` is `/usr/libexec/velox/velox-nmhost` — the `.deb`'s install layout
  (`docs/07-packaging.md`). **Every other packaging format needs a different `path`** —
  the binary doesn't live at that absolute path inside a Flatpak sandbox or an AppImage
  mount, so whatever installs the manifest for those formats must rewrite this field to
  wherever it actually put the binary, not ship this file verbatim. That substitution is
  the packaging step's job, not this template's.
 ## Where it has to be written, and why
 Per ADR 0003 (spike S1, run against the real snap Firefox on the target machine — not a
 guess about how confinement "should" work):
 | Location | Covers | Why |
 |---|---|---|
 | `~/.mozilla/native-messaging-hosts/com.velox.host.json` | **deb/tarball Firefox, and snap Firefox** | The one location snap Firefox 154 actually reads. Firefox's snap launches native-messaging hosts *outside* the sandbox with the user's real `$HOME` — so this is not "the deb location that happens to also work"; it is *the* snap location, full stop. `~/snap/firefox/common/.mozilla/native-messaging-hosts/` (the intuitive "inside the snap" path) is **not** read by Firefox 154 snap — confirmed empirically, not inferred. |
 | `/usr/lib/mozilla/native-messaging-hosts/com.velox.host.json` | **deb/tarball Firefox only** | System-wide, so it covers every user on the box for a real (non-snap) Firefox install — but confirmed **not** read by snap Firefox. Do not treat this path as "covers snap too"; that was the wrong assumption `docs/05` §4 corrected in the same commit as the ADR. |
 | `~/.var/app/org.mozilla.firefox/.mozilla/native-messaging-hosts/com.velox.host.json` | **Flatpak Firefox** | Flatpak's own sandboxed home. Untested on this machine (Firefox here is the snap, not flatpak) — carried over from `docs/05` §4's original four-location list, which this table otherwise supersedes. Verify before relying on it in a release checklist. |
 That is three real locations, not four — the fourth
 (`~/snap/firefox/common/.mozilla/native-messaging-hosts/`) was the pre-ADR guess the spike
 disproved. If `docs/agents/AGENT-DAEMON.md`'s build order still says "four locations" when
 you read this, it is stale; this table is the current source of truth alongside the ADR
 itself.
 ## What this means for `postinst` (PKG/QA's file, not this one)
 This directory ships the manifest template and documents the target paths; it does not
 install anything itself (`packaging/**` outside this one directory is PKG/QA's — see
 `CLAUDE.md`'s lane table — and `postinst` specifically is a `.deb`-packaging concern this
 lane doesn't own the file for). For whoever writes it:
 - **The two `~/`-relative locations are per-user.** `postinst` runs as root, once, at
  install time — it does not run once per user session. It needs either a real-user
  enumeration at install time (every UID with a home directory and no login shell of
  `/usr/sbin/nologin`-style exclusions, roughly what `deluser --remove-home` scripts already
  have to reason about) or a first-run hook that runs as the logged-in user (a systemd user
  unit's `ExecStartPre`, or the GUI's own first-run wizard) and writes its own manifest the
  first time it starts. `docs/adr/0003`'s own follow-up section flagged this as open; it
  still is.
 - **`/usr/lib/mozilla/native-messaging-hosts/` is the only one of the three that's a plain
  root-owned, install-time write** — no per-user enumeration needed for that one.
 - **Detect snap Firefox and say so.** `docs/07-packaging.md` already commits to this
  ("detects whether Firefox is a snap... prints... a one-line note that the extension will
  pair over loopback") — the detection matters here specifically because if Firefox turns
  out to be neither deb/tarball nor a snap this spike covers (a genuinely unknown or future
  packaging of Firefox), silently trusting `NativeTransport` to work is exactly the failure
  mode ADR 0003 exists to prevent. `WebSocketTransport` is the guaranteed fallback either
  way (ADR 0003's own decision) — nothing breaks if the manifest doesn't land correctly, it
  just means the extension pairs over loopback instead of the (opportunistic, not
  required) native path.
 - **`docs/07-packaging.md`'s own install layout line currently lists only the
  system-wide `/usr/lib/mozilla/...` path.** That line is correct as far as it goes (it *is*
  one of the three locations, and the only pure root-owned one) but reads as if it were the
  whole story for native messaging; it predates this file and the ADR. Worth a line
  pointing here so the two documents don't quietly disagree — PKG/QA's call, not edited
  here since `docs/07` is PKG/QA's own file.
 ## The binary
 `nmhost/` builds `velox-nmhost` — see that directory's own `src/main.cpp` for what it does
 (a byte-level pump, no protocol logic) and `docs/05-extension-spec.md` §4 for the two
 transports it sits behind. It is deliberately dependency-free (not linked against any
 `veloxd_*` library) so wherever a packaging format's sandbox puts it, it has nothing else
 to go looking for at runtime.
@@ -1,7 +0,0 @@
 {
  "name": "com.velox.host",
  "description": "Velox download manager — native messaging bridge to veloxd",
  "path": "/usr/libexec/velox/velox-nmhost",
  "type": "stdio",
  "allowed_extensions": ["[email protected]"]
 }
@@ -1,65 +0,0 @@
 # packaging/systemd — the user unit pair for veloxd
 Provided by lane DAEMON (`daemon/docs/AGENT-DAEMON.md` build step 7: "systemd user units
 — `velox.service` + `velox.socket` for socket activation"), for PKG/QA to install per
 `docs/07-packaging.md`'s layout:
 ```
 /usr/lib/systemd/user/velox.service
 /usr/lib/systemd/user/velox.socket
 ```
 `packaging/` outside `nativehost/` is PKG/QA's per `CLAUDE.md`'s lane table; these two
 files are here because they are inputs to that packaging step, not a claim on the rest of
 the directory — same relationship `packaging/nativehost/` already has.
 ## Why both files, and what `RuntimeDirectory=` is doing
 `velox.socket` binds `$XDG_RUNTIME_DIR/velox/velox.sock` **before `veloxd` ever runs** and
 hands the daemon the already-listening fd at startup (`daemon/src/rpc/systemd_activation.cpp`
 implements the receiving half — `LISTEN_PID`/`LISTEN_FDS`, fd 3 — without a `libsystemd`
 link). Two things this buys over the daemon binding its own socket on every start:
 - **No window where a client gets `ECONNREFUSED`.** The socket exists and queues
  connections from the moment `velox.socket` is active, not from whenever `veloxd`
  finishes starting up — this is the actual point of socket activation, not just "start
  on demand."
 - **Cold-boot ordering is free.** Nothing has to wait for `veloxd` to be ready before the
  GUI, the CLI, or a native-messaging host can attempt a connection; the kernel queues it.
 `RuntimeDirectory=velox` on the socket unit creates `%t/velox` (mode 0700) before the
 `ListenStream=` bind — without it, binding fails outright the first time (nothing has
 created the parent directory yet). `veloxd` itself creates that same directory
 (`ensure_private_dir` in `runtime_dir.cpp`) for the case where it's started directly,
 outside systemd (`./veloxd` in a terminal, still supported and how most of this daemon's
 own testing runs) — the two paths converge on the same directory with the same mode
 either way.
 `UdsServer::start()` (`daemon/src/rpc/uds_server.cpp`) checks for the activated fd first
 and, if present, skips create/bind/chmod/listen entirely — the socket file's lifecycle then
 belongs to the unit (including `RemoveOnStop=yes` on stop), not to the daemon. Falls back
 to binding its own socket exactly as before when not socket-activated (a manual run, or a
 distro that ships the daemon without the unit files).
 ## What was deliberately left out
 `velox.service` does **not** set `ProtectSystem=`, `ProtectHome=`, or `ReadWritePaths=`.
 `saveTo.allowedRoots` is user-configurable to anywhere on the filesystem — an external
 drive, a second mount, anywhere `fs/safepath.hpp`'s own canonicalize-and-check accepts —
 not a fixed set of directories a unit file could enumerate ahead of time. A filesystem-level
 sandbox here would turn a legitimately-configured save location into an opaque
 `EROFS`/`EACCES` the daemon can't explain, in place of its own clear `-32011` — worse than
 no sandbox, specifically for a download manager. `NoNewPrivileges=yes` is kept: it has no
 such trade-off.
 ## Verifying socket activation without a real install
 `systemd-analyze verify --user velox.service velox.socket` checks unit-file syntax (it
 will complain that `/usr/bin/veloxd` and the `velox(1)` man page don't exist on a dev
 box that hasn't installed the package — expected, not a unit bug). To exercise the actual
 activation handshake without installing anything: bind a Unix socket, `dup2` it onto fd 3,
 fork, set `LISTEN_PID=<child pid>` and `LISTEN_FDS=1` in the child's environment, clear
 `FD_CLOEXEC` on fd 3, and `execve` `veloxd` — a real `session.hello` round-trips over that
 fd with no `bind()`/`listen()` call ever happening inside the daemon for that run. This is
 exactly what `velox.socket`'s `Requires=`/`ExecStart` sequence does in production; systemd
 supplies the fd, `veloxd` doesn't know the difference.
@@ -1,38 +0,0 @@
 [Unit]
 Description=Velox download manager daemon
 Documentation=man:velox(1)
 # Socket activation (velox.socket) means this unit does not need to be enabled or started
 # directly for the RPC transport to come up on demand — the first connection attempt after
 # boot starts veloxd with the listening socket already bound (see velox.socket's own
 # comment). Requires=/After= still matter for a manual `systemctl --user start velox`.
 Requires=velox.socket
 After=velox.socket
 # Never more than one real instance for this user regardless of how it was started — the
 # abstract-socket single-instance lock (main.cpp, keyed off the resolved runtime dir) is
 # the actual enforcement; this just keeps systemd itself from racing two starts.
 StartLimitIntervalSec=60
 StartLimitBurst=5
 [Service]
 Type=simple
 ExecStart=/usr/bin/veloxd
 # main.cpp's SIGTERM handler stops the event loop and falls through to a clean shutdown
 # (flushes buffers, closes the store, releases the single-instance lock) — the default
 # KillSignal=SIGTERM and TimeoutStopSec are already the right shape for that; no
 # ExecStop/KillMode override needed.
 Restart=on-failure
 RestartSec=2
 # Hardening deliberately stops here, not at ProtectSystem=/ProtectHome=/ReadWritePaths=:
 # saveTo.allowedRoots is user-configurable to anywhere (an external drive, a second
 # mount — fs/safepath.hpp is the daemon's own validation boundary, not a fixed set of
 # directories a unit file could enumerate up front). A filesystem-level sandbox here would
 # silently turn a legitimately-configured save location into an opaque EROFS/EACCES the
 # daemon can't explain, instead of its own clear -32011 — worse than no sandbox, for a
 # download manager specifically. NoNewPrivileges is free of that trade-off.
 NoNewPrivileges=yes
 [Install]
 WantedBy=default.target
 Also=velox.socket
@@ -1,28 +0,0 @@
 [Unit]
 Description=Velox download manager — RPC socket
 [Socket]
 # %t is $XDG_RUNTIME_DIR for a user unit — the exact path veloxd itself resolves
 # (daemon/src/rpc/runtime_dir.cpp's resolve_runtime_dir), and the exact path velox(1)
 # resolves too (default_socket_path() in cli/src/client.cpp). All three must agree; this
 # is the one line that has to.
 ListenStream=%t/velox/velox.sock
 # RuntimeDirectory creates %t/velox (mode 0700, this user's own) before binding, so the
 # ListenStream= path above always has somewhere to land — veloxd itself does the same
 # thing (ensure_private_dir) when it creates the directory unassisted (the non-activated
 # path, e.g. a manual `veloxd` run outside systemd).
 RuntimeDirectory=velox
 RuntimeDirectoryMode=0700
 # Same-UID-only, matching the socket's own authorization once a connection is accepted
 # (SO_PEERCRED, checked again in uds_server.cpp regardless of this mode bit — belt and
 # braces, not a substitute for it).
 SocketMode=0600
 # The socket file belongs to systemd's socket-activation state, not to whatever's on disk
 # from a previous boot; remove it on stop so a stale entry never shadows the next start.
 RemoveOnStop=yes
 [Install]
 WantedBy=sockets.target
@@ -40,16 +40,26 @@ while [ $# -gt 0 ]; do
  esac
 done
-# Kill the server and anything it spawned. `kill $!` alone would only reap the subshell
+# Kill the server and anything it spawned. `pkill -P "$pid"` only reaps direct children —
-# wrapper and leave the node process holding the port, which then breaks the next run.
+# tsx's actual listener is often a grandchild, which that missed, leaving it holding the
 # port and breaking the next run (a leaked mockd once did exactly this). Every server
 # below is launched via `setsid`, which makes it the leader of its own new session/process
 # group (pgid == its own pid), so `kill -TERM -"$pid"` (negative: a process-group kill)
 # reaches it and everything it spawned in one shot, however deep.
 stop() {
  local pid="$1"
  [ -n "$pid" ] || return 0
-  pkill -P "$pid" 2>/dev/null || true
+  kill -TERM -"$pid" 2>/dev/null || kill "$pid" 2>/dev/null || true
  kill "$pid" 2>/dev/null || true
  wait "$pid" 2>/dev/null || true
 }
 # A free loopback TCP port, kernel-assigned (bind :0) rather than a fixed number — a
 # hardcoded port means one leaked process from a previous run makes every future run fail
 # EADDRINUSE instead of just picking a different port.
 free_port() {
  python3 -c "import socket; s=socket.socket(); s.bind(('127.0.0.1',0)); print(s.getsockname()[1]); s.close()"
 }
 cleanup() {
  stop "$MOCKD_PID"
  stop "$SLOW_PID"
@@ -84,8 +94,8 @@ step "generated TypeScript against a live server"
 if [ -z "$EXTERNAL_UDS" ] && [ -z "$EXTERNAL_WS" ]; then
  ( cd "$REPO/tools/mockd" && npm install --silent --no-audit --no-fund )
  UDS="$WORK/velox.sock"
-  WS_PORT=52080
+  WS_PORT="$(free_port)"
-  ( cd "$REPO/tools/mockd" && exec ./node_modules/.bin/tsx src/index.ts \
+  ( cd "$REPO/tools/mockd" && exec setsid ./node_modules/.bin/tsx src/index.ts \
      --uds "$UDS" --ws-port "$WS_PORT" --allowed-root "$WORK" ) >"$WORK/mockd.log" 2>&1 &
  MOCKD_PID=$!
  # Wait for the socket rather than sleeping a guessed amount.
@@ -139,8 +149,12 @@ if [ -z "$EXTERNAL_UDS" ] && [ -z "$EXTERNAL_WS" ]; then
    VXDG="$WORK/veloxd-xdg"
    mkdir -p "$VXDG/runtime" "$VXDG/data" "$VXDG/config" "$VXDG/downloads"
    # VELOX_PAIR_AUTO=1: the pairing approver is the D1 dev stub (EnvAutoApprover,
    # daemon/src/rpc/pairing.cpp) and denies every pairing without it — without this,
    # session.pair never issues a token and the WS half of this step can't even connect.
    XDG_RUNTIME_DIR="$VXDG/runtime" XDG_DATA_HOME="$VXDG/data" XDG_CONFIG_HOME="$VXDG/config" \
-      "$VELOXD_BIN" >"$WORK/veloxd.log" 2>&1 &
+      VELOX_PAIR_AUTO=1 \
      setsid "$VELOXD_BIN" >"$WORK/veloxd.log" 2>&1 &
    VELOXD_PID=$!
    VUDS="$VXDG/runtime/velox/velox.sock"
    for _ in $(seq 1 50); do [ -S "$VUDS" ] && break; sleep 0.2; done
@@ -183,7 +197,7 @@ fi
 step "capture.offer fails open when the daemon is too slow"
 if [ -z "$EXTERNAL_UDS" ]; then
  SLOW_UDS="$WORK/slow.sock"
-  ( cd "$REPO/tools/mockd" && exec ./node_modules/.bin/tsx src/index.ts \
+  ( cd "$REPO/tools/mockd" && exec setsid ./node_modules/.bin/tsx src/index.ts \
      --uds "$SLOW_UDS" --no-ws --slow 2000 ) >"$WORK/slow.log" 2>&1 &
  SLOW_PID=$!
  for _ in $(seq 1 50); do [ -S "$SLOW_UDS" ] && break; sleep 0.2; done
@@ -76,6 +76,12 @@ interface Fixture {
  /** A condition the server cannot produce from the request alone. Skipped unless the
   *  harness has arranged it — see tests/integration. */
  requires?: string;
  /** This request is documented to make the *server* close the connection after replying
   *  (e.g. a mismatched protocol major on the Unix socket). replay() reconnects afterward
   *  so every later fixture in the shared-connection replay isn't sent into a dead socket
   *  and left to time out one by one — which is silent when the fixture in question is
   *  also on the xfail allowlist, since applyXfail accepts any failure reason. */
  closesConnection?: boolean;
  transport?: TransportName;
  deadlineMs?: number;
  request?: { jsonrpc: '2.0'; id: number | string; method: string; params?: unknown };
@@ -196,11 +202,13 @@ function staticChecks(fixtures: readonly Fixture[]): Outcome[] {
 }
 /**
- * Methods that destroy the state later fixtures rely on. Replayed last so the suite does
+ * Methods that destroy state, or consume state another fixture creates. Replayed last so
- * not depend on file order, which is the sort of thing that goes green locally and red in
+ * the suite does not depend on file order, which is the sort of thing that goes green
- * CI on a different filesystem.
+ * locally and red in CI on a different filesystem — alphabetical happens to put
 * category.remove.json before category.upsert.json, and category.remove's fixture only
 * has a "firmware" category to delete because category.upsert's fixture just created one.
 */
-const DESTRUCTIVE = new Set<string>(['download.remove']);
+const DESTRUCTIVE = new Set<string>(['download.remove', 'category.remove']);
 function replayOrder(a: Fixture, b: Fixture): number {
  const rank = (f: Fixture): number => (DESTRUCTIVE.has(f.request?.method ?? '') ? 1 : 0);
@@ -247,10 +255,13 @@ async function setupBindings(conn: Conn): Promise<{ bindings: Record<string, str
  return { bindings, setup };
 }
-async function replay(conn: Conn, fixtures: readonly Fixture[],
+async function replay(initialConn: Conn, fixtures: readonly Fixture[],
                      bindings: Record<string, string>,
-                      includeRequires = false): Promise<Outcome[]> {
+                      includeRequires = false,
                      reconnect?: () => Promise<Conn>):
    Promise<{ outcomes: Outcome[]; conn: Conn }> {
  const out: Outcome[] = [];
  let conn = initialConn;
  const t = conn.transport;
  for (const f of [...fixtures].sort(replayOrder)) {
@@ -266,7 +277,14 @@ async function replay(conn: Conn, fixtures: readonly Fixture[],
    }
    const deadline = f.deadlineMs ?? Math.max(METHODS[method].deadlineMs, 2000);
    if (process.env.DEBUG_CONFORMANCE) process.stderr.write(`>>> [${t}] ${f.file} ${method}\n`);
    const frame = await conn.request(method, bind(f.request.params ?? {}, bindings), deadline);
    if (process.env.DEBUG_CONFORMANCE) process.stderr.write(`<<< [${t}] ${f.file} ${frame ? 'ok' : 'TIMEOUT'}\n`);
    if (f.closesConnection && reconnect) {
      conn.close();
      conn = await reconnect();
    }
    if (f.kind === 'timeout') {
      out.push({
@@ -313,7 +331,7 @@ async function replay(conn: Conn, fixtures: readonly Fixture[],
    out.push({ fixture: f.file, transport: t, ok: mismatch === null,
               detail: mismatch ?? 'result validates and matches the golden shape' });
  }
-  return out;
+  return { outcomes: out, conn };
 }
 /** The transport rules are part of the contract, so they get replayed too. */
@@ -364,10 +382,18 @@ function loadXfail(path: string): XfailEntry[] {
 * Reconciles outcomes against the allowlist. A listed fixture that failed is downgraded
 * to a pass (its detail says why). A listed fixture that *passed* is flipped to a
 * failure: the entry is stale and must be deleted from the list, not left to rot.
 *
 * Never touches a 'static' outcome: those validate the golden fixture against the
 * generated validators offline and never talk to a server, so a stub handler can't make
 * one fail in the first place — matching them here would just relabel an
 * always-true check as "xfail" and then, since it always stays true, immediately flag it
 * as an unexpected pass. (A fixture also gets *two* static outcomes — params and result —
 * so without this exclusion a single xfail entry would print that "duplicate" twice.)
 */
 function applyXfail(results: readonly Outcome[], xfail: readonly XfailEntry[]): Outcome[] {
  const matches = (e: XfailEntry, r: Outcome): boolean =>
-    e.fixture === r.fixture && (e.transport === undefined || e.transport === r.transport);
+    r.transport !== 'static' && e.fixture === r.fixture &&
    (e.transport === undefined || e.transport === r.transport);
  return results.map((r) => {
    const entry = xfail.find((e) => matches(e, r));
@@ -409,14 +435,18 @@ async function main(): Promise<void> {
  const udsPath = arg('--uds');
  const wsPort = arg('--ws-port');
-  if (udsPath) {
+  // Each opens (and re-opens, via `reconnect`) with the same handshake: session.hello on
-    const conn = await connectUds(udsPath);
+  // the Unix socket, session.pair + session.hello on the WebSocket. Needed because at
-    await conn.call('session.hello', { clientType: 'test', clientName: 'conformance', protocolVersion: '1.0.0' });
+  // least one fixture (session.hello.version-mismatch) documents that the *server* closes
-    const { bindings, setup } = await setupBindings(conn);
+  // the connection after replying — replay() calls this to get a working connection back
-    results.push(...setup, ...(await replay(conn, fixtures, bindings, includeRequires)));
+  // rather than leaving every later fixture on the shared connection to time out.
-    conn.close();
+  async function freshUds(): Promise<Conn> {
    const conn = await connectUds(udsPath!);
    await conn.call('session.hello',
      { clientType: 'test', clientName: 'conformance', protocolVersion: '1.0.0' });
    return conn;
  }
-  if (wsPort) {
+  async function freshWs(): Promise<Conn> {
    const conn = await connectWs(Number(wsPort));
    const paired = await conn.request(
      'session.pair',
@@ -427,10 +457,23 @@ async function main(): Promise<void> {
    if (token === undefined) throw new Error('pairing failed: no token issued');
    await conn.request('session.hello',
      { clientType: 'test', clientName: 'conformance', protocolVersion: '1.0.0', token }, 5000);
    return conn;
  }
  if (udsPath) {
    const conn = await freshUds();
    const { bindings, setup } = await setupBindings(conn);
-    results.push(...setup, ...(await replay(conn, fixtures, bindings, includeRequires)));
+    const { outcomes, conn: last } = await replay(conn, fixtures, bindings, includeRequires, freshUds);
-    results.push(...(await privilegeChecks(conn)));
+    results.push(...setup, ...outcomes);
-    conn.close();
+    last.close();
  }
  if (wsPort) {
    const conn = await freshWs();
    const { bindings, setup } = await setupBindings(conn);
    const { outcomes, conn: last } = await replay(conn, fixtures, bindings, includeRequires, freshWs);
    results.push(...setup, ...outcomes);
    results.push(...(await privilegeChecks(last)));
    last.close();
  }
  if (!udsPath && !wsPort) {
    process.stdout.write('no --uds or --ws-port given: ran static checks only\n');
@@ -1,17 +1,6 @@
 [
  { "fixture": "contracts/fixtures/download.probe.json", "reason": "D2: download.probe -> -32603, needs the engine probe path" },
  { "fixture": "contracts/fixtures/errors/download.probe.probe-failed.json", "reason": "D2: download.probe -> -32603, needs the engine probe path" },
  { "fixture": "contracts/fixtures/download.pause.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/download.resume.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/download.start.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/download.cancel.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/download.remove.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/download.addBatch.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/download.refreshUrl.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/download.update.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/download.provideAuth.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/errors/download.provideAuth.not-found.json", "reason": "D3: stub handler, -32603 instead of -32010" },
  { "fixture": "contracts/fixtures/rules.list.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/rules.upsert.json", "reason": "D3: stub handler, -32603" },
@@ -25,13 +14,7 @@
  { "fixture": "contracts/fixtures/schedule.get.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/schedule.set.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/queue.upsert.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/queue.reorder.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/queue.start.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/queue.stop.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/category.upsert.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/category.remove.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/grabber.harvest.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/grabber.start.json", "reason": "D3: stub handler, -32603" },
@@ -40,7 +23,18 @@
  { "fixture": "contracts/fixtures/media.addVariant.json", "reason": "D3: stub handler, -32603" },
  { "fixture": "contracts/fixtures/media.listVariants.json", "reason": "D3: stub handler, -32603" },
-  { "fixture": "contracts/fixtures/capture.getRules.json", "reason": "stub handler, -32603 -- NOT in daemon/docs/deferrals.md; filed to DAEMON to add a D-row" },
+  { "fixture": "contracts/fixtures/capture.getRules.json", "reason": "D3: stub handler, -32603 -- DAEMON is filing capture.offer next" },
-  { "fixture": "contracts/fixtures/capture.offer.take.json", "reason": "stub handler, -32603 -- NOT in daemon/docs/deferrals.md; filed to DAEMON to add a D-row" },
+  { "fixture": "contracts/fixtures/capture.offer.take.json", "reason": "D3: stub handler, -32603 -- DAEMON is filing capture.offer next" },
-  { "fixture": "contracts/fixtures/errors/capture.offer.ignore.json", "reason": "stub handler, -32603 -- NOT in daemon/docs/deferrals.md; filed to DAEMON to add a D-row" }
+  { "fixture": "contracts/fixtures/errors/capture.offer.ignore.json", "reason": "D3: stub handler, -32603 -- DAEMON is filing capture.offer next" },
  { "fixture": "contracts/fixtures/errors/download.provideAuth.not-found.json", "reason": "real bug: on_download_provideAuth (dispatcher.cpp) never checks the task exists -- TaskActionPort::provide_auth returns false for an unknown id, which the handler folds into a normal {ok:false} result instead of -32010" },
  { "fixture": "contracts/fixtures/category.list.json", "reason": "documented gap (deferrals.md D3a note): categories table has no mimeTypes/sortOrder columns, so category.upsert accepts them but category.list never echoes mimeTypes back" },
  { "fixture": "contracts/fixtures/download.probe.json", "reason": "not a bug: requiresAuth is optional-and-omitted-when-false (schema doesn't require it); the golden shows it because that fixture's probe hit a 401, this run's doesn't" },
  { "fixture": "contracts/fixtures/download.get.json", "reason": "not a bug: effectiveUrl is 'null until the first probe succeeds' (schema) and omitted rather than sent as null; our bound $taskId is a fresh, never-started task, so it's never been probed -- the golden depicts an in-progress download instead" },
  { "fixture": "contracts/fixtures/download.list.json", "reason": "same as download.get.json: effectiveUrl omitted for our never-started bound tasks, golden depicts an in-progress download" },
  { "fixture": "contracts/fixtures/session.hello.json", "reason": "not a bug: capabilities is genuinely empty because media/grabber/Secret Service aren't implemented yet; the golden's ['media','grabber','secretservice'] illustrates a future daemon, not this one" },
  { "fixture": "contracts/fixtures/queue.start.json", "reason": "not a bug: startedTaskIds is empty because nothing is a member of queue 'main' in this isolated run; the golden depicts a queue with real membership" },
  { "fixture": "contracts/fixtures/category.remove.json", "reason": "not a bug: reassignedTaskIds is empty because nothing was ever filed under the 'firmware' category this run creates; the golden depicts a category with real membership" }
 ]
Author	SHA1	Message	Date
samiandClaude Sonnet 5	c2eef96175	gui: floating drop target, clipboard global shortcut, theming, UI watchdog Continues the build order past Options/Scheduler/Speed Limiter/Batch/ Grabber/tray. - DropTargetWidget: frameless always-on-top drop target (docs/03-gui-spec.md §5), position persisted, accepts a dropped http(s) URL or link text and opens FileInfoDialog directly (skipping Add URL, since the URL is already known). Shown/hidden from general.showDropTarget, live via event.settings.changed, same pattern MainWindow already used for general.minimizeToTray. - Clipboard, explicit path #2 (docs/06-risks-and-spikes.md R2): GlobalShortcut wraps org.freedesktop.portal.GlobalShortcuts (CreateSession -> BindShortcuts -> Activated), triggering the same Add URL flow. Guarded end-to-end on `if(TARGET Qt6::DBus)` / VELOX_GUI_HAVE_DBUS so a build without the component degrades to "feature skipped," not broken (gui/docs/pkg-qa-requests-m1.md R4). Best-effort by design per the risk doc: fails silent, never advertised. Verified live against the real portal (a real Wayland session, not just offscreen): `CreateSession` refuses every caller with "An app id is required" — reproduced identically via a bare `busctl` call with no Qt involved at all, so this is the portal requiring a sandboxed caller identity, not something fixable from an unconfined process. Recorded as a partial Spike S2 answer in docs/06-risks-and-spikes.md: this explicit path likely doesn't work for Velox as a traditionally-packaged app on stock GNOME, only if/when it ships confined. Also fixed a real leak this verification caught: QDBusInterface's introspection cache reads as a LeakSanitizer leak the first time anything touches D-Bus (tst_rtl went red under ASan) — switched to QDBusMessage::createMethodCall, which needs no introspection. - Theming (docs/03-gui-spec.md §7): gui/resources/qss/{idm-like,dark}.qss, each with a documented palette block up top (QSS itself has no variable syntax), applied by ThemeManager and kept live via QStyleHints::colorSchemeChanged. util/Theme.hpp gives the handful of inline C++ styles (status dot, offline banner, the eleven identical error-label styles across dialogs) named constants instead of a twelfth copy of the same hex. - UiThreadWatchdog: the M1 DoD's 200 ms debug-build watchdog. A background std::thread pings the UI thread every 50 ms via a queued invokeMethod and warns once (not per-poll) if a ping goes unanswered past 200 ms; no QThread, no Qt event loop of its own, so the watchdog itself can never be what blocks the thread it watches. No-op in a release build. Proven both ways in tst_uithreadwatchdog: fires on a genuinely blocked UI thread (synchronous sleep, no processEvents) and stays silent on a responsive one. Full non-conformance suite (55 tests across every lane, `ctest -LE conformance`) passes clean at this point, including the whole gui label under ASan+UBSan. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NSCdCWFXBTSBBK3MzWtJiC	2026-09-12 21:30:13 +04:00
samiandClaude Sonnet 5	1fd2e0a0db	gui: Options — Capture tab, saveTo.allowedRoots, lock coverage to the schema Options was missing 8 of the 43 real settings.* keys: capture.enabled, monitoredExtensions, monitoredMimeTypes, minSizeBytes, excludedHosts, bypassModifier, autoStartTypes, and saveTo.allowedRoots. The capture.* keys were dropped in an earlier pass on the mistaken read that the spec's "File Types" tab meant per-category extension lists (which do live on Category, not settings.) — they're real settings. keys for a real daemon feature (the extension's auto-capture policy), so the tab exists now, named "Capture" to match what it actually configures rather than the spec's label. New tst_optionsdialog case (allKeysMatchesTheSchemaExactly) loads Settings.schema.json itself at test time and diffs its property set against OptionsDialog::allKeys() — this drifted silently once already, so the regression is now a build-time gate an unused import or a future key addition would trip, not something that needs re-discovering by hand again. Verified against a real veloxd (not just mockd): settings.get across all 43 keys, a settings.set/get round trip on a scalar (connection.timeoutSec) and on array-valued keys in the shapes OptionsDialog::currentValues() actually produces (capture.monitoredExtensions, proxy.bypassHosts, saveTo.allowedRoots), and event.settings.changed fanning out to a second subscribed client — all round-tripped and restored to their original values afterward. The real OptionsDialog widget also loads and renders correctly against that same daemon's live defaults with no crash under ASan+UBSan. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NSCdCWFXBTSBBK3MzWtJiC	2026-09-12 21:29:19 +04:00
samiandClaude Sonnet 5	755d85964e	gui: M1 DoD harness — scroll-60fps, rss-flat, unhappy-path gui/docs/pkg-qa-requests-m1.md R3, filed by the previous session: three GUI M1 DoD items (10k rows at 60 fps, flat RSS over 10 minutes, --slow/--flaky/--drop-connection recovery) had nowhere to run in CI. This is the harness — `gui/tests/dod/run.sh <gate> [--json <path>]`, exactly the path/invocation contract tests/integration/README.md already specified — plus `gui/tests/dod/dod_harness.cpp`, the Qt/RpcClient-driven binary that actually runs each gate against a real mockd run.sh starts and tears down itself. - scroll-60fps: an eased scripted scroll over the whole loaded table, timing each step's synchronous repaint; p99 against a 16.6 ms budget (auto-scaled 4x under a sanitized build — ASan/UBSan overhead, not a loosened bar, see the harness's isSanitizedBuild()). - rss-flat: samples this process's own VmRSS at 1 Hz across the run, discards a warm-up window, checks post-warm-up growth against a stated 20 MiB slack. - unhappy-path: three phases (slow/flaky/drop-connection), each its own mockd instance; passes when the client reaches and holds Connected with no crash or hang. A watchdog (the harness's own QTimer, backstopped by run.sh's external `timeout`) turns a genuine hang into a bounded non-zero exit rather than needing the CI caller to timeout(1) around it. Every gate honours the exit-code and --json contract PKG/QA's pre-drafted CI job expects unchanged (one addition needed: the build step must also build the `gui-dod-harness` target, noted in the R3 update). No leaked mockd processes on any exit path (`trap cleanup EXIT INT TERM`); no writes outside a tempdir except the caller's own --json path. Verified live end-to-end (not just unit-level): all three gates run against a real mockd under the exact `ASAN_OPTIONS=detect_leaks=1:halt_on_error=1` `.github/workflows/ci.yml`'s sanitizers job already sets, all pass, and scroll-60fps was forced red once on purpose (VELOX_DOD_FRAME_BUDGET_MS=1) to prove the fail path and exit code actually work. Building this is also what surfaced the two RpcClient bugs fixed in the previous commit, and one real gap in mockd itself — --drop-connection never worked over the Unix socket transport (only WebSocket) — filed as gui/docs/proto-requests-m1.md since tools/mockd is PROTO's file. gui/docs/pkg-qa-requests-m1.md R3 and R4 (an unrelated, non-blocking Qt6::DBus CMake hygiene note filed while wiring the clipboard global-shortcut path) are updated with the concrete findings above. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NSCdCWFXBTSBBK3MzWtJiC	2026-09-12 21:28:36 +04:00
samiandClaude Sonnet 5	c6f864ea30	gui: fix RpcClient double-free on stop() and the 1000-row list cap Both found live while building gui/tests/dod's DoD harness, not from reading the code — see that commit for how. RpcClient::stop() left conn_ dangling after joining the worker thread: the thread's own finish() flushes the DeferredDelete stop()'s connect(&thread_, &QThread::finished, conn_, &QObject::deleteLater) already posted, so conn_ is gone by the time stop() returns, but nothing cleared the pointer. Any caller that calls stop() and later lets the client destruct (the harness's own client.stop() at shutdown; also plain, correct API usage) hit a double-free in the destructor's leftover `delete conn_`. Caught by ASan on the very first run that actually exercised the stop-then-destroy path. requestInitialList() also called download.list with a hardcoded `{"limit": 1000}`, silently capping the table at 1000 rows no matter how many the daemon actually has — download.list.schema.json's own description says "the GUI pages", not "the GUI takes it all in one call". The scroll-60fps DoD gate refused to run against mockd --tasks 10000 rather than "pass" against a 1000-row table, which is what surfaced it. requestInitialList() now pages (5000 per call, the schema's own max) until `total` is satisfied, then resets the model once with everything. Separately: RpcConnection's session.subscribe list never included event.settings.changed or event.grabber.progress, even though RpcClient has carried signals for both since the Options/Grabber work — session.subscribe "replaces the previous selection" and "nothing is delivered until this is called", so both events were being silently dropped by any real daemon that enforces the subscription (mockd does; verified live with a second subscribed client actually receiving event.settings.changed after this fix, round-tripped through a real veloxd's settings.set). GrabberWizard's 5 s poll fallback is exactly why this went unnoticed until now — it covered for the missing push the whole time. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NSCdCWFXBTSBBK3MzWtJiC	2026-09-12 21:27:28 +04:00
sami	0468b0176a	merge: lane/daemon	2026-09-12 16:27:29 +04:00
sami	d8b7c128be	merge: lane/proto	2026-09-12 16:27:29 +04:00
samiandClaude Sonnet 5	e30d994d74	proto: fix conformance run.sh flakiness, prune the veloxd xfail list Two run.sh fixes plus the xfail prune, all requested together: 1. VELOX_PAIR_AUTO=1 for the isolated veloxd. Pairing is the D1 dev stub (EnvAutoApprover) and denies without it, so session.pair never issued a token and the WS half of the veloxd step could never even connect. 2. WS_PORT was hardcoded to 52080 with no free-port search, so one leaked mockd made every future run fail EADDRINUSE. free_port() binds :0 and asks the kernel instead. The EXIT trap's stop() used `pkill -P "$pid"`, which only reaps direct children — tsx's actual listener is often a grandchild, which that missed and left holding the port. Every server (mockd, slow mockd, veloxd) now launches under `setsid`, making it the leader of its own process group, so stop() does `kill -TERM -"$pid"` (a process-group kill) and reaches everything it spawned in one shot. 3. Pruned the xfail list now that D2, D4b and most of D3 have landed. Pruning surfaced two more bugs than expected, both in the test harness itself, not veloxd — worth recording since they were indistinguishable from real daemon hangs until isolated: - errors/session.hello.version-mismatch.json documents that the server closes the connection after replying (correct, intended behavior). The harness replays every fixture on one shared connection per transport, so once this fixture ran, every later UDS fixture sent into the dead socket and just sat there until its own timeout — including ones still on the xfail list, which applyXfail waved through as "expected -32603" regardless of the real reason. Fixed with a `closesConnection` fixture flag: replay() reconnects (fresh session.hello) right after such a fixture instead of leaving the rest of the run to time out one by one. This is what was actually behind queue./session./download.remove appearing to hang — none of them do; verified individually and via a raw probe script before finding the real cause. - category.remove.json (deletes the "firmware" category) sorted before category.upsert.json (creates it) alphabetically, so it was failing -32602 "no such category" against a fresh DB — never a daemon bug. Added it to DESTRUCTIVE so it now replays after every other fixture. Also fixed while verifying "confirm each really passes": download.addBatch.json's `defaults.categoryId` was "compressed", a category nothing ever creates — real veloxd correctly enforces the FK on tasks.category_id, so all three batch items failed instead of the two expected. Changed to "programs" (a migration-seeded builtin). Of the 15 fixtures named for pruning, 10 turned out to cleanly pass and are gone from the list entirely: download.pause/resume/start/cancel, download.remove, download.addBatch, queue.upsert/stop, download.probe's success path (D2, including errors/download.probe.probe-failed.json), and category.upsert. Two do NOT cleanly pass and are kept, with reasons rewritten to match what's actually happening now instead of the stale D3 text: download.probe.json (see below) and errors/download.provideAuth.not-found.json, a real bug — on_download_provideAuth never checks the task exists, so an unknown taskId gets a normal `{ok:false}` result instead of -32010. Five more fixtures newly needed xfail entries to reach green, none of them stubs: - category.list.json — documented gap (deferrals.md's D3a note): the categories table has no mimeTypes/sortOrder columns. - download.probe.json, download.get.json, download.list.json, session.hello.json — not bugs. Each golden depicts a richer lifecycle state (a probed/in-progress download, a daemon with media/grabber/ Secret Service implemented) than this harness's bound tasks, which are always fresh and never started, can produce. Optional/omit-if-absent fields (effectiveUrl, requiresAuth, capabilities) are correctly absent; the mismatch is against the golden's illustrative values, not the contract. - queue.start.json, category.remove.json — same class: startedTaskIds / reassignedTaskIds are correctly empty because this run's queue/category have no real membership. `ctest -L conformance` is green: 100% (2/2), 81.7s (down from ~240s now that pairing and the port/reconnect fixes remove the retries and the 5-10s timeouts the connection-death bug was producing). One thing NOT fixed here, flagged for a follow-up decision rather than touched mid-task: download.add.json's fixture is `startMode: "now"` against a real, large (~6GB) Ubuntu ISO on the real internet, with saveDir hardcoded to /home/sami/Downloads/Programs. Every run against a real veloxd writes a real multi-GB file into that path — confirmed by running this repeatedly during verification. Isolating the daemon's XDG dirs doesn't isolate this. Worth its own change (startMode: "later" would still exercise the add path without the transfer) but out of scope for a fixture I wasn't asked to touch beyond what blocked this task. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01SFeUKLbdHizrJjLBeK7ffz	2026-09-12 14:04:18 +04:00