2 Commits

Include renames

Author	SHA1	Message	Date
samiandClaude Sonnet 5	c2eef96175	gui: floating drop target, clipboard global shortcut, theming, UI watchdog ... Continues the build order past Options/Scheduler/Speed Limiter/Batch/ Grabber/tray. - DropTargetWidget: frameless always-on-top drop target (docs/03-gui-spec.md §5), position persisted, accepts a dropped http(s) URL or link text and opens FileInfoDialog directly (skipping Add URL, since the URL is already known). Shown/hidden from general.showDropTarget, live via event.settings.changed, same pattern MainWindow already used for general.minimizeToTray. - Clipboard, explicit path #2 (docs/06-risks-and-spikes.md R2): GlobalShortcut wraps org.freedesktop.portal.GlobalShortcuts (CreateSession -> BindShortcuts -> Activated), triggering the same Add URL flow. Guarded end-to-end on `if(TARGET Qt6::DBus)` / VELOX_GUI_HAVE_DBUS so a build without the component degrades to "feature skipped," not broken (gui/docs/pkg-qa-requests-m1.md R4). Best-effort by design per the risk doc: fails silent, never advertised. Verified live against the real portal (a real Wayland session, not just offscreen): `CreateSession` refuses every caller with "An app id is required" — reproduced identically via a bare `busctl` call with no Qt involved at all, so this is the portal requiring a sandboxed caller identity, not something fixable from an unconfined process. Recorded as a partial Spike S2 answer in docs/06-risks-and-spikes.md: this explicit path likely doesn't work for Velox as a traditionally-packaged app on stock GNOME, only if/when it ships confined. Also fixed a real leak this verification caught: QDBusInterface's introspection cache reads as a LeakSanitizer leak the first time anything touches D-Bus (tst_rtl went red under ASan) — switched to QDBusMessage::createMethodCall, which needs no introspection. - Theming (docs/03-gui-spec.md §7): gui/resources/qss/{idm-like,dark}.qss, each with a documented palette block up top (QSS itself has no variable syntax), applied by ThemeManager and kept live via QStyleHints::colorSchemeChanged. util/Theme.hpp gives the handful of inline C++ styles (status dot, offline banner, the eleven identical error-label styles across dialogs) named constants instead of a twelfth copy of the same hex. - UiThreadWatchdog: the M1 DoD's 200 ms debug-build watchdog. A background std::thread pings the UI thread every 50 ms via a queued invokeMethod and warns once (not per-poll) if a ping goes unanswered past 200 ms; no QThread, no Qt event loop of its own, so the watchdog itself can never be what blocks the thread it watches. No-op in a release build. Proven both ways in tst_uithreadwatchdog: fires on a genuinely blocked UI thread (synchronous sleep, no processEvents) and stays silent on a responsive one. Full non-conformance suite (55 tests across every lane, `ctest -LE conformance`) passes clean at this point, including the whole gui label under ASan+UBSan. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NSCdCWFXBTSBBK3MzWtJiC	2026-09-12 21:30:13 +04:00
samiandClaude Sonnet 5	de83ee3cce	gui: Options, Scheduler, Speed Limiter, Batch, Grabber, and the tray icon ... Continues the build order past the Add-URL/File-Info/Progress dialog flow. - OptionsDialog: General/Save To/Connection/Downloads/Proxy/Sounds tabs, every control bound to a real settings.* key (contracts/schema/types/Settings. schema.json). The spec's File Types and Site Logins tabs have no settings.* backing (categories go through category.upsert, credentials through the Secret Service) so they don't exist here — a tab either binds to a real key or isn't shipped. diffChanged() sends only what actually changed, matching settings.set's "changed[] names exactly what took effect" contract. - SchedulerDialog: per-queue schedule (schedule.get/set) plus maxConcurrent/ onComplete (queue.upsert), Start Now/Stop. Queue.schema.json already carries the schedule so queue.list alone seeds the window. - SpeedLimiterDialog: the live global limiter (limiter.get/set) — a different thing from Options' downloads.speedLimit* default. buildParams() enforces the schema's "0 with enabled true must not be offered". - BatchDialog: clipboard-blob and {start..end}-wildcard tabs sharing one category/queue/start-mode footer into download.addBatch. - GrabberWizard: 4-step QWizard (project label -> start URL/depth/filters -> file-type filter -> review), grabber.start feeding a poll+event.grabber. progress-driven review page, Finish = grabber.harvest for the checked files. - TrayIcon: active-count tooltip, Show/Add URL/Pause All/Resume All/Speed Limiter submenu/Quit. Quit only closes the GUI — there is no RPC to stop veloxd itself, filed as a new gap in daemon-requests-m1.md. MainWindow now also hides to tray instead of closing when general.minimizeToTray is set. Every dialog's non-widget logic (diffChanged, buildSchedule, buildParams, parseUrlBlob/expandWildcard/buildAddBatchParams, buildFileTypes/ buildStartParams/buildHarvestParams) is a static pure function with its own test, same shape as FileInfoDialog::buildSpec from the previous round. Verified end-to-end against a running mockd under ASan+UBSan: all five surfaces render real data (settings.get values, queue.list's two seeded queues, limiter.get, a live grabber.start/status crawl returning 3 files) with no sanitizer reports. gui-check (non-ASan) and dev (ASan+UBSan) presets both build the whole repo clean; all gui-labeled ctest targets pass. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NSCdCWFXBTSBBK3MzWtJiC	2026-09-11 17:17:43 +04:00