gui: Options, Scheduler, Speed Limiter, Batch, Grabber, and the tray icon

Continues the build order past the Add-URL/File-Info/Progress dialog flow. - OptionsDialog: General/Save To/Connection/Downloads/Proxy/Sounds tabs, every control bound to a real settings.* key (contracts/schema/types/Settings. schema.json). The spec's File Types and Site Logins tabs have no settings.* backing (categories go through category.upsert, credentials through the Secret Service) so they don't exist here — a tab either binds to a real key or isn't shipped. diffChanged() sends only what actually changed, matching settings.set's "changed[] names exactly what took effect" contract. - SchedulerDialog: per-queue schedule (schedule.get/set) plus maxConcurrent/ onComplete (queue.upsert), Start Now/Stop. Queue.schema.json already carries the schedule so queue.list alone seeds the window. - SpeedLimiterDialog: the live global limiter (limiter.get/set) — a different thing from Options' downloads.speedLimit* default. buildParams() enforces the schema's "0 with enabled true must not be offered". - BatchDialog: clipboard-blob and {start..end}-wildcard tabs sharing one category/queue/start-mode footer into download.addBatch. - GrabberWizard: 4-step QWizard (project label -> start URL/depth/filters -> file-type filter -> review), grabber.start feeding a poll+event.grabber. progress-driven review page, Finish = grabber.harvest for the checked files. - TrayIcon: active-count tooltip, Show/Add URL/Pause All/Resume All/Speed Limiter submenu/Quit. Quit only closes the GUI — there is no RPC to stop veloxd itself, filed as a new gap in daemon-requests-m1.md. MainWindow now also hides to tray instead of closing when general.minimizeToTray is set. Every dialog's non-widget logic (diffChanged, buildSchedule, buildParams, parseUrlBlob/expandWildcard/buildAddBatchParams, buildFileTypes/ buildStartParams/buildHarvestParams) is a static pure function with its own test, same shape as FileInfoDialog::buildSpec from the previous round. Verified end-to-end against a running mockd under ASan+UBSan: all five surfaces render real data (settings.get values, queue.list's two seeded queues, limiter.get, a live grabber.start/status crawl returning 3 files) with no sanitizer reports. gui-check (non-ASan) and dev (ASan+UBSan) presets both build the whole repo clean; all gui-labeled ctest targets pass. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01NSCdCWFXBTSBBK3MzWtJiC
2026-09-11 17:17:43 +04:00
parent 39c69f3871
commit de83ee3cce
22 changed files with 2678 additions and 13 deletions
@@ -0,0 +1,87 @@
+// BatchDialog unit tests: parseUrlBlob, expandWildcard, buildAddBatchParams. Lane GUI.
+//
+// Red when the clipboard parser stops deduping or starts letting non-URL lines through,
+// the wildcard expander mishandles zero-padding or a malformed/ambiguous range, or the
+// addBatch params start including an empty optional field or leak queueId into a
+// non-"queue" startMode.
+
+#include <QtTest>
+
+#include "dialogs/BatchDialog.hpp"
+
+using velox::gui::BatchDialog;
+
+class TstBatchDialog : public QObject {
+    Q_OBJECT
+
+  private slots:
+    void parseUrlBlobDedupesAndFiltersNonUrls();
+    void parseUrlBlobTrimsAndSkipsBlankLines();
+    void expandWildcardSimpleRange();
+    void expandWildcardZeroPadded();
+    void expandWildcardNoRangeReturnsPatternIfUrl();
+    void expandWildcardMalformedRangeIsEmpty();
+    void expandWildcardAmbiguousMultiRangeIsEmpty();
+    void buildAddBatchParamsOmitsEmptyOptionalFields();
+    void buildAddBatchParamsQueueIdOnlyForQueueMode();
+};
+
+void TstBatchDialog::parseUrlBlobDedupesAndFiltersNonUrls() {
+    const QString text =
+        "https://example.test/a\nnot a url\nhttps://example.test/a\nhttps://example.test/b";
+    const QStringList urls = BatchDialog::parseUrlBlob(text);
+    QCOMPARE(urls, QStringList({"https://example.test/a", "https://example.test/b"}));
+}
+
+void TstBatchDialog::parseUrlBlobTrimsAndSkipsBlankLines() {
+    const QString text = "  https://example.test/a  \n\n\n  \n";
+    QCOMPARE(BatchDialog::parseUrlBlob(text), QStringList({"https://example.test/a"}));
+}
+
+void TstBatchDialog::expandWildcardSimpleRange() {
+    const QStringList urls = BatchDialog::expandWildcard("https://example.test/img{1..3}.jpg");
+    QCOMPARE(urls, QStringList({"https://example.test/img1.jpg", "https://example.test/img2.jpg",
+                                "https://example.test/img3.jpg"}));
+}
+
+void TstBatchDialog::expandWildcardZeroPadded() {
+    const QStringList urls = BatchDialog::expandWildcard("https://example.test/img{08..10}.jpg");
+    QCOMPARE(urls, QStringList({"https://example.test/img08.jpg", "https://example.test/img09.jpg",
+                                "https://example.test/img10.jpg"}));
+}
+
+void TstBatchDialog::expandWildcardNoRangeReturnsPatternIfUrl() {
+    QCOMPARE(BatchDialog::expandWildcard("https://example.test/a.jpg"),
+             QStringList({"https://example.test/a.jpg"}));
+    QVERIFY(BatchDialog::expandWildcard("not a url").isEmpty());
+}
+
+void TstBatchDialog::expandWildcardMalformedRangeIsEmpty() {
+    QVERIFY(BatchDialog::expandWildcard("https://example.test/img{5..1}.jpg").isEmpty());
+}
+
+void TstBatchDialog::expandWildcardAmbiguousMultiRangeIsEmpty() {
+    QVERIFY(BatchDialog::expandWildcard("https://example.test/{1..2}/img{1..3}.jpg").isEmpty());
+}
+
+void TstBatchDialog::buildAddBatchParamsOmitsEmptyOptionalFields() {
+    const QJsonObject params =
+        BatchDialog::buildAddBatchParams({"https://example.test/a"}, QString(), QString(), "now");
+    const QJsonObject defaults = params.value("defaults").toObject();
+    QVERIFY(!defaults.contains("categoryId"));
+    QVERIFY(!defaults.contains("queueId"));
+    QCOMPARE(params.value("items").toArray().size(), 1);
+}
+
+void TstBatchDialog::buildAddBatchParamsQueueIdOnlyForQueueMode() {
+    const QJsonObject queued =
+        BatchDialog::buildAddBatchParams({"https://example.test/a"}, QString(), "q1", "queue");
+    QCOMPARE(queued.value("defaults").toObject().value("queueId").toString(), QStringLiteral("q1"));
+
+    const QJsonObject notQueued =
+        BatchDialog::buildAddBatchParams({"https://example.test/a"}, QString(), "q1", "now");
+    QVERIFY(!notQueued.value("defaults").toObject().contains("queueId"));
+}
+
+QTEST_MAIN(TstBatchDialog)
+#include "tst_batchdialog.moc"