gui: Options, Scheduler, Speed Limiter, Batch, Grabber, and the tray icon
Continues the build order past the Add-URL/File-Info/Progress dialog flow.
- OptionsDialog: General/Save To/Connection/Downloads/Proxy/Sounds tabs, every
control bound to a real settings.* key (contracts/schema/types/Settings.
schema.json). The spec's File Types and Site Logins tabs have no settings.*
backing (categories go through category.upsert, credentials through the
Secret Service) so they don't exist here — a tab either binds to a real key
or isn't shipped. diffChanged() sends only what actually changed, matching
settings.set's "changed[] names exactly what took effect" contract.
- SchedulerDialog: per-queue schedule (schedule.get/set) plus maxConcurrent/
onComplete (queue.upsert), Start Now/Stop. Queue.schema.json already carries
the schedule so queue.list alone seeds the window.
- SpeedLimiterDialog: the live global limiter (limiter.get/set) — a different
thing from Options' downloads.speedLimit* default. buildParams() enforces
the schema's "0 with enabled true must not be offered".
- BatchDialog: clipboard-blob and {start..end}-wildcard tabs sharing one
category/queue/start-mode footer into download.addBatch.
- GrabberWizard: 4-step QWizard (project label -> start URL/depth/filters ->
file-type filter -> review), grabber.start feeding a poll+event.grabber.
progress-driven review page, Finish = grabber.harvest for the checked files.
- TrayIcon: active-count tooltip, Show/Add URL/Pause All/Resume All/Speed
Limiter submenu/Quit. Quit only closes the GUI — there is no RPC to stop
veloxd itself, filed as a new gap in daemon-requests-m1.md. MainWindow now
also hides to tray instead of closing when general.minimizeToTray is set.
Every dialog's non-widget logic (diffChanged, buildSchedule, buildParams,
parseUrlBlob/expandWildcard/buildAddBatchParams, buildFileTypes/
buildStartParams/buildHarvestParams) is a static pure function with its own
test, same shape as FileInfoDialog::buildSpec from the previous round.
Verified end-to-end against a running mockd under ASan+UBSan: all five
surfaces render real data (settings.get values, queue.list's two seeded
queues, limiter.get, a live grabber.start/status crawl returning 3 files) with
no sanitizer reports. gui-check (non-ASan) and dev (ASan+UBSan) presets both
build the whole repo clean; all gui-labeled ctest targets pass.
Co-Authored-By: Claude Sonnet 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01NSCdCWFXBTSBBK3MzWtJiC
This commit is contained in:
@@ -37,3 +37,20 @@ as a reference for what "no size" currently looks like end to end.
|
||||
Not urgent — mockd always supplies `sizeBytes`, so this doesn't block M1 GUI work — but
|
||||
worth knowing before the M1 GUI↔real-daemon integration pass, since the percentage bar is
|
||||
the headline visual of the main table.
|
||||
|
||||
## No method exists to stop `veloxd` itself
|
||||
|
||||
`docs/03-gui-spec.md` §5 describes the tray's Quit as asking "whether to also stop the
|
||||
daemon". `contracts/schema/methods/` has nothing for it — no `daemon.stop`/`daemon.shutdown`,
|
||||
and `Queue.onComplete`'s `"shutdown"` value is a *system* shutdown via
|
||||
`org.freedesktop.login1`, a different thing entirely. This is a schema read, not something
|
||||
that needed a live daemon to confirm — the method list is exhaustive and checkable
|
||||
directly.
|
||||
|
||||
**Effect on the GUI:** `TrayIcon`'s Quit is implemented as "quit the GUI only; downloads
|
||||
continue under the Velox service" — accurate today, since nothing else is possible, but it
|
||||
means the spec's described behaviour (offer to also stop the service) has no RPC to build
|
||||
on. Not urgent for M1 — CLI/systemd already stop `veloxd` outside the GUI — but worth a
|
||||
`contracts/`-only PR (new privileged UDS-only method, `x-deadlineMs` generous enough to
|
||||
cover in-flight transfers being paused first) before that tray menu item claims to do more
|
||||
than it does.
|
||||
|
||||
Reference in New Issue
Block a user